Re: [PATCH] inputthread: Fix inputthread not listening if a fd gets re-added immediately after removal

2016-10-11 Thread Mihail Konev
On Tue Oct 11 09:30:16 UTC 2016, Hans de Goede wrote: > I've attached another patch (on top of my previous one) for you to try, > I've good hope that this will fix your issue. Fixes #97880, thanks. ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH] inputthread: Fix inputthread not listening if a fd gets re-added immediately after removal

2016-10-11 Thread Hans de Goede
Hi, On 10/09/2016 11:52 PM, Mihail Konev wrote: Hello. On Wed, 5 Oct 2016 14:45:20 +0200, Hans de Goede wrote: When a fd is removed dev->state gets set to device_state_removed, if the fd then gets re-added before InputThreadDoWork() deals with the removal, the InputThreadDevice struct gets re

Re: [PATCH] inputthread: Fix inputthread not listening if a fd gets re-added immediately after removal

2016-10-11 Thread Michel Dänzer
On 10/10/16 06:52 AM, Mihail Konev wrote: > On 6 Oct 2016, Hans de Goede wrote: >> On 24-09-16 19:55, Mihail Konev wrote: >>> <..> >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97880 >> >> Thank you for the patch and you're right that there is an issue here. >> >> I've posted a much si

Re: [PATCH] inputthread: Fix inputthread not listening if a fd gets re-added immediately after removal

2016-10-10 Thread Mihail Konev
Hello. On Wed, 5 Oct 2016 14:45:20 +0200, Hans de Goede wrote: > When a fd is removed dev->state gets set to device_state_removed, > if the fd then gets re-added before InputThreadDoWork() deals with > the removal, the InputThreadDevice struct gets reused, but its > state would stay device_state_

Re: [PATCH] inputthread: Fix inputthread not listening if a fd gets re-added immediately after removal

2016-10-05 Thread Keith Packard
Hans de Goede writes: > When a fd is removed dev->state gets set to device_state_removed, > if the fd then gets re-added before InputThreadDoWork() deals with > the removal, the InputThreadDevice struct gets reused, but its > state would stay device_state_removed, so it would still get removed >