On 13 October 2016 at 04:58, Peter Hutterer <peter.hutte...@who-t.net> wrote: > From: Niels Ole Salscheider <niels_...@salscheider-online.de> > > Catch the error case separately. Commit 19a9cd607d added length checking to > SizeClassInfo but re-used the return value of 0 for an error. A device without > classes (as is initialized by xf86-input-libinput for tablets) can > legitimately return 0 and erroneously triggers an error. > Fix this by using a separate value for the error. > > Reproducible by calling XListInputDevices() with a tablet attached. > > This fixes a regression introduced in commit 19a9cd607d. > > Signed-off-by: Niels Ole Salscheider <niels_...@salscheider-online.de> > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > --- > Changes to v1: > - don't touch *size until we're sure. > - expand commit message > A lot better imho.
Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> -Emil _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
