Re: [PATCH xserver] modesetting: Fix inverted check in dri2 WaitMSC

2018-04-17 Thread Adam Jackson
On Mon, 2018-04-16 at 22:58 +, Mike Lothian wrote: > I've applied this too as part of my testing, I don't see a dri3 file > - does that mean the dri2 one covers both dri2&3? It covers just DRI2. In the DRI3 model the equivalent operation lives in Present (.../present.c), and the code there doe

Re: [PATCH xserver] modesetting: Fix inverted check in dri2 WaitMSC

2018-04-17 Thread Walter Harms
> Frank Binns hat am 16. April 2018 um 22:17 > geschrieben: > > > Adam Jackson writes: > > > ms_queue_vblank() returns false on failure. > > > > Reported-by: Chris Wilson > > Signed-off-by: Adam Jackson > > Reviewed-by: Frank Binns > > > --- > > hw/xfree86/drivers/modesetting/dri2.c |

Re: [PATCH xserver] modesetting: Fix inverted check in dri2 WaitMSC

2018-04-16 Thread Mike Lothian
I've applied this too as part of my testing, I don't see a dri3 file - does that mean the dri2 one covers both dri2&3? If it doesn't please ignore Tested-by: Mike Lothian On Mon, 16 Apr 2018 at 21:17 Frank Binns wrote: > Adam Jackson writes: > > > ms_queue_vblank() returns false on failure.

Re: [PATCH xserver] modesetting: Fix inverted check in dri2 WaitMSC

2018-04-16 Thread Frank Binns
Adam Jackson writes: > ms_queue_vblank() returns false on failure. > > Reported-by: Chris Wilson > Signed-off-by: Adam Jackson Reviewed-by: Frank Binns > --- > hw/xfree86/drivers/modesetting/dri2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/xfree86/drivers/m