Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-16 Thread Mario Kleiner
On Mon, Apr 16, 2018 at 7:04 PM, Mike Lothian wrote: > Hi Mario > > Have you also tried starting a wayland Kwin session to see if Xwayland > works? X apps don't work for me > Nope. Only KUbuntu 16.04.3 LTS + native X-Server 1.20-RC4, with all kinds of permutations of

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-16 Thread Mike Lothian
Hi Mario Have you also tried starting a wayland Kwin session to see if Xwayland works? X apps don't work for me Cheers Mike On Mon, 16 Apr 2018 at 07:37 Mario Kleiner wrote: > Hi again, > > with the fresh x-server patch i just sent out, the EGL + DRI3 problems >

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-16 Thread Mario Kleiner
Hi again, with the fresh x-server patch i just sent out, the EGL + DRI3 problems under KDE are gone, at least as tested on an old Intel Ironlake and GeForce Tesla. I still see some more problems beyond those, which may or may not be related to the new DRI3.1/3.2 stuff. On KDE-5 the KDE panel

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-06 Thread Daniel Stone
Hi, On 6 April 2018 at 09:48, Mike Lothian wrote: > Thanks for reminding me about GLX vs EGL > > The config option in KDE was removed from the System Setting app and can > only be adjusted manually in in ~/.config/kwinrc > > GLPlatformInterface=egl > > This might explain why

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-06 Thread Mike Lothian
Hi Mario Thanks for reminding me about GLX vs EGL The config option in KDE was removed from the System Setting app and can only be adjusted manually in in ~/.config/kwinrc GLPlatformInterface=egl This might explain why Daniel hasn't been seeing the issues I've been seeing Cheers Mike On

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-05 Thread Mario Kleiner
I'm sorry to report it didn't fix it. This tested with current head of xserver master, mesa master, so with my and your fixes included, and apparently some new fixes from today. Compositing under old Ubuntu Unity-7 == compiz and Gnome shell work fine, as does KDE-5 Plasma with GLX+OpenGL

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-04 Thread Daniel Stone
Hi Mario, On 4 April 2018 at 17:40, Mario Kleiner wrote: > On Wed, Apr 4, 2018 at 6:19 PM, Daniel Stone wrote: >> Ugh. I've applied your pageflip patch, lfrb's two-patch atomic fix >> series and my fix-old-clients series, which for me fixes KDE

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-04 Thread Mario Kleiner
On Wed, Apr 4, 2018 at 6:19 PM, Daniel Stone wrote: > Hi Mario, > > On 4 April 2018 at 06:22, Mario Kleiner wrote: >> Ok, so it's probably a mesa bug in the egl dri3 backend caused by the >> new DRI3.1 multibuffers support. >> >> If on current

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-04 Thread Daniel Stone
Hi Mario, On 4 April 2018 at 06:22, Mario Kleiner wrote: > Ok, so it's probably a mesa bug in the egl dri3 backend caused by the > new DRI3.1 multibuffers support. > > If on current mesa master, in egl_dri2.c:dri2_setup_extensions(), i > force

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-03 Thread Mario Kleiner
Ok, so it's probably a mesa bug in the egl dri3 backend caused by the new DRI3.1 multibuffers support. If on current mesa master, in egl_dri2.c:dri2_setup_extensions(), i force dri2_dpy->multibuffers_available = false; to disable multibuffers, then EGL based compositing under DRI3 works fine

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-03 Thread Mario Kleiner
Will check it later when i'm at the machines. But does Ivybridge/Gen-7 even have CCS? I can't test with something more modern Intel atm. -mario On Tue, Apr 3, 2018 at 5:57 PM, Daniel Stone wrote: > On 3 April 2018 at 16:36, Mario Kleiner

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-03 Thread Daniel Stone
On 3 April 2018 at 16:36, Mario Kleiner wrote: > Btw. another new problem, which i haven't had time to track down at > all is that desktop composition under EGL seems to be totally broken. > Tested on KUbuntu 16.0.4 LTS with xserver master + mesa master last > thursday

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-03 Thread Mario Kleiner
Btw. another new problem, which i haven't had time to track down at all is that desktop composition under EGL seems to be totally broken. Tested on KUbuntu 16.0.4 LTS with xserver master + mesa master last thursday with whatever KDE Plasma 5 version ships with 16.04. Compositing with XRender accel

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-03 Thread Daniel Stone
Hi Mario, On 3 April 2018 at 15:44, Mario Kleiner wrote: > Those are fine according to my testing, they fix mode-setting under > both depth24 and 30. > > However as testing shows, still not sufficient for pageflipping if the > kms driver doesn't support full atomic

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-03 Thread Mario Kleiner
Those are fine according to my testing, they fix mode-setting under both depth24 and 30. However as testing shows, still not sufficient for pageflipping if the kms driver doesn't support full atomic (as tested on radeon-kms, and as well under nouveau-kms without the nouveau.atomic=1 kernel boot

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-29 Thread Olivier Fourdan
Hi Mario, On Wed, Mar 28, 2018 at 7:42 PM, Mario Kleiner wrote: > The approach in the patch looks good to me, same as we use in weston. > I'll test in a few hours and let you know. > Can you try with Luis-Francis's series (2 patches):

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-28 Thread Mario Kleiner
The approach in the patch looks good to me, same as we use in weston. I'll test in a few hours and let you know. thanks, -mario On Wed, Mar 28, 2018 at 5:58 AM, Louis-Francis Ratté-Boulianne wrote: > Hi Mario, > > Could you try with the following patch and let me know how

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-28 Thread Olivier Fourdan
Hi, On Wed, Mar 28, 2018 at 2:59 PM, Olivier Fourdan wrote: > > It definitely improves the situation yet there is probably more to it > because with this added on top of the current git master, only the laptop > output works, the external monitor connected to the docking

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-28 Thread Olivier Fourdan
Hi, On Wed, Mar 28, 2018 at 9:03 AM, Olivier Fourdan wrote: > On Wed, Mar 28, 2018 at 5:58 AM, Louis-Francis Ratté-Boulianne < > l...@collabora.com> wrote: > >> Could you try with the following patch and let me know how things are >> working out: >> >>

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-28 Thread Olivier Fourdan
Hi, On Wed, Mar 28, 2018 at 5:58 AM, Louis-Francis Ratté-Boulianne < l...@collabora.com> wrote: > Could you try with the following patch and let me know how things are > working out: > > https://gitlab.collabora.com/lfrb/xserver/commit/d26b45afc19547ab3ff689 > 581db2b01abb4e1ed2 > That requires

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-27 Thread Louis-Francis Ratté-Boulianne
Hi Mario, Could you try with the following patch and let me know how things are working out: https://gitlab.collabora.com/lfrb/xserver/commit/d26b45afc19547ab3ff689 581db2b01abb4e1ed2 It shouldn't differ much from your patch though and I still don't understand why pageflip would fail for you.

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-27 Thread Olivier Fourdan
Hi, On Mon, Mar 26, 2018 at 7:54 PM, Mario Kleiner wrote: > [...] > I haven't had time to retest with the latest patch on master of Adam > "modesetting: Fix up some XXX from removing GLAMOR_HAS_DRM_*" > yet, so maybe that makes a positive difference? My testing was

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-26 Thread Mario Kleiner
On what Intel gpu generation did you try to reproduce? When testing on intel-kms on both Ivybridge and Ironlake, i had modesetting failure because argb is not supported by the intel kms driver on pre-Skylake. When i applied the patch to drmmode_display.c i showed in the previous mail to

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-25 Thread Louis-Francis Ratté-Boulianne
Hi, What do you mean by pageflipping not properly working? I've tried to reproduce the issue, and pageflipping seems to work fine. Also, we can't unfortunately just use always XRGB formats in glamor (we need to check wheither depth is 24 or 32) as it would break actual partly-transparent or

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-23 Thread Mario Kleiner
Unfortunately not the real fix. I developed the same patch like you propose in that bugzilla as a 1st try: --- a/hw/xfree86/drivers/modesetting/drmmode_display.c +++ b/hw/xfree86/drivers/modesetting/drmmode_display.c @@ -711,9 +711,9 @@ drmmode_create_bo(drmmode_ptr drmmode, drmmode_bo *bo,

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-23 Thread Olivier Fourdan
Hi On Wed, Mar 21, 2018 at 10:09 PM, Mario Kleiner wrote: > Thanks. However, seems we may have one more problem with the new code > on slightly older < gen 9 Intel hw. Either that, or something is > botched on my system atm., after pulling in all kind of updates to >

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-21 Thread Mario Kleiner
Thanks. However, seems we may have one more problem with the new code on slightly older < gen 9 Intel hw. Either that, or something is botched on my system atm., after pulling in all kind of updates to xorg-proto and xcb-proto and libdrm and stuff to make the server and mesa compile again. Using

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-21 Thread Adam Jackson
On Mon, 2018-03-12 at 17:11 +, Daniel Stone wrote: > On 12 March 2018 at 16:57, Mario Kleiner wrote: > > The check for "no modifier specified" in drmmode_is_format_supported() > > should check for DRM_FORMAT_MOD_INVALID, not for zero, as zero actually > > means

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-12 Thread Daniel Stone
On 12 March 2018 at 16:57, Mario Kleiner wrote: > The check for "no modifier specified" in drmmode_is_format_supported() > should check for DRM_FORMAT_MOD_INVALID, not for zero, as zero actually > means DRM_FORMAT_MOD_LINEAR. If I had a time machine, that would