Re: [PATCH xserver 2/2] glamor: Avoid overflow between box32 and box16 box

2017-08-28 Thread Keith Packard
Olivier Fourdan writes: > Sorry for the delay, I was on PTO... > > What I observed is that the issue occurs because temp_box.x2 is 32768: > > https://bugs.freedesktop.org/show_bug.cgi?id=101894#c6 oh, that can happen if repeate_type is not RepeatNone, is that the case here? I'm just trying to m

Re: [PATCH xserver 2/2] glamor: Avoid overflow between box32 and box16 box

2017-08-28 Thread Olivier Fourdan
Hi Keith, > > @@ -722,11 +723,11 @@ glamor_compute_transform_clipped_regions(PixmapPtr > > pixmap, > > temp_box.x2 = MIN(temp_box.x2, pixmap->drawable.width); > > temp_box.y2 = MIN(temp_box.y2, pixmap->drawable.height); > > } > > -/* Now copy back the box32 to a box16 bo

Re: [PATCH xserver 2/2] glamor: Avoid overflow between box32 and box16 box

2017-08-05 Thread Keith Packard
Olivier Fourdan writes: > @@ -722,11 +723,11 @@ glamor_compute_transform_clipped_regions(PixmapPtr > pixmap, > temp_box.x2 = MIN(temp_box.x2, pixmap->drawable.width); > temp_box.y2 = MIN(temp_box.y2, pixmap->drawable.height); > } > -/* Now copy back the box32 to a box1