Re: Buildability of the Xorg drivers
On Thu, Feb 03, 2022 at 02:07:08AM +, Zack Rusin wrote: > > > > On Feb 2, 2022, at 15:27, Matt Turner wrote: > > > > On Sun, Jan 30, 2022 at 4:16 PM Alan Coopersmith > > wrote: > >> xf86-input-vmmouse > >> xf86-video-vmware > >> - do not allow merge requests > > > > This has been an issue before, in conjunction with not even knowing > > who the nominal maintainer was. E.g. someone submitted a patch almost > > a year ago > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.x.org%2Farchives%2Fxorg-devel%2F2021-March%2F058688.htmldata=04%7C01%7Czackr%40vmware.com%7C28b295c074264147244e08d9e68a7838%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637794304668232703%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000sdata=Zj%2Fnj4NL4pRtM7Cb0AwzAQlZQFMYBS3kDQhTtAfqUXU%3Dreserved=0 > > after asking on IRC how to make a merge request and being told... > > dunno, looks like you can't? Can we just turn on MRs for these > > projects? > > > > I see Zack recently joined the project on Gitlab and pushed to master, > > so Cc'ing him. > > Hey, yes, that’s correct, I’ll be maintaining those drivers going forward. > > I did enable MR’s on xf86-video-vmware. I’m actually not a member of > xf86-input-vmmouse so if someone could add me then I’ll enable MR’s in there > as well. Turns out I had sufficient superpowers on vmmouse to do exactly that. All hail to the new maintainer. Cheers, Peter
Re: Buildability of the Xorg drivers
> On Feb 2, 2022, at 15:27, Matt Turner wrote: > > On Sun, Jan 30, 2022 at 4:16 PM Alan Coopersmith > wrote: >> xf86-input-vmmouse >> xf86-video-vmware >> - do not allow merge requests > > This has been an issue before, in conjunction with not even knowing > who the nominal maintainer was. E.g. someone submitted a patch almost > a year ago > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.x.org%2Farchives%2Fxorg-devel%2F2021-March%2F058688.htmldata=04%7C01%7Czackr%40vmware.com%7C28b295c074264147244e08d9e68a7838%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637794304668232703%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000sdata=Zj%2Fnj4NL4pRtM7Cb0AwzAQlZQFMYBS3kDQhTtAfqUXU%3Dreserved=0 > after asking on IRC how to make a merge request and being told... > dunno, looks like you can't? Can we just turn on MRs for these > projects? > > I see Zack recently joined the project on Gitlab and pushed to master, > so Cc'ing him. Hey, yes, that’s correct, I’ll be maintaining those drivers going forward. I did enable MR’s on xf86-video-vmware. I’m actually not a member of xf86-input-vmmouse so if someone could add me then I’ll enable MR’s in there as well. z
Re: Buildability of the Xorg drivers
On 2/2/22 12:27, Matt Turner wrote:
On Sun, Jan 30, 2022 at 4:16 PM Alan Coopersmith
wrote:
xf86-input-vmmouse
xf86-video-vmware
- do not allow merge requests
This has been an issue before, in conjunction with not even knowing
who the nominal maintainer was. E.g. someone submitted a patch almost
a year ago https://lists.x.org/archives/xorg-devel/2021-March/058688.html
after asking on IRC how to make a merge request and being told...
dunno, looks like you can't? Can we just turn on MRs for these
projects?
That's a policy question at this point. I thought MR's were turned on for
all the xorg modules after the migration except for drivers, and that for
drivers we left it up to the maintainers (if there were any) to decide.
I did turn on MR's for xf86-video-vbox as part of this work, since that driver
is now under community maintenance since the original author passed away, and
the Oracle Virtualbox team is supporting the new DRI/KMS based driver instead.
(This older driver was mostly published as a favor to Solaris, so we could keep
shipping an Xorg driver without having to port the kernel side to our kernel,
but could be used on other kernels as well.)
xf86-video-glint
- Doesn't build due to the removal of ramdac drivers from Xorg:
https://gitlab.freedesktop.org/xorg/driver/xf86-video-glint/-/issues/1
xf86-video-s3
- Doesn't build due to the removal of ramdac drivers from Xorg, including
"IBM.h" and "TI.h"
xf86-video-tga
- Doesn't build due to the removal of ramdac drivers from Xorg, including
"BT.h"
Maybe we could make a libRAMDAC out of the removed files and these
drivers could link against it. I'll give that a shot when I have time.
A library consumed by drivers is odd, but less odd than the xf86-video-v4l
module which I have to remember isn't really a normal driver when I see it.
I did also note that many of the video drivers still have code like:
if (!xf86LoadSubModule(pScrn, "ramdac"))
return FALSE;
or
if (pCg6->HWCursor && xf86LoadSubModule(pScrn, "ramdac") == NULL) {
CG6FreeRec(pScrn);
return FALSE;
}
which is unnecessary since the ramdac module was changed from loadable to
builtin by commit ae75019c in 2007, for Xorg 1.4, though it won't break as
long as we don't remove "ramdac" from the compiled_in_modules list in
hw/xfree86/loader/loadmod.c.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - https://blogs.oracle.com/solaris
Re: Buildability of the Xorg drivers
On Sun, Jan 30, 2022 at 4:16 PM Alan Coopersmith wrote: > xf86-input-vmmouse > xf86-video-vmware >- do not allow merge requests This has been an issue before, in conjunction with not even knowing who the nominal maintainer was. E.g. someone submitted a patch almost a year ago https://lists.x.org/archives/xorg-devel/2021-March/058688.html after asking on IRC how to make a merge request and being told... dunno, looks like you can't? Can we just turn on MRs for these projects? I see Zack recently joined the project on Gitlab and pushed to master, so Cc'ing him. > xf86-video-glint >- Doesn't build due to the removal of ramdac drivers from Xorg: > https://gitlab.freedesktop.org/xorg/driver/xf86-video-glint/-/issues/1 > > xf86-video-s3 >- Doesn't build due to the removal of ramdac drivers from Xorg, including > "IBM.h" and "TI.h" > > xf86-video-tga >- Doesn't build due to the removal of ramdac drivers from Xorg, including > "BT.h" Maybe we could make a libRAMDAC out of the removed files and these drivers could link against it. I'll give that a shot when I have time.
