Dima Ryazanov writes:
> We don't even need to simulate button clicks; it's done automatically.
> This also fixes scrolling in Qt5 apps.
Merged.
9ff89a2..81a51a6 master -> master
--
-keith
signature.asc
Description: PGP signature
___
xorg-devel@
, wl_fixed_t value)
> {
> struct xwl_seat *xwl_seat = data;
> -int index, count;
> -int i, val;
> +int index;
> const int divisor = 10;
> ValuatorMask mask;
>
> -if (time - xwl_seat->scroll_time > 2000) {
> -xwl_se
int i, val;
+int index;
const int divisor = 10;
ValuatorMask mask;
-if (time - xwl_seat->scroll_time > 2000) {
-xwl_seat->vertical_scroll = 0;
-xwl_seat->horizontal_scroll = 0;
-}
-xwl_seat->scroll_time = time;
-
-/* FIXME: Need to do pro
Hi,
All patches in this series look good and are:
Reviewed-by: Hans de Goede
Regards,
Hans
On 11-03-15 06:53, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
---
configure.ac | 12 ++--
src/evdev.c | 93
src/evdev.h
Signed-off-by: Peter Hutterer
---
configure.ac | 12 ++--
src/evdev.c | 93
src/evdev.h | 16 ---
3 files changed, 2 insertions(+), 119 deletions(-)
diff --git a/configure.ac b/configure.ac
index 46f3dc7..e53177e 100644
-
Disables the button click generation (EvdevWheelEmuInertia) and
generates scroll valuator events directly.
Signed-off-by: Max Schwarz
---
I tried to support turning wheel emulation on/off at runtime.
This involves calling InitValuatorClassDeviceStruct() again
to add the new valuators or remove th
On Thu, Oct 04, 2012 at 01:16:35PM +0200, Michal Suchanek wrote:
> Hello,
>
> On 4 October 2012 11:23, Sascha Hlusiak wrote:
>
> >> I'm not sure what you mean by "Followed by smooth scrolling". Once you
> >> enable smooth scrolling, you don
Hello,
On 4 October 2012 11:23, Sascha Hlusiak wrote:
>> I'm not sure what you mean by "Followed by smooth scrolling". Once you
>> enable smooth scrolling, you don't send button 4/5 presses anymore, only
>> the valuator events. the rest is handled in the s
erate a
> > XI1/legacy scroll button down/up sequence. Is there a way to reset that
> > server internal delta to 0 after scrolling stops? It seems that smooth
> > scrolling might leave that value at 99, which makes it impossible for
> > me to predict when the next legacy button
On Wed, Oct 03, 2012 at 07:17:08PM +0200, Sascha Hlusiak wrote:
> Hi Peter,
>
> I'd like to implement smooth scrolling in the joystick input module. By
> calling
>
> SetScrollValuator(pDevice, 2, SCROLL_TYPE_VERTICAL, 100, 0);
>
> I can set the scroll resolution
Hi Peter,
I'd like to implement smooth scrolling in the joystick input module. By
calling
SetScrollValuator(pDevice, 2, SCROLL_TYPE_VERTICAL, 100, 0);
I can set the scroll resolution of the valuator 2 to 100. As far as I
understand, I now can send valuator movement that XI2 applica
018, the delta was incremented by
> the delta only, scroll dist was used as increment in the smooth scrolling
> information. On non-smooth-scrolling servers, the driver would now send
> too many events. Restore the old behaviour by dividing by the scroll
> distance before entering the but
as increment in the smooth scrolling
information. On non-smooth-scrolling servers, the driver would now send
too many events. Restore the old behaviour by dividing by the scroll
distance before entering the button click loop.
X.Org Bug 46617 <http://bugs.freedesktop.org/show_bug.cgi?id=46617>
From: Daniel Stone
Post smooth-scrolling events through the new X server API when
available, rather than legacy jerky button events.
[Amended to use the final smooth scrolling API]
Signed-off-by: Daniel Stone
Amendments-by: Peter Hutterer
Signed-off-by: Peter Hutterer
---
src/synaptics.c
On Thu, Oct 06, 2011 at 11:45:58PM +0200, Max Schwarz wrote:
> Hi Peter,
>
> > you could make the support compiled in, but not compiled _out_. so even if
> > you HAVE_SMOOTH_SCROLLING, the old bits are ready to go when enabled.
> > if no smooth scrolling axis is otherwi
Hi Peter,
> you could make the support compiled in, but not compiled _out_. so even if
> you HAVE_SMOOTH_SCROLLING, the old bits are ready to go when enabled.
> if no smooth scrolling axis is otherwise present on the device, just post
> button events as previously.
Well, the proper
On Tue, Oct 04, 2011 at 09:53:56PM +0200, Max Schwarz wrote:
> This adds support for the new smooth-scrolling valuator system to
> the wheel emulation code.
>
> Caveats:
> - Enabling wheel emulation at runtime does not work if the device
>does not provide the necessary
On Tue, Oct 04, 2011 at 09:53:56PM +0200, Max Schwarz wrote:
> This adds support for the new smooth-scrolling valuator system to
> the wheel emulation code.
>
> Caveats:
> - Enabling wheel emulation at runtime does not work if the device
>does not provide the nece
This adds support for the new smooth-scrolling valuator system to
the wheel emulation code.
Caveats:
- Enabling wheel emulation at runtime does not work if the device
does not provide the necessary axes already.
- Horizontal scrolling is always reported on the REL_HWHEEL axis,
ignoring a
Hi,
On 3 October 2011 11:50, Max Schwarz wrote:
>> Input: Add smooth-scrolling support to GetPointerEvents
> There's a subtle bug on that one: Old-style scroll button presses create
> inverted emulated presses (and maybe inverted valuator events, but I don't
> kn
.c:DeliverRawEvent
> Support (and require) XI 2.1
> input: deliver raw events unconditionally for XI 2.1 clients.
> dix: use 'rc' for return code in DeliverRawEvent
> Merge branch 'raw-events' into next
> Input: Add smooth-scrolling
Hi Peter,
> Input: Add smooth-scrolling support to GetPointerEvents
There's a subtle bug on that one: Old-style scroll button presses create
inverted emulated presses (and maybe inverted valuator events, but I don't
know which direction is 'up' or 'down'
I've added Alan's compiler warning fix to this branch.
New tip: 524e5445c0b6df5247d4aac5368470bb89ef4080
On Fri, Sep 30, 2011 at 09:51:38AM +1000, Peter Hutterer wrote:
> This is the now finally reviewed smooth scrolling branch and the raw events,
> along with the new input ABI ch
This adds support for the new smooth-scrolling valuator system to
the wheel emulation code.
Caveats:
- Enabling wheel emulation at runtime does not work if the device
does not provide the necessary axes already.
- Horizontal scrolling is always reported on the REL_HWHEEL axis,
ignoring a
This is the now finally reviewed smooth scrolling branch and the raw events,
along with the new input ABI changes (which are spread over a set of commits
but at least this way they're in one merge only)
Commit f32c827d513c44f07e1d0fbcc0c96cef18c9a4d9
The following changes since c
scroll_axis = pDev->valuator->v_scroll_axis;
+ValuatorMask mask;
+ValuatorMask scroll;
+int i;
/* refuse events from disabled devices */
if (!pDev->enabled)
@@ -1204,8 +1301,73 @@ GetPointerEvents(InternalEvent *events, DeviceIntPtr
pDev, int type,
events = UpdateFromMas
s in,
> no?
By the time we get here, we're in absolute coordinates. So what we need to
do is
if (!valuator_mask_isset(last, axis))
valuator_mask_set(last, axis, 0);
This way, the very first event on this axis is handled as you described and
for any future events we're fine.
> >
Hi,
On 23 September 2011 00:14, Peter Hutterer wrote:
> [general reassurance]
Reviewed-by: Daniel Stone
Cheers,
Daniel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/lis
is, we won't generate anything until the second event comes in,
no?
> @@ -1193,7 +1288,12 @@ GetPointerEvents(InternalEvent *events, DeviceIntPtr
> pDev, int type,
> int buttons, int flags, const ValuatorMask *mask_in)
> {
> CARD32 ms = GetTimeInMillis();
> - in
I found a bug in the stack of scrolling patches that caused a server lockup.
Introduced by a recent rebase, but I found a few other issues and
incorporated daniels' comments into this patch and squashed them all
together. This is just one big patch to add smooth scrolling support instead
o
On Thu, Sep 22, 2011 at 11:05:42AM +0100, Daniel Stone wrote:
> Hi,
>
> On Mon, Aug 22, 2011 at 03:35:15PM +1000, Peter Hutterer wrote:
> > +#ifdef HAVE_SMOOTH_SCROLLING
> > +if (axis == REL_WHEEL)
> > +SetScrollValuator(device, axnum, SCROLL_TYPE_VERTICAL, 1.0,
> > SCROLL_FLA
On Mon, Aug 22, 2011 at 03:35:14PM +1000, Peter Hutterer wrote:
> This is the patchset for the revised smooth scrolling support. The basic
> principle stays the same (valuator information instead of button
> clicks), the protocol itself chanages a bit. Instead of a dedicated virtual
>
Hi,
On Mon, Aug 22, 2011 at 03:35:15PM +1000, Peter Hutterer wrote:
> +#ifdef HAVE_SMOOTH_SCROLLING
> +if (axis == REL_WHEEL)
> +SetScrollValuator(device, axnum, SCROLL_TYPE_VERTICAL, 1.0,
> SCROLL_FLAG_PREFERRED);
> +else if (axis == REL_DIAL)
> +SetScroll
This is a resend of the pull request
http://lists.freedesktop.org/archives/xorg-devel/2011-September/024938.html
This time all three (smooth scrolling, -next and two-screen-coordinates) in
one branch. Neither smooth scrolling nor two-screen-coordinates has reviews
but I've stopped caring no
mask_in);
+
+valuator_mask_copy(&mask, mask_in);
+
+/* Turn a scroll button press into a smooth-scrolling event if necessary.
*/
+if (type == ButtonPress)
+{
+double val, adj;
+int axis;
+
+switch (buttons) {
+case 4:
+adj =
This patchset adds smooth scrolling support to the server. Unfortunatley,
except for Daniel's patch the others are still unreviewed. Pull at your
leisure.
This branch merges on top of -next, no conflicts.
commit 53f7e75ad6cfc01270ce01dfa79a4ab80eeaac3f
Cheers,
Peter
The following ch
mask_in);
+
+valuator_mask_copy(&mask, mask_in);
+
+/* Turn a scroll button press into a smooth-scrolling event if necessary.
*/
+if (type == ButtonPress)
+{
+double val, adj;
+int axis;
+
+switch (buttons) {
+case 4:
+adj =
These need some review lovin'. Patches 1-3 were on the list already, please
go through them so I can send my next branch to keith.
Cheers,
Peter
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http:
alEvent *events, DeviceIntPtr
pDev, int type,
events = UpdateFromMaster(events, pDev, DEVCHANGE_POINTER_EVENT,
&num_events);
-num_events += fill_pointer_events(events, pDev, type, buttons, ms, flags,
- mask_in);
+
+valuator_
From: Daniel Stone
Two new axes are added to support smooth scrolling: Rel Vert Scroll and
Rel Horiz Scroll. Cumulative values of 1.0 with either magnitude on
these axes are considered to be equivalent to one legacy ButtonPress
event on the scroll buttons.
Signed-off-by: Daniel Stone
Reviewed
Automatic smooth scrolling setup for these axes, with REL_WHEEL and REL_DIAL
both mapping into vscrolling. REL_WHEEL is the preferred axis.
Mouse wheel emulation is not yet updated for smooth scrolling.
Signed-off-by: Peter Hutterer
---
src/evdev.c | 17 -
src/evdev.h |4
This is the patchset for the revised smooth scrolling support. The basic
principle stays the same (valuator information instead of button
clicks), the protocol itself chanages a bit. Instead of a dedicated virtual
axis, mark those axes the hardware supplies as scrolling axis. The option of
a
Hi,
On Tue, Aug 16, 2011 at 10:00:41AM +1000, Peter Hutterer wrote:
> diff --git a/XI2proto.h b/XI2proto.h
> index 8977e87..03ead01 100644
> --- a/XI2proto.h
> +++ b/XI2proto.h
> @@ -186,9 +186,11 @@ typedef struct {
> uint8_t mode; /**< ModeRelative or ModeAbsolute */
> ui
On Mon, Aug 15, 2011 at 09:40:55PM +1000, Peter Hutterer wrote:
> On 15/08/11 21:09 , Daniel Stone wrote:
> >On Mon, Aug 15, 2011 at 03:28:03PM +1000, Peter Hutterer wrote:
> >>+The behavior of the server if there is more than one VertScroll or more
> >>than
> >>+one HorizScroll axes on the same d
ranch, it won't apply to
> master.
>
> dix/getevents.c | 41 +
> 1 files changed, 25 insertions(+), 16 deletions(-)
[...]
> @@ -1259,11 +1268,14 @@ GetPointerEvents(InternalEvent *events, DeviceIntPtr
> pDev, int type,
> num_ev
Using labels only to mark smooth scrolling axes disallows scrolling from
hardware events (e.g. a mouse wheel). If those axes are marked as scrolling
axes instead, the clients lose information which hardware axis this event
corresponds to.
For example, on Wacom devices, the client can benefit from
On 15/08/11 21:09 , Daniel Stone wrote:
Hi,
Looks good to me generally, but:
On Mon, Aug 15, 2011 at 03:28:03PM +1000, Peter Hutterer wrote:
+Newer X servers may provide scrolling information through specific
+valuators to provide scroll events with more precision than the button
+events. Valua
Hi,
Looks good to me generally, but:
On Mon, Aug 15, 2011 at 03:28:03PM +1000, Peter Hutterer wrote:
> +Newer X servers may provide scrolling information through specific
> +valuators to provide scroll events with more precision than the button
> +events. Valuators for axes sending scrolling infor
After starting to write some more documentation on the smooth scrolling and
trying to implement evdev support for it, I ran into an issue. evdev
currently exports axes as the kernel labels them, allowing for clients to
know _what_ an axis is (as opposed to XI 1.x where axis 3 was pressure only
by
= (int)pDev->last.valuators[h_scroll_axis];
+
/* First fill out the original event set, with smooth-scrolling axes. */
nev_tmp = fill_pointer_events(events, pDev, type, buttons, ms, flags,
&mask);
@@ -1259,11 +1268,14 @@ GetPointerEvents(InternalEve
y, this doesn't seem to
> exist on master)
>
> > XI 2.x event for legacy client support, and that this event should
> > - be ignored if the client listens for these events.
> > + be ignored if the client listens for these events. This flag is
&
hese events. This flag is
> + set on scroll ButtonPress and RawButtonPress events (buttons 4, 5, 6
> + and 7) if a smooth-scrolling event on the Rel Vert Scroll or
> + Rel Horiz Scroll axes was also generated.
Rui
___
xor
2011/8/12 Rui Tiago Cação Matos :
>> PointerEmulated signaps that the event has been emulated from another
> ^^^
> typo (interestingly, this doesn't seem to
> exist on master)
Gah, it's from the previous patch. I shouldn't read my mail
From: Daniel Stone
Two new axes are added to support smooth scrolling: Rel Vert Scroll and
Rel Horiz Scroll. Cumulative values of 1.0 with either magnitude on
these axes are considered to be equivalent to one legacy ButtonPress
event on the scroll buttons.
Signed-off-by: Daniel Stone
Reviewed
(well, the unreviewed ones)
> >
> > Thanks. Do you want everything but smooth-scrolling in my for-peter
> > branch, or pend for later, or?
>
> yes, but on top of master please. not on top of inputproto-2.1-devel. Let's
> see if keith pulls it ;)
I've pushed the followi
hing but v_scroll_axis and h_scroll_axis
> > from the local stack anyway, why not make the while loop a:
> > int emulate_scroll_button_events(events, device, hscroll, vscroll)
>
> Ha, sure.
>
> > Reviewed-by: Peter Hutterer for the lot though
> > (well, the unrev
think we can just put that one in the 'well, don't do that'
> > basket, to be honest.
>
> you can't choose which axes you listen to, you get all of them. with smooth
> scrolling, a 1.x/2.0 client (built before the addition of the scrolling
> labels) would see m
On Thu, Jun 23, 2011 at 10:50:41AM +0100, Daniel Stone wrote:
> Hi,
>
> On Thu, Jun 23, 2011 at 10:44:44AM +1000, Peter Hutterer wrote:
> > On Thu, Jun 09, 2011 at 06:26:01PM +0100, Daniel Stone wrote:
> > > Two new axes are added to support smooth scrolling: Rel Vert Sc
Post smooth-scrolling events through the new X server API when
available, rather than legacy jerky button events.
Signed-off-by: Daniel Stone
---
src/synaptics.c| 54 +--
src/synapticsstr.h | 11 ++
2 files changed, 62 insertions
2 files changed, 52 insertions(+), 85 deletions(-)
v3: Move ScrollData into priv->scroll to fix non-smooth-scrolling with
small-delta packets.
Fixed indentation.
Variables renamed.
Store values normalised to 1.0 per button event, as with old ScrollData,
rather than pixel
'v3' in the subject is new; patches 2, 3, 4, 8, 9,
10, 11, 12, 15, 18, 20, 22, and 23 are still missing review.
#23 is still subject to change as I work out how to implement the
relative-but-values-don't-carry-over axis type that Simon pointed out
during xserver smooth-scrolling rev
Hi,
On Thu, Jun 23, 2011 at 10:44:44AM +1000, Peter Hutterer wrote:
> On Thu, Jun 09, 2011 at 06:26:01PM +0100, Daniel Stone wrote:
> > Two new axes are added to support smooth scrolling: Rel Vert Scroll and
> > Rel Horiz Scroll. Cumulative values of 1.0 with either magnitude on
the while loop a:
> int emulate_scroll_button_events(events, device, hscroll, vscroll)
Ha, sure.
> Reviewed-by: Peter Hutterer for the lot though
> (well, the unreviewed ones)
Thanks. Do you want everything but smooth-scrolling in my for-peter
branch, or pend for
; if (!pDev->enabled)
> @@ -1219,8 +1226,101 @@ GetPointerEvents(InternalEvent *events, DeviceIntPtr
> pDev, int type,
>
> events = UpdateFromMaster(events, pDev, DEVCHANGE_POINTER_EVENT,
>&num_events);
> -num_events += fill
On Thu, Jun 09, 2011 at 06:26:01PM +0100, Daniel Stone wrote:
> Two new axes are added to support smooth scrolling: Rel Vert Scroll and
> Rel Horiz Scroll. Cumulative values of 1.0 with either magnitude on
> these axes are considered to be equivalent to one legacy ButtonPress
>
Hi,
On Mon, Jun 20, 2011 at 04:28:17PM +1000, Peter Hutterer wrote:
> Reviewed-by: Peter Hutterer otherwise though
Thanks for this, I've fixed your comments from both patches, added your
Reviewed-by, and pushed to my p.fd.o smooth-scrolling branch, which is
on top of your inputproto-2
On Thu, Jun 09, 2011 at 06:26:01PM +0100, Daniel Stone wrote:
> Two new axes are added to support smooth scrolling: Rel Vert Scroll and
> Rel Horiz Scroll. Cumulative values of 1.0 with either magnitude on
> these axes are considered to be equivalent to one legacy ButtonPress
>
On Tue, Jun 14, 2011 at 05:35:22PM +0100, Daniel Stone wrote:
> Hi,
>
> On Tue, Jun 14, 2011 at 03:44:44PM +1000, Peter Hutterer wrote:
> > On Thu, Jun 09, 2011 at 08:57:36PM +0100, Daniel Stone wrote:
> > > -#include "synaptics.h"
> > > -#include "synapticsstr.h"
> > > -#include "synaptics-proper
Convert ScrollData from up/down/left/right members for button presses,
to more fine-grained x and y members.
Signed-off-by: Daniel Stone
Reviewed-by: Peter Hutterer
---
src/synaptics.c | 119 ++
1 files changed, 49 insertions(+), 70 deletions
Post smooth-scrolling events through the new X server API when
available, rather than legacy jerky button events.
Signed-off-by: Daniel Stone
---
src/synaptics.c| 54 +--
src/synapticsstr.h | 11 ++
2 files changed, 62 insertions
Hi,
The attached v2 patchset (changed/new patches are marked with 'v2' in
the subject line) should take care of pretty much all the review comments
from Peter & Simon, thanks.
Patches #2, #3, #4, #8, #10, #11, #12, #13, #16, and #21 still need
review.
Cheers,
Daniel
_
Hi,
On Tue, Jun 14, 2011 at 03:44:44PM +1000, Peter Hutterer wrote:
> On Thu, Jun 09, 2011 at 08:57:36PM +0100, Daniel Stone wrote:
> > -#include "synaptics.h"
> > -#include "synapticsstr.h"
> > -#include "synaptics-properties.h"
> > -
> > #if GET_ABI_MAJOR(ABI_XINPUT_VERSION) >= 7
> > #include
le: we
> use hardware time, rather than the time we received the event in the
> SIGIO handler, to estimate motion; we added a better acceleration
> function; we added some strict filters to get rid of erroneous motion
> and make palm detection more reliable, and lastly, we also added smooth
On Thu, Jun 09, 2011 at 08:57:36PM +0100, Daniel Stone wrote:
> Post smooth-scrolling events through the new X server API when
> available, rather than legacy jerky button events.
>
> Signed-off-by: Daniel Stone
> ---
> src/syn
On Thu, Jun 09, 2011 at 08:57:35PM +0100, Daniel Stone wrote:
> Convert ScrollData from up/down/left/right members for button presses,
> to more fine-grained x and y members.
>
> Signed-off-by: Daniel Stone
> ---
Reviewed-by: Peter Hutterer
Cheers,
Peter
> src/synaptics.c | 119 ++
On Fri, Jun 10, 2011 at 03:57:53PM +1000, Peter Hutterer wrote:
> On Thu, Jun 09, 2011 at 04:19:14PM +0100, Daniel Stone wrote:
> > > a bit of a side-issue with this approach is that the scroll events lose
> > > valuator information. we hit that one with the wacom driver where one of
> > > my
> >
On Thu, Jun 09, 2011 at 04:19:14PM +0100, Daniel Stone wrote:
> > a bit of a side-issue with this approach is that the scroll events lose
> > valuator information. we hit that one with the wacom driver where one of my
> > patches started submitting button events with first/num_valuators as 0/0. it
Post smooth-scrolling events through the new X server API when
available, rather than legacy jerky button events.
Signed-off-by: Daniel Stone
---
src/synaptics.c| 58 +--
src/synapticsstr.h | 11 +
2 files changed, 62 insertions
Convert ScrollData from up/down/left/right members for button presses,
to more fine-grained x and y members.
Signed-off-by: Daniel Stone
---
src/synaptics.c | 119 ++
1 files changed, 49 insertions(+), 70 deletions(-)
diff --git a/src/synapti
handler, to estimate motion; we added a better acceleration
function; we added some strict filters to get rid of erroneous motion
and make palm detection more reliable, and lastly, we also added smooth
scrolling support (of course).
The second part is rather more invasive, and I'll follow up wi
Two new axes are added to support smooth scrolling: Rel Vert Scroll and
Rel Horiz Scroll. Cumulative values of 1.0 with either magnitude on
these axes are considered to be equivalent to one legacy ButtonPress
event on the scroll buttons.
Signed-off-by: Daniel Stone
---
specs/XI2proto.txt
&num_events);
-num_events += fill_pointer_events(events, pDev, type, buttons, ms, flags,
- mask_in);
+
+valuator_mask_copy(&mask, mask_in);
+
+/* Turn a scroll button press into a smooth-scrolling event if necessary.
esolve.
>
> There are quite a few patches that could go in right now to give them a few
> months of testing before we merge the new features. Interested in that?
>
> In fact, all except the POINTER_EMULATED patch and the actual integration of
> the smooth scrolling. None of
v_scroll_axis = i;
> > +}
>
> this may be better cached in the DeviceIntRec instead of recalculated on
> every single pointer event.
Done - I was worried about extra DeviceIntRec usage, but eh.
> > +
> > +/* Turn a scroll button press into a smooth-s
On Fri, Jun 03, 2011 at 03:54:58PM +0100, Daniel Stone wrote:
> There's a few patches in this series, destined for 1.12. Most notable
> is the last (but arguably least pleasant) of the series, which adds
> support for smooth scrolling by way of new scroll valuators, which
> emul
+
> +valuator_mask_copy(&mask, mask_in);
> +
> +/* Find the vertical and horizontal scroll axes, if any. */
> +for (i = 0; i < pDev->valuator->numAxes; i++)
> +{
> +if (h_scroll_label && pDev->valuator->axes[i].label ==
> h_scroll_labe
event for legacy client support, and that this event should
> be ignored if the client listens for these events. This flag will
> be set on scroll ButtonPress events (buttons 4, 5, 6 and 7) if a
> smooth-scrolling event on the Rel Vert Scroll or Rel Horiz Scroll
> ax
d round of patches. Here's the applicable text:
PointerEmulated means that the event has been emulated from another
XI 2.x event for legacy client support, and that this event should
be ignored if the client listens for these events. This flag will
be set on scroll ButtonPr
On 06/03/2011 05:00 PM, Daniel Stone wrote:
> For scroll wheel support, we used to send buttons 4/5 and 6/7 for
> horizontal/vertical positive/negative scroll events. For touchpads, we
> really want more fine-grained scroll values. GetPointerEvents now
> accepts both old-school scroll button pres
On Fri, Jun 03, 2011 at 03:54:58PM +0100, Daniel Stone wrote:
> There's a few patches in this series, destined for 1.12. Most notable
> is the last (but arguably least pleasant) of the series, which adds
> support for smooth scrolling by way of new scroll valuators, which
> emul
r->axes[i].label == v_scroll_label)
+v_scroll_axis = i;
+}
+
+/* Turn a scroll button press into a smooth-scrolling event. */
+if (type == ButtonPress &&
+((v_scroll_axis != -1 && (buttons == 4 || buttons == 5)) ||
+ (h_scroll_axis
Hi all,
There's a few patches in this series, destined for 1.12. Most notable
is the last (but arguably least pleasant) of the series, which adds
support for smooth scrolling by way of new scroll valuators, which
emulate button events, and vice-versa for older drivers too.
Along the wa
On 11/17/10 22:26, Max Schwarz wrote:
> I would propose specific methods for changing the resolution, axes ranges,
> etc., and one final call to send out events.
Sounds fine.
Simon
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.
On Wednesday 17 November 2010 at 23:55:20, Simon Thum wrote:
> > if possible, wrap it. it's much easier to work around issues than when
> > each driver just mangles the struct directly. But I don't think you need
> > a new call here, just re-using the existing InitValuatorAxisStruct
> > should do.
On 11/14/10 22:52, Peter Hutterer wrote:
> On Sun, Nov 14, 2010 at 06:51:43PM +0100, Max Schwarz wrote:
Are the drivers "allowed" to access the valuator structure
(e.g. dev->valuator->axis[0].resolution = XY) or should I implement
wrapper functions in the server to do that?
>>>
>>> I
Hi,
I implemented most of the dynamic-resolution feature today.
Patches are at https://github.com/x-quadraht/pscroll/tree/master/patches/ .
The wheel resolution property now resides in the emuWheel.c code, which
reflects that it only affects wheel emulation. I added a manpage entry, too.
Curren
On Sun, Nov 14, 2010 at 06:51:43PM +0100, Max Schwarz wrote:
> Hi Simon,
>
> > > The clients depend on XIDeviceChangedEvents anyway to acquire the new
> > > resolution when the user switches input devices (see pscrolltest.c).
> >
> > Though that sounds fine, I think the event is intended for mast
Hi Simon,
> > The clients depend on XIDeviceChangedEvents anyway to acquire the new
> > resolution when the user switches input devices (see pscrolltest.c).
>
> Though that sounds fine, I think the event is intended for master/slave
> issues. That's deep in spec land, however. Read up and see if
On 11/14/10 00:18, Max Schwarz wrote:
> My proposal would be to make an XINotifyDeviceChanged(DeviceIntPtr dev)
> function available to the drivers. It would simply copy the values from the
> device to a DeviceChangedEvent and send it via XISendDeviceEvent().
> Such a function could also replace
Hi Simon,
> Still, the 42 is a bit odd.
Caught me ;-)
The value was a lucky guess, but it works pretty well for me (I'm using a
TrackPoint to test it, other devices might yield other values...)
> Towels anyone?
No Bugblatter Beast in sight, so I'm safe for now ;-)
> I guess that's mostly Peter
1 - 100 of 134 matches
Mail list logo
