r=3132 <- interesting
Audit=1
Type=x11
Class=user
Active=yes
State=active
IdleHint=no
IdleSinceHint=0
IdleSinceHintMonotonic=0
No idea about reliable way to find the authority file. Parsing the X's command
line would probably work in most cases.
Michal Srb
___
On čtvrtek 7. června 2018 16:15:50 CEST Dennis Clarke wrote:
> Package libtizcore was not found in the pkg-config search path.
> Perhaps you should add the directory containing `libtizcore.pc'
> to the PKG_CONFIG_PATH environment variable
> No package 'libtizcore' found
This is not a problem. It
a
configuration file like this (or appending it to your /etc/X11/xorg.conf file
if you have):
/etc/X11/xorg.conf.d/80-serverflags.conf:
Section "ServerFlags"
Option "AutoAddGPU" "False"
EndSection
Michal Srb
___
xorg@lists
On středa 21. února 2018 12:45:27 CET Sylvain Leroux wrote:
> 1) When is the "$XAUTHORITY" file (re-)read by the server?
>
> According to the Xauth man:
> """
> Note that this program [xauth] does not contact the X server except
> when the generate
On pondělí 26. února 2018 15:21:17 CET Sylvain Leroux wrote:
> Hi Michal,
>
> Thanks to your answer and by studying the /usr/bin/startx script on my
> system, things are much more clear now.
>
> On 02/22/2018 05:16 PM, Michal Srb wrote:
> >> 3) Are Xorg and Xephyr
if there is no external output.
So it would look somehow like this:
...
xrandr |grep $EXTERNAL_OUTPUT | grep " connected "
if [ $? -eq 0 ]; then
xrandr --output $INTERNAL_OUTPUT --off --output $EXTERNAL_OUTPUT --auto
fi
...
Michal Srb
___
x
dvance which display number it will take.
It would be possible to create empty authority file and then fill it after X
started. No idea how willing would they be to accept such change.
Michal Srb
___
xorg@lists.x.org: X.Org support
Archive
On středa 14. listopadu 2018 10:52:59 CET Riccardo Berto wrote:
> I have a low quality screen. It's very bright, even at minimum settings
> in the monitor menu. I'm able to reduce the brightness with `xrandr
> --output HDMI-0 --brightness 0.25` but sometimes the brightness goes
> back to the
On středa 14. listopadu 2018 21:22:28 CET Riccardo Berto wrote:
> Thanks for the answer.
> No, I don't use redshift. As far as I know, it can only happen twice
> during each Xorg start up. After these 2 times and me readjusting the
> backlight manually with the xrandr command previously posted, it
On pátek 16. listopadu 2018 17:25:00 CET Riccardo Berto wrote:
> On 2018-11-15 08:25, Michal Srb wrote:
> > On středa 14. listopadu 2018 21:22:28 CET Riccardo Berto wrote:
> >> Thanks for the answer.
> >> No, I don't use redshift. As far as I know, it can only happen
endianity.
Signed-off-by: Michal Srb m...@suse.com
---
hw/xfree86/dri2/dri2ext.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c
index 73ef7f2..c7749ba 100644
--- a/hw/xfree86/dri2/dri2ext.c
+++ b/hw/xfree86/dri2/dri2ext.c
@@ -592,12 +592,15
Vmmouse driver uses outl calls but never requests hardware access.
In case there are no other drivers that requests it, vmmouse
initialization will fail. (Found on KVM virtual machine with fbdev
graphics driver and vmmouse input driver.)
Request hardware access in same way xf86-input-keyboard
endianity.
Signed-off-by: Michal Srb m...@suse.com
Reviewed-by: Jeremy Huddleston jerem...@apple.com
---
hw/xfree86/dri2/dri2ext.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c
index 73ef7f2..c7749ba 100644
--- a/hw/xfree86/dri2/dri2ext.c
On Tuesday 22 of May 2012 13:41:50 Vincent Torri wrote:
but i would like to know the meaning of the other fields (ENCODING
(but i think that this field is useless for me), SWIDTH, DWIDTH and
BBX). I think that BBX is for the hot point but i don't know how it is
computed from these values.
Hi,
Hi,
In fb/fbblt.c in fbBlt function, memcpy is used to blit inside lines:
if (!upsidedown)
for (i = 0; i height; i++)
MEMCPY_WRAPPED(dst + i * dstStride, src + i * srcStride, width);
else
for (i = height - 1; i = 0; i--)
MEMCPY_WRAPPED(dst + i * dstStride, src + i *
In case of horizontal blitting of less than width of blitted area,
memcpy is used on overlapping areas which is not allowed. The behavior
is undefined in such case, probably leading to graphical artifact when
blitting in specific direction.
---
fb/fb.h| 14 ++
fb/fbblt.c |4
, the function will chain them behind the new one.
Signed-off-by: Michal Srb m...@suse.com
---
Presence of this check caused crashes in Xen. The virtual pointer there has
both relative and absolute axis. InitPtrFeedbackClassDeviceStruct got called
twice, first from EvdevAddRelValuatorClass then from
Checking the iterating variable (slave) against null can not detect if the
xorg_list_for_each_entry finished without break being invoked - slave variable
will be always non-null. This caused segfault whenever someone tried to use
DRI_PRIME with incorrect id while having at least one render
No response? It's simple change and fixes client triggered crash...
On Tuesday April 15 2014 18:54:35 Michal Srb wrote:
Checking the iterating variable (slave) against null can not detect if the
xorg_list_for_each_entry finished without break being invoked - slave
variable will be always non
the
provider is the main screen.
2) Filter out Sink Output capability of the main screen, that way
ProcRRSetProviderOutputSource would also return BadValue and xrandr and other
tools will be aware in advance that the screen can not work as Sink Output.
3) Something else?
Michal Srb
, no? That's why the xrandr resizes the screen first, if
neccessary.
So why is there rrCheckPixmapBounding?
Thank you,
Michal Srb
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org
Return BadValue when the provider is main gpu (instead of aborting on assert
later) and when the sink and source are the same gpu (instead of breaking
and possibly crashing later).
diff --git a/randr/rrprovider.c b/randr/rrprovider.c
index 4507ba8..31af871 100644
--- a/randr/rrprovider.c
+++
Not NoSuchExtension which is 1 = True!
Signed-off-by: Michal Srb m...@suse.com
---
src/XGetCPtr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/XGetCPtr.c b/src/XGetCPtr.c
index a6a44b7..59a27d3 100644
--- a/src/XGetCPtr.c
+++ b/src/XGetCPtr.c
@@ -49,7 +49,7
Several functions were returning NoSuchExtension casted to a pointer in case of
an error. Often in parallel with returning NULL in case of another error. It is
undocumented and certainly wrong.
Signed-off-by: Michal Srb m...@suse.com
---
src/XGMotion.c | 2 +-
src/XGetDCtl.c | 2 +-
src
Replacing the second _XiCheckExtInit with _XiCheckVersion prevents possible
double unlock as _XiCheckExtInit actually unlocks the display when it returns
-1.
Signed-off-by: Michal Srb m...@suse.com
---
src/XIAllowEvents.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Michal Srb m...@suse.com
---
src/XIGrabDevice.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/XIGrabDevice.c b/src/XIGrabDevice.c
index a8c5697..4ba91eb 100644
--- a/src/XIGrabDevice.c
+++ b/src/XIGrabDevice.c
@@ -53,14 +53,21 @@ XIGrabDevice
_XiCheckExtInit unlocks the display if it fails and returns -1. Most callers
account for it properly, but few didn't.
Signed-off-by: Michal Srb m...@suse.com
---
src/XIProperties.c | 3 ++-
src/XIQueryDevice.c | 3 ++-
src/XIQueryVersion.c | 8 ++--
src/XISelEv.c| 7 +--
src
When num_changes = 0 or Xmalloc fails, the display has to be unlocked.
Signed-off-by: Michal Srb m...@suse.com
---
src/XIHierarchy.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/src/XIHierarchy.c b/src/XIHierarchy.c
index 3d2b4f2..441fec0 100644
--- a/src
multiple
unlocks if _XiCheckExtInit fails.
- Remove it and call directly _XiGetExtensionVersionRequest and only call
_XiCheckExtInit only from XGetExtensionVersion.
Signed-off-by: Michal Srb m...@suse.com
---
src/XExtInt.c | 2 +-
src/XGetVers.c | 28 +++-
src/XIint.h| 1
Signed-off-by: Michal Srb m...@suse.com
---
src/XIGrabDevice.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/XIGrabDevice.c b/src/XIGrabDevice.c
index a8c5697..22f4ea1 100644
--- a/src/XIGrabDevice.c
+++ b/src/XIGrabDevice.c
@@ -53,14 +53,20 @@ XIGrabDevice
or was it supposed to be break?
+}
+
+return foundScreen;
+}
Michal Srb
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
with possible solution follows...
Michal Srb
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
If the module was unloaded it can be loaded again and the
setup has to be done again. We can't rely on setupDone being
reinitialized to zero after dlclose and dlopen.
(It's not reinitialized probably because of dlsym being called
on modesettingModuleData which keeps reference counter for the
.)
The gains from speed or memory size are negligible, but it seems like correct
thing to do imho.
Michal Srb (1):
Look for ModuleData only in apropriate library.
hw/xfree86/loader/loader.c |8 +++-
hw/xfree86/loader/loader.h |1 +
hw/xfree86/loader/loadmod.c |2 +-
3 files
Calling dlsym with handle of the module library
instead of RTLD_DEFAULT prevents increasing reference
counter of the library and so allows it to be
really unloaded if UnloadModule is called on it
later.
---
hw/xfree86/loader/loader.c |8 +++-
hw/xfree86/loader/loader.h |1 +
On Wednesday 27 of June 2012 12:52:38 Adam Jackson wrote:
On Wed, 2012-06-27 at 18:04 +0200, Michal Srb wrote:
Calling dlsym with handle of the module library
instead of RTLD_DEFAULT prevents increasing reference
counter of the library and so allows it to be
really unloaded
ModuleData symbol outside
the module's library.
Signed-off-by: Michal Srb m...@suse.com
Reviewed-by: Daniel Stone dan...@fooishbar.org
v2: Switch LoaderSymbolFromModule arguments order.
Correct description.
diff --git a/hw/xfree86/loader/loader.c b/hw/xfree86/loader/loader.c
index b72b8b8
, should be easy to test. But there doesn't seem to be
any proper set of tests covering the current functionality now, so it may be
necessary to create them first.
- skills:
C, some knowledge about fonts, fontconfig rules
Michal Srb
___
xorg-devel
= vfbUninstallColormap;
pScreen-ListInstalledColormaps = vfbListInstalledColormaps;
Any comments to this one?
Tested-By: Michal Srb m...@suse.cz
Michal Srb
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg
From: Lambros Lambrou lambroslamb...@google.com
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=26391
Signed-off-by: Lambros Lambrou lambroslamb...@google.com
Signed-off-by: Mike Frysinger vap...@gentoo.org
Signed-off-by: Michal Srb m...@suse.com
---
Second version, modified according
Xnest variant of ModifyPixmapHeader that creates new Pixmap in parent X
server if it's size is modified from 0x0 to anything bigger.
xnestCreatePixmap doesn't create pixmap in parent X server if it has
dimensions 0x0. If it is later resized and accessed, Xnest will be
aborted with BadDrawable
and RRResourceChangeNotify
events.
RRProviderPropertyNotify seems to be already implemented, however I am not aware
of anything using them to test it.
RROutputChangeNotify and RRCrtcChangeNotify and sent when output or crtc get
changed in output provider screen.
Michal Srb (3):
randr: send RRProviderChangeNotify event
Send RRProviderChangeNotify event when a provider becomes output source or
offload sink.
---
randr/randr.c | 36
randr/randrstr.h | 4
randr/rrprovider.c | 25 +
3 files changed, 65 insertions(+)
mode change 100644 =
Send RRResourceChangeNotify event when provider, output or crtc was created or
destroyed. I.e. when the list of resources returned by RRGetScreenResources and
RRGetProviders changes.
---
hw/xfree86/common/xf86platformBus.c | 5 +
randr/randr.c | 36
Consider all attached output providers when looking for changed outputs and
crtcs.
---
randr/randr.c | 24
1 file changed, 24 insertions(+)
diff --git a/randr/randr.c b/randr/randr.c
index 9cec6f6..3c51427 100755
--- a/randr/randr.c
+++ b/randr/randr.c
@@ -478,6 +478,16
---
randr/rrdispatch.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/randr/rrdispatch.c b/randr/rrdispatch.c
index 7fbc9f0..f050d38 100644
--- a/randr/rrdispatch.c
+++ b/randr/rrdispatch.c
@@ -92,7 +92,9 @@ ProcRRSelectInput(ClientPtr client)
On Tuesday 08 of October 2013 15:11:04 Guillem Jover wrote:
Hi!
On Mon, 2013-10-07 at 13:26:30 +0300, Michal Srb wrote:
[…]
6 files changed, 143 insertions(+)
mode change 100644 = 100755 hw/xfree86/common/xf86platformBus.c
mode change 100644 = 100755 randr/randr.c
mode change
Hi,
Is there any particular reason why GetMaster (include/input.h) doesn't have
_X_EXPORT?
I ran into problem with tigervnc's VNC module that would like to call it, but
can't because it is hidden. That's currently the only thing that prevents
tigervnc from working as module.
GetMaster looks
diff --git a/randr/rrxinerama.c b/randr/rrxinerama.c
index b6e9586..8f499df 100644
--- a/randr/rrxinerama.c
+++ b/randr/rrxinerama.c
@@ -260,6 +260,13 @@ RRXineramaWriteMonitor(ClientPtr client, RRMonitorPtr
monitor)
scratch.width = monitor->geometry.box.x2 - monitor->geometry.box.x1;
xf86pciBus.c:1464:21: warning: comparison of constant 256 with expression of
type 'uint8_t' (aka 'unsigned char') is always true
[-Wtautological-constant-out-of-range-compare]
if (pVideo->bus < 256)
The code used to be in xf86FormatPciBusNumber and compared parameter which was
int, but
On Monday, 27 March 2017 14:08:52 EEST walter harms wrote:
> > -if (pVideo->bus < 256)
> > -snprintf(busnum, sizeof(busnum), "%d", pVideo->bus);
> > -else
> > -snprintf(busnum, sizeof(busnum), "%d@%d",
> > - pVideo->bus & 0x00ff, pVideo->bus >> 8);
> > +
triggering segfault.
# Other requests could be used to crash X server in similar way, for example SetFontPath.
# Author: Michal Srb <m...@suse.com>
# License: MIT
# -- Configure this --
# Display to connect to
display_number = "1"
display_socket = &
On středa 4. října 2017 5:53:15 CEST Damien Miller wrote:
> On Mon, 2 Oct 2017, Michal Srb wrote:
> > SSH only needs to change the first byte sent from X client to server
> > to mark it as remote. SSH already modifies the whole first message
> > (replaces authorization data),
It was missing value for HAL_chipset. All the following values got shifted by
one and so the whole record was garbage.
---
Alternatively HAL_chipset could be dropped from everywhere because it does not
seem to be used.
src/mga_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
asiest would be to probe it. It could just send the initial
request starting with 'r' or 'R' and observe whether X server accepts or
rejects the connection.
Michal Srb
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
e sufficient, I will backport it to
SUSE's X servers.
It would be still nice to solve it systematically by making ssh mark the
connection as remote, but this makes it less critical.
Michal Srb
___
xorg-devel@lists.x.org: X.Org development
Ar
to openssh.
Best regards,
Michal Srb>From 0ab799d99113fd20e918fb2bc740614ce8388dcb Mon Sep 17 00:00:00 2001
From: Michal Srb <m...@suse.com>
Date: Mon, 21 Aug 2017 15:49:38 +0200
Subject: [PATCH] Mark x11 connection as remote.
If we are channeling x11 connection, modify the byte order field
On pondělí 25. září 2017 12:55:47 CEST Eric Anholt wrote:
> Michal Srb <m...@suse.com> writes:
> > I think if you supply valid Drawable and GC, you should get crash even
> > with little endian.
>
> I tried creating a gc against the root window and doing the drawing
>
On neděle 24. září 2017 0:20:07 CEST Eric Anholt wrote:
> Michal Srb <m...@suse.com> writes:
> > Here is a script that can be used to crash X server using a broken big
> > request for PolyLine. It connects to DISPLAY=:1 and doesn't support
> > authentication. Look
n.
PolyLine is not crashing because it has `if (npoint > 1)` test and the
`npoint` (int) overflowed into negative numbers.
If you change the XCB_POLY_LINE into XCB_POLY_RECTANGLE in your test it is
enough to crash X server on my machine.
Michal Srb
___
g:
Subject: [PATCH] os/inputthread: Force unlock when stopping thread.
It did not get a response so far.
Michal Srb
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/l
around my
issue by invoking xauth differently. (I could create 1-item list first
containing the new record and then merge the original list into it, so the new
record will end up on top.)
Michal Srb
___
xorg-devel@lists.x.org: X.Org development
Archi
irst more
general entry and ignore any entries that are never used because of their
position in the list.
I don't have opinion on which is better. Both would work for my usecase.
Michal Srb
___
xorg-devel@lists.x.org: X.Org development
Archi
e wildcard record and replaces it.
Since wildcard entries and entries with no display numbers are valid (see email
"Is xauth entry without display number valid?" on x...@lists.x.org), lets fix
how the merge works and sort the entries from most specific to most generic.
Michal Srb (2):
Merging two lists, or adding entry a into list acts unexpectedly if the list
contains FamilyWild or entry with an empty display numbers. For example:
> xauth list
##6f70656e737573652d74756d626c6577656564#: MIT-MAGIC-COOKIE-1
1500d80327733252cc42ba469138a259
> xauth add test/unix:2
There is no point in adding entry or merging lists if a FamilyWild entry would
end in front of any entry, or entry without display number would end in front
of entry with number.
This sorts all entries in order:
* FamilyWild without display number
* FamilyWild with display number
* Other
The inputthread is kept locked all the time while X server's VT is not active.
If the X server is terminated while not active, it will be stuck forever in
InputThreadFini waiting for the thread to join, but it wouldn't because it is
locked.
---
This fixes the X server termination while its VT is
nfigs for compositing visuals")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104993
Signed-off-by: Michal Srb <m...@suse.com>
---
glx/glxdricommon.c | 63 +-
glx/glxscreens.c | 33 +---
2 files change
On čtvrtek 9. srpna 2018 0:20:01 CEST Erik Kurzinger wrote:
> In practice, this has been causing intermittent KWin crashes when
> used in combination with the proprietary NVIDIA driver such as
> https://bugs.kde.org/show_bug.cgi?id=386370 since when Xlib fails to
> retrieve one of these
To prevent confusion, since user may consider InputDevice as "stronger
selector" and expect that it will take priority over InputClass.
---
Downstream reference:
https://bugzilla.opensuse.org/show_bug.cgi?id=1105311
hw/xfree86/man/xorg.conf.man | 10 +-
1 file changed, 9 insertions(+), 1
The _XimCacheStruct structure is followed in memory by two strings containing
fname and encoding. The memory was accessed using the last member of the
structure `char fname[1]`. That is a lie, prohibits us from using sizeof and
confuses checkers. Lets declare it properly as a flexible array, so
All GPU screens are attached as unbound GPUs to master, even if they have no
capabilities or the provider field is null. Handle that case in RRTellChanged.
---
This prevents crash in setups with for example two qxl devices, or fbdev and
qxl device. I am not sure if it is a proper fix and not just
t looks like it misinterprets
the `list.next` in the macro as dereferencing the `list` variable.
The `nt_list_init(opt, list.next)` macro expands to:
(opt)->list.next = NULL
So wrapping it in the `if (list)` condition is not correct.
Michal Srb
> ---
> dix/inpututils.c | 4 +++-
> 1 file cha
For example: xrandr --output HDMI-1 --scale 0.5 --left-of HDMI-2
Will no create any gap between HDMI-1 and HDMI-2.
---
xrandr.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/xrandr.c b/xrandr.c
index 7f1e867..21e121a 100644
--- a/xrandr.c
+++ b/xrandr.c
@@
If the X server is terminated while its VT is not active, it should
not change the current VT.
---
Changing the VT in that situation serves no purpose and can be confusing.
For example when a user's graphical session is terminated while other
user is using the computer, it would switch the VT he
If the X server is terminated while its VT is not active, it should
not change the current VT.
v2: Query current state in xf86CloseConsole using VT_GETSTATE instead of
keeping track in xf86VTEnter/xf86VTLeave/etc.
---
Changing the VT in that situation serves no purpose and can be confusing.
On pátek 12. října 2018 16:18:11 CEST Adam Jackson wrote:
> On Thu, 2018-10-11 at 16:45 +0200, Michal Srb wrote:
> > If the X server is terminated while its VT is not active, it should
> > not change the current VT.
> > ---
> > Changing the VT in that situatio
The screensaver can regularly move its window to random offsets. It should
use the ConfigureWindow function instead of calling the Screen's MoveWindow
directly. Some MoveWindow implementations, such as compMoveWindow, rely on
Screen's ConfigNotify being called first as it happens in
On úterý 1. ledna 2019 23:05:31 CET Dennis Clarke wrote:
> Dumb question I am sure but as I see at :
>
>https://www.x.org/releases/X11R7.7/doc/man/man3/XCreateGC.3.xhtml
>
> Where it says :
>
> XCreateGC can generate BadAlloc, BadDrawable, BadFont,
> BadMatch,
atch turns the "initialized" flag into "initializedInGeneration"
counter. The key was initialized if it equals current serverGeneration. This
way no explicit clearing is needed.
The dixFreeScreenSpecificPrivates is left empty as it was before 82eb490.
Signed-off-by: Michal
unuseable in CloseScreen. Setting
it after CloseScreen is not possible because some keys may have been
deallocated by CloseScreen.
Instead just search the list and ignore keys that are already there.
The dixFreeScreenSpecificPrivates is left empty as it was before 82eb490.
Signed-off-by: Michal
ialized` flag for screen-specific privates and never
look at it. Instead search the list of already registered keys in
`dixRegisterScreenSpecificPrivateKey` to determine if it was already
registered.
Michal Srb (1):
dix: Ignore initialized flag for screen-specific privates
dix: Track
and vesa drivers both claim
a device (e.g. /dev/fb0 provided by the vesafb kernel driver).
Signed-off-by: Michal Srb
---
hw/xfree86/common/xf86pciBus.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/xfree86/common/xf86pciBus.c b/hw/xfree86/common/xf86pciBus.c
index 0718cdcb0..24396a63c
83 matches
Mail list logo
