On 2015-06-11 Lasse Collin wrote:
> On 2015-05-28 Adam Walling wrote:
> > Everything is updated at https://github.com/adzm/xz_win now
> >
> > You can also grab them directly at http://adzm.net/xz_win/
>
> Thanks! It looks good now. There are still a few unneeded headers
> listed, but those should have no effect on the build itself, so they
> are mostly a cosmetic problem:
>
> tuklib_exit.h
> tuklib_gettext.h
> tuklib_mbstr.h
> tuklib_open_stdxxx.h
> tuklib_progname.h
>
> Getting those cleaned up would be nice but it's not essential. I will
> commit your work next week.
I committed the files as is. Thanks. I added some documentation to
windows/INSTALL-MSVC.txt.
Currently config.h always #defines NDEBUG to disable assertion checks.
This isn't desirable for debug builds though so I think it should be
fixed.
My understanding is that the symbols exported from a DLL should be
marked with __declspec(dllexport) when building the DLL. When built with
MinGW-w64, this is done in src/liblzma/common/common.h by checking if
DLL_EXPORT has been defined by Libtool. Does this work with MSVC as is
or does this need to be fixed?
The API header src/liblzma/api/lzma.h detects MSVC by checking if
_MSC_VER has been defined and avoids using <inttypes.h> because before
MSVC 2013 it didn't exist (I think). Is it OK to replace the line 90
#if defined(_WIN32) && defined(_MSC_VER)
with this?
#if defined(_WIN32) && defined(_MSC_VER) && _MSC_VER < 1800
It doesn't matter when building liblzma itself, but it can matter when
compiling something that uses the liblzma API.
--
Lasse Collin | IRC: Larhzu @ IRCnet & Freenode
