Re: [xz-devel] cmake support?

2020-02-16 Thread Lasse Collin
On 2020-02-16 Christopher Degawa wrote: > > but I don't have much clue how old CMake should be supported. > > > If you don't care about centos 7 using 2.8.12, 3.5 is a good lower > end to start with since that's what ubuntu 16.04 has in their default > repository. Any higher and you might find ll

Re: [xz-devel] cmake support?

2020-02-16 Thread Christopher Degawa
On Sun, Feb 16, 2020 at 4:48 PM Lasse Collin wrote: > > - The lib prefix in the target generated by the add_library command > > is not needed as cmake will automatically prepend lib on appropriate > > targets, if you want to force it to always output as `liblzma` you > > could use > > > https://c

Re: [xz-devel] cmake support?

2020-02-16 Thread Christopher Degawa
> > but I don't have much clue how old CMake should be supported. > If you don't care about centos 7 using 2.8.12, 3.5 is a good lower end to start with since that's what ubuntu 16.04 has in their default repository. Any higher and you might find llvm-dev's discussion of updating the cmake requirem

Re: [xz-devel] cmake support?

2020-02-16 Thread Lasse Collin
On 2020-02-16 Lasse Collin wrote: > I quickly checked a few random things and didn't find anything else > that wouldn't be OK with 3.1. target_link_options needs 3.13. Seems that it can be avoided by using set_target_properties(liblzma PROPERTIES LINK_FLAGS -Wl,--version-script=${CMAKE_CURREN

Re: [xz-devel] cmake support?

2020-02-16 Thread Lasse Collin
On 2020-02-16 Christopher Degawa wrote: > I'm not a xz developer, but more of a user, I hope these can be of > use to you Thanks! I'm sure you have more experience about CMake than I do. :-) > - Although you mark your cmake minimum as 3.1, your project command > contains `DESCRIPTION`, and `HOMPA

Re: [xz-devel] cmake support?

2020-02-16 Thread Christopher Degawa
I'm not a xz developer, but more of a user, I hope these can be of use to you - Although you mark your cmake minimum as 3.1, your project command contains `DESCRIPTION`, and `HOMPAGE_URL`, both of which are not provided in cmake 3.1 https://cmake.org/cmake/help/v3.1/command/project.html I did not

Re: [xz-devel] cmake support?

2020-02-16 Thread Lasse Collin
On 2020-02-15 Mario Emmenlauer wrote: > This has been my foremost reason for cmake. While not everything is > perfect, it has proven to work very well for generating native build > instructions with well defined settings on quite a number of > platforms. CMake can be used like GNU Autotools to mak