Re: [xz-devel] java crc64 implementation

2021-02-02 Thread Brett Okken
I tested jdk 15 64bit and jdk 11 32bit, client and server and the above implementation is consistently quite good. The alternate in running does not do the leading alignment. This version is really close in 64 bit testing and slightly faster for 32 bit. The differences are pretty small, and both ar

Re: [xz-devel] java crc64 implementation

2021-02-02 Thread Brett Okken
I accidentally hit reply instead of reply all. > > Shouldn't that be (i & 3) != 0? > > An offset of 0 should not enter this loop, but 0 & 3 does not equal 1. > > The idea really is that offset of 1 doesn't enter the loop, thus the > main slicing-by-4 loop is misaligned. I don't know why it makes a

Re: [xz-devel] java crc64 implementation

2021-02-02 Thread Lasse Collin
I assume you accidentally didn't post to the list so I'm quoting your email in full. On 2021-02-02 Brett Okken wrote: > > while ((i & 3) != 1 && i < end) > > Shouldn't that be (i & 3) != 0? > An offset of 0 should not enter this loop, but 0 & 3 does not equal 1. The idea really is that offset

Re: [xz-devel] xz-java minor read improvements

2021-02-02 Thread Lasse Collin
On 2021-01-29 Brett Okken wrote: > Here are some small improvements when creating new BlockInputStream > instances. This reduces the size of the byte[] for the block header to > the actual size I committed this part. Thanks! > and replaces use of ByteArrayInputStream, which has synchronized > met

Re: [xz-devel] java crc64 implementation

2021-02-02 Thread Lasse Collin
Hello! I need to make a new release in the near future so that a minor problem can be fixed in .7z support in Apache Commons Compress. I thought I could include simpler and safer changes from your long list of patches and the CRC64 improvement might be such. On 2021-01-21 Brett Okken wrote: > Her