Re: [xz-devel] java LZMA2OutputStream changes

2021-02-05 Thread Lasse Collin
On 2021-02-05 Brett Okken wrote: > > > Now that there is a 6 byte chunkHeader, could the 1 byte tempBuf > > > be removed? > > > > It's better to keep it. It would be confusing to use the same > > buffer in write(int) and writeChunk(). At glance it would look like > > that writeChunk() could be ov

Re: [xz-devel] java LZMA2OutputStream changes

2021-02-05 Thread Brett Okken
> > Now that there is a 6 byte chunkHeader, could the 1 byte tempBuf be > > removed? > > It's better to keep it. It would be confusing to use the same buffer in > write(int) and writeChunk(). At glance it would look like that > writeChunk() could be overwriting the input. I assumed that lz.fillWin

Re: [xz-devel] java LZMA2OutputStream changes

2021-02-05 Thread Lasse Collin
On 2021-02-05 Brett Okken wrote: > After recent changes, the LZMA2OutputStream class no longer uses > DataOutputStream, but the import statement is still present. Fixed. Thanks! > Now that there is a 6 byte chunkHeader, could the 1 byte tempBuf be > removed? It's better to keep it. It would be c

[xz-devel] java LZMA2OutputStream changes

2021-02-05 Thread Brett Okken
After recent changes, the LZMA2OutputStream class no longer uses DataOutputStream, but the import statement is still present. Now that there is a 6 byte chunkHeader, could the 1 byte tempBuf be removed?