Re: [xz-devel] Re: improve java delta performance

2024-02-19 Thread Brett Okken
I have created a pr to the GitHub project with these changes.

https://github.com/tukaani-project/xz-java/pull/11/files

Thanks,
Brett

On Thu, Mar 31, 2022 at 4:33 PM Lasse Collin 
wrote:

> > On Thu, May 6, 2021 at 4:18 PM Brett Okken 
> > wrote:
> >
> > > These changes reduce the time of DeltaEncoder by ~65% and
> > > DeltaDecoder by ~40%, assuming using arrays that are several KB in
> > > size.
>
> On 2022-02-12 Brett Okken wrote:
> > Can this be reviewed?
>
> It looks reasonable but I try to focus on XZ Utils at the moment.
>
> The Delta code in XZ Utils is also very simple and could be optimized
> the same way. But since Delta isn't used alone (it's used together with
> LZMA2) I suspect the overall improvement isn't big. It could still be
> done as it is simple but I won't look at it now.
>
> For the ArrayUtil patch, it's a complex one and I'm not able to look at
> it for now.
>
> --
> Lasse Collin
>


Re: [xz-devel] Re: improve java delta performance

2022-03-31 Thread Lasse Collin
> On Thu, May 6, 2021 at 4:18 PM Brett Okken 
> wrote:
> 
> > These changes reduce the time of DeltaEncoder by ~65% and
> > DeltaDecoder by ~40%, assuming using arrays that are several KB in
> > size. 

On 2022-02-12 Brett Okken wrote:
> Can this be reviewed?

It looks reasonable but I try to focus on XZ Utils at the moment.

The Delta code in XZ Utils is also very simple and could be optimized
the same way. But since Delta isn't used alone (it's used together with
LZMA2) I suspect the overall improvement isn't big. It could still be
done as it is simple but I won't look at it now.

For the ArrayUtil patch, it's a complex one and I'm not able to look at
it for now.

-- 
Lasse Collin