Re: [Y2038] [PATCH] vfs: replace current_kernel_time64 with ktime equivalent

2018-06-25 Thread Dave Chinner
On Fri, Jun 22, 2018 at 03:24:48PM +0200, Arnd Bergmann wrote: > On Thu, Jun 21, 2018 at 10:23 PM, Dave Chinner wrote: > > On Wed, Jun 20, 2018 at 05:01:24PM +0200, Arnd Bergmann wrote: > > >> diff --git a/fs/inode.c b/fs/inode.c > >> index 2c300e981796..e27bd9334939 100644 > >> --- a/fs/inode.c

Re: [Y2038] [PATCH] scsi_transport_fc: use 64-bit timestamps consistently

2018-06-25 Thread James Smart
On 6/18/2018 8:29 AM, Arnd Bergmann wrote: The get_seconds() helper returns an 'unsigned long' value, which can overflow on 32-bit architectures. Since the interface we pass it into already uses a 64-bit type, we can just use ktime_get_real_seconds() instead. While we generally prefer local

Re: [Y2038] [PATCH] scsi_transport_fc: use 64-bit timestamps consistently

2018-06-25 Thread Tyrel Datwyler
On 06/18/2018 08:29 AM, Arnd Bergmann wrote: > The get_seconds() helper returns an 'unsigned long' value, which can > overflow on 32-bit architectures. Since the interface we pass it into > already uses a 64-bit type, we can just use ktime_get_real_seconds() > instead. > > While we generally

Re: [Y2038] [PATCH v2 2/2] rusage: allow 64-bit times ru_utime/ru_stime

2018-06-25 Thread Eric W. Biederman
Ingo Molnar writes: > * Eric W. Biederman wrote: > >> Ingo Molnar writes: >> >> > * Eric W. Biederman wrote: >> > >> >> The trouble with attributes is that means you can't filter your system >> >> call arguments with seccomp. [...] >> > >> > There's nothing keeping seccomp from securely

Re: [Y2038] [PATCH] vfs: replace current_kernel_time64 with ktime equivalent

2018-06-25 Thread Arnd Bergmann
On Wed, Jun 20, 2018 at 9:35 PM, Arnd Bergmann wrote: > On Wed, Jun 20, 2018 at 6:19 PM, Andi Kleen wrote: >> Arnd Bergmann writes: >>> >>> To clarify: current_kernel_time() uses at most millisecond resolution rather >>> than microsecond, as tkr_mono.xtime_nsec only gets updated during the >>>

Re: [Y2038] [PATCH v2 2/2] rusage: allow 64-bit times ru_utime/ru_stime

2018-06-25 Thread Arnd Bergmann
On Fri, Jun 22, 2018 at 7:45 PM, Eric W. Biederman wrote: > Ingo Molnar writes: > > So I suspect the simplest thing to do would be to set a flag in the > idtype member of waitid that says give me rusage64 and then we would > be done. It would have to be a flag in both the 'idtype' field of

Re: [Y2038] [PATCH] scsi: lpfc: use monotonic timestamps for statistics

2018-06-25 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [Y2038] [PATCH] scsi_transport_fc: use 64-bit timestamps consistently

2018-06-25 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG