Re: [Y2038] [PATCH 2/3] xfs: disallow broken ioctls without compat-32-bit-time

2019-12-24 Thread Christoph Hellwig
On Wed, Dec 18, 2019 at 05:39:29PM +0100, Arnd Bergmann wrote: > +/* disallow y2038-unsafe ioctls with CONFIG_COMPAT_32BIT_TIME=n */ > +static bool xfs_have_compat_bstat_time32(unsigned int cmd) > +{ > + if (IS_ENABLED(CONFIG_COMPAT_32BIT_TIME)) > + return true; > + > + if

Re: [Y2038] [PATCH 1/3] xfs: rename compat_time_t to old_time32_t

2019-12-24 Thread Christoph Hellwig
On Wed, Dec 18, 2019 at 05:39:28PM +0100, Arnd Bergmann wrote: > The compat_time_t type has been removed everywhere else, > as most users rely on old_time32_t for both native and > compat mode handling of 32-bit time_t. > > Remove the last one in xfs. > > Reviewed-by: Darrick J. Wong >