Re: [Y2038] [PATCH 2/3] xfs: disallow broken ioctls without compat-32-bit-time

2020-01-07 Thread Darrick J. Wong
On Tue, Jan 07, 2020 at 06:16:34AM -0800, Christoph Hellwig wrote: > On Thu, Jan 02, 2020 at 10:07:49AM -0800, Darrick J. Wong wrote: > > > Sorry I missed that comment earlier. I've had a fresh look now, but > > > I think we still need to deprecate XFS_IOC_SWAPEXT and a

Re: [Y2038] [PATCH v3 2/2] xfs: quota: move to time64_t interfaces

2020-01-02 Thread Darrick J. Wong
t;) which needs > to be rebased on top of this. > > All other changes to remove time_t and get_seconds() > are now in linux-next, this is one of the last patches > needed to remove their definitions for v5.6. > > If the widened timestamps make it into v5.6, this patch > can

Re: [Y2038] [PATCH 2/3] xfs: disallow broken ioctls without compat-32-bit-time

2020-01-02 Thread Darrick J. Wong
On Thu, Jan 02, 2020 at 10:16:21AM +0100, Arnd Bergmann wrote: > On Tue, Dec 24, 2019 at 9:45 AM Christoph Hellwig wrote: > > On Wed, Dec 18, 2019 at 05:39:29PM +0100, Arnd Bergmann wrote: > > > +/* disallow y2038-unsafe ioctls with CONFIG_COMPAT_32BIT_TIME=n */ > > > +static bool

Re: [Y2038] [PATCH v2 21/24] xfs: quota: move to time64_t interfaces

2019-12-17 Thread Darrick J. Wong
On Tue, Dec 17, 2019 at 04:02:47PM +0100, Arnd Bergmann wrote: > On Mon, Dec 16, 2019 at 5:52 PM Arnd Bergmann wrote: > > On Fri, Dec 13, 2019 at 10:17 PM Darrick J. Wong > > wrote: > >> > >> Hmm, so one thing that I clean up on the way to bigtime is the

Re: [Y2038] [PATCH v2 20/24] xfs: disallow broken ioctls without compat-32-bit-time

2019-12-16 Thread Darrick J. Wong
On Mon, Dec 16, 2019 at 05:45:29PM +0100, Arnd Bergmann wrote: > On Fri, Dec 13, 2019 at 10:05 PM Darrick J. Wong > wrote: > > > > On Fri, Dec 13, 2019 at 09:53:48PM +0100, Arnd Bergmann wrote: > > > When building a kernel that disables support for 32-bit time_t > &

Re: [Y2038] [PATCH v2 19/24] xfs: rename compat_time_t to old_time32_t

2019-12-13 Thread Darrick J. Wong
Arnd Bergmann Looks fine to me, assuming that compat_time_t -> old_time32_t. Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_ioctl32.c | 2 +- > fs/xfs/xfs_ioctl32.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/xfs/xfs_ioctl32.c b

Re: [Y2038] [PATCH v2 21/24] xfs: quota: move to time64_t interfaces

2019-12-13 Thread Darrick J. Wong
elimit is set to 1 year, this will cause an integer overflow. The quota timer will be set to 1970 and expire immediately, rather than what I'd consider the best effort of February 2106. (I'll grant you the current code also behaves like this...) Reviewed-by: Darrick J. Wong --D >

Re: [Y2038] [PATCH v2 20/24] xfs: disallow broken ioctls without compat-32-bit-time

2019-12-13 Thread Darrick J. Wong
On Fri, Dec 13, 2019 at 09:53:48PM +0100, Arnd Bergmann wrote: > When building a kernel that disables support for 32-bit time_t > system calls, it also makes sense to disable the old xfs_bstat > ioctls completely, as they truncate the timestamps to 32-bit > values. Note that current xfs doesn't

Re: [Y2038] [RFC 1/5] xfs: [variant A] avoid time_t in user api

2019-11-13 Thread Darrick J. Wong
On Wed, Nov 13, 2019 at 02:42:24PM +0100, Arnd Bergmann wrote: > On Wed, Nov 13, 2019 at 6:08 AM Darrick J. Wong > wrote: > > On Tue, Nov 12, 2019 at 03:16:00PM +0100, Christoph Hellwig wrote: > > > On Tue, Nov 12, 2019 at 01:09:06PM +0100, Arnd Bergmann wrote: > >

Re: [Y2038] [RFC 1/5] xfs: [variant A] avoid time_t in user api

2019-11-12 Thread Darrick J. Wong
gt; 64-bit timestamps to 32-bit user space. > > As said above their are not entirely true, but I still think this patch > is the right thing to do, if only to get the time_t out of the ABI.. > > Reviewed-by: Christoph Hellwig Seconded, Reviewed-by: Darrick J. Wong --D ___ Y2038 mailing list Y2038@lists.linaro.org https://lists.linaro.org/mailman/listinfo/y2038

Re: [Y2038] [PATCH 06/20] fs: Fill in max and min timestamps in superblock

2019-07-31 Thread Darrick J. Wong
t; + sb->s_time_gran = NSEC_PER_SEC; > + sb->s_time_min = S32_MIN; > + sb->s_time_max = S32_MAX; > + > switch (sbi->s_mount_opt & UFS_MOUNT_UFSTYPE) { > case UFS_MOUNT_UFSTYPE_44BSD: > UFSD("ufsty

Re: [Y2038] [PATCH 09/20] ext4: Initialize timestamps limits

2019-07-31 Thread Darrick J. Wong
On Mon, Jul 29, 2019 at 06:49:13PM -0700, Deepa Dinamani wrote: > ext4 has different overflow limits for max filesystem > timestamps based on the extra bytes available. > > The timestamp limits are calculated according to the > encoding table in > a4dad1ae24f85i(ext4: Fix handling of extended

Re: [Y2038] [PATCH 05/20] utimes: Clamp the timestamps before update

2019-07-31 Thread Darrick J. Wong
On Mon, Jul 29, 2019 at 06:49:09PM -0700, Deepa Dinamani wrote: > POSIX is ambiguous on the behavior of timestamps for > futimens, utimensat and utimes. Whether to return an > error or silently clamp a timestamp beyond the range > supported by the underlying filesystems is not clear. > > POSIX.1

Re: [Y2038] [RFC 0/6] vfs: Add timestamp range check support

2016-11-03 Thread Darrick J. Wong
On Thu, Nov 03, 2016 at 09:48:27AM +1100, Dave Chinner wrote: > On Wed, Nov 02, 2016 at 08:04:50AM -0700, Deepa Dinamani wrote: > > The series is aimed at adding timestamp checking and policy > > related to it to vfs. > > > > The series was developed with discussions and guidance from > > Arnd