Re: [Y2038] [PATCH] security: keys: convert uses of time_t to time64_t

2015-11-28 Thread Aya Mahfouz
On Fri, Nov 27, 2015 at 09:35:22PM +0100, Arnd Bergmann wrote: > On Friday 27 November 2015 18:55:43 Aya Mahfouz wrote: > > > > > > My first idea would be to split the key_preparsed_payload changes from > > > the struct key changes. Have you tried that? What problems did you run > > > into? > > >

Re: [Y2038] [PATCH] security: keys: convert uses of time_t to time64_t

2015-11-27 Thread Arnd Bergmann
On Friday 27 November 2015 18:55:43 Aya Mahfouz wrote: > > > > My first idea would be to split the key_preparsed_payload changes from > > the struct key changes. Have you tried that? What problems did you run into? > > > Yes, the problem is that the assignments to key->expiry come from > key_prep

Re: [Y2038] [PATCH] security: keys: convert uses of time_t to time64_t

2015-11-27 Thread Aya Mahfouz
On Fri, Nov 27, 2015 at 04:22:24PM +0100, Arnd Bergmann wrote: > On Friday 27 November 2015 16:42:54 Aya Mahfouz wrote: > > On Wed, Nov 18, 2015 at 04:35:58PM +0100, Arnd Bergmann wrote: > > > On Wednesday 18 November 2015 17:33:38 Aya Mahfouz wrote: > > > > > > --- > > > > > > Changelog: > > > > >

Re: [Y2038] [PATCH] security: keys: convert uses of time_t to time64_t

2015-11-27 Thread Arnd Bergmann
On Friday 27 November 2015 16:42:54 Aya Mahfouz wrote: > On Wed, Nov 18, 2015 at 04:35:58PM +0100, Arnd Bergmann wrote: > > On Wednesday 18 November 2015 17:33:38 Aya Mahfouz wrote: > > > > > --- > > > > > Changelog: > > > > > v1: The changes were originally made by Arnd Bergmann in > > > > > relat

Re: [Y2038] [PATCH] security: keys: convert uses of time_t to time64_t

2015-11-27 Thread Aya Mahfouz
On Wed, Nov 18, 2015 at 04:35:58PM +0100, Arnd Bergmann wrote: > On Wednesday 18 November 2015 17:33:38 Aya Mahfouz wrote: > > > > --- > > > > Changelog: > > > > v1: The changes were originally made by Arnd Bergmann in > > > > relation to time_t. I've broken down a patch sent to me > > > > into tw

Re: [Y2038] [PATCH] security: keys: convert uses of time_t to time64_t

2015-11-18 Thread Arnd Bergmann
On Wednesday 18 November 2015 17:33:38 Aya Mahfouz wrote: > > > --- > > > Changelog: > > > v1: The changes were originally made by Arnd Bergmann in > > > relation to time_t. I've broken down a patch sent to me > > > into two independent patches. > > > > I suppose you have tried and failed to spli

Re: [Y2038] [PATCH] security: keys: convert uses of time_t to time64_t

2015-11-18 Thread Aya Mahfouz
On Wed, Nov 18, 2015 at 03:10:30PM +0100, Arnd Bergmann wrote: > On Tuesday 17 November 2015 23:20:28 Aya Mahfouz wrote: > > Changes all the uses of time_t for the structs key > > and key_preparsed_payload to time64_t. This also > > involves the functions that use them in security/keys. > > This is

Re: [Y2038] [PATCH] security: keys: convert uses of time_t to time64_t

2015-11-18 Thread Arnd Bergmann
On Tuesday 17 November 2015 23:20:28 Aya Mahfouz wrote: > Changes all the uses of time_t for the structs key > and key_preparsed_payload to time64_t. This also > involves the functions that use them in security/keys. > This is to handle the y2038 problem where time_t will > overflow in 2038. > > A

[Y2038] [PATCH] security: keys: convert uses of time_t to time64_t

2015-11-17 Thread Aya Mahfouz
Changes all the uses of time_t for the structs key and key_preparsed_payload to time64_t. This also involves the functions that use them in security/keys. This is to handle the y2038 problem where time_t will overflow in 2038. Also since time_t was a long int and time64_t is long long, uses of LON