On Sun, Nov 24, 2019 at 1:34 PM Al Viro wrote:
>
> On Sun, Nov 24, 2019 at 01:13:50PM -0800, Deepa Dinamani wrote:
>
> > We also want to replace all uses of timespec64_trunc() with
> > timestamp_truncate() for all fs cases.
> >
> > In that case we have a few more:
> >
> > fs/ceph/mds_client.c:
On Mon, Nov 25, 2019 at 8:46 AM J . Bruce Fields wrote:
>
> On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote:
> > Push clamping timestamps down the call stack into notify_change(), so
> > in-kernel callers like nfsd and overlayfs will get similar timestamp
> > set behavior as
On Mon, Nov 25, 2019 at 6:46 PM J . Bruce Fields wrote:
>
> On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote:
> > Push clamping timestamps down the call stack into notify_change(), so
> > in-kernel callers like nfsd and overlayfs will get similar timestamp
> > set behavior as
On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote:
> Push clamping timestamps down the call stack into notify_change(), so
> in-kernel callers like nfsd and overlayfs will get similar timestamp
> set behavior as utimes.
So, nfsd has always bypassed timestamp_truncate() and we've
On Sun, Nov 24, 2019 at 01:13:50PM -0800, Deepa Dinamani wrote:
> We also want to replace all uses of timespec64_trunc() with
> timestamp_truncate() for all fs cases.
>
> In that case we have a few more:
>
> fs/ceph/mds_client.c: req->r_stamp = timespec64_trunc(ts,
>
On Sun, Nov 24, 2019 at 12:50 PM Amir Goldstein wrote:
>
> On Sun, Nov 24, 2019 at 9:49 PM Al Viro wrote:
> >
> > On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote:
> > > Push clamping timestamps down the call stack into notify_change(), so
> > > in-kernel callers like nfsd and
On Sun, Nov 24, 2019 at 11:49 AM Al Viro wrote:
>
> On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote:
> > Push clamping timestamps down the call stack into notify_change(), so
> > in-kernel callers like nfsd and overlayfs will get similar timestamp
> > set behavior as utimes.
>
>
On Sun, Nov 24, 2019 at 9:49 PM Al Viro wrote:
>
> On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote:
> > Push clamping timestamps down the call stack into notify_change(), so
> > in-kernel callers like nfsd and overlayfs will get similar timestamp
> > set behavior as utimes.
>
>
On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote:
> Push clamping timestamps down the call stack into notify_change(), so
> in-kernel callers like nfsd and overlayfs will get similar timestamp
> set behavior as utimes.
Makes sense; said that, shouldn't we go through ->setattr()
Push clamping timestamps down the call stack into notify_change(), so
in-kernel callers like nfsd and overlayfs will get similar timestamp
set behavior as utimes.
Suggested-by: Miklos Szeredi
Fixes: 42e729b9ddbb ("utimes: Clamp the timestamps before update")
Cc: sta...@vger.kernel.org # v5.4
Cc:
10 matches
Mail list logo