Re: [Y2038] [PATCH] utimes: Clamp the timestamps in notify_change()

2019-11-29 Thread Deepa Dinamani
On Sun, Nov 24, 2019 at 1:34 PM Al Viro wrote: > > On Sun, Nov 24, 2019 at 01:13:50PM -0800, Deepa Dinamani wrote: > > > We also want to replace all uses of timespec64_trunc() with > > timestamp_truncate() for all fs cases. > > > > In that case we have a few more: > > > > fs/ceph/mds_client.c:

Re: [Y2038] [PATCH] utimes: Clamp the timestamps in notify_change()

2019-11-25 Thread Deepa Dinamani
On Mon, Nov 25, 2019 at 8:46 AM J . Bruce Fields wrote: > > On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote: > > Push clamping timestamps down the call stack into notify_change(), so > > in-kernel callers like nfsd and overlayfs will get similar timestamp > > set behavior as

Re: [Y2038] [PATCH] utimes: Clamp the timestamps in notify_change()

2019-11-25 Thread Amir Goldstein
On Mon, Nov 25, 2019 at 6:46 PM J . Bruce Fields wrote: > > On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote: > > Push clamping timestamps down the call stack into notify_change(), so > > in-kernel callers like nfsd and overlayfs will get similar timestamp > > set behavior as

Re: [Y2038] [PATCH] utimes: Clamp the timestamps in notify_change()

2019-11-25 Thread J . Bruce Fields
On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote: > Push clamping timestamps down the call stack into notify_change(), so > in-kernel callers like nfsd and overlayfs will get similar timestamp > set behavior as utimes. So, nfsd has always bypassed timestamp_truncate() and we've

Re: [Y2038] [PATCH] utimes: Clamp the timestamps in notify_change()

2019-11-24 Thread Al Viro
On Sun, Nov 24, 2019 at 01:13:50PM -0800, Deepa Dinamani wrote: > We also want to replace all uses of timespec64_trunc() with > timestamp_truncate() for all fs cases. > > In that case we have a few more: > > fs/ceph/mds_client.c: req->r_stamp = timespec64_trunc(ts, >

Re: [Y2038] [PATCH] utimes: Clamp the timestamps in notify_change()

2019-11-24 Thread Deepa Dinamani
On Sun, Nov 24, 2019 at 12:50 PM Amir Goldstein wrote: > > On Sun, Nov 24, 2019 at 9:49 PM Al Viro wrote: > > > > On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote: > > > Push clamping timestamps down the call stack into notify_change(), so > > > in-kernel callers like nfsd and

Re: [Y2038] [PATCH] utimes: Clamp the timestamps in notify_change()

2019-11-24 Thread Deepa Dinamani
On Sun, Nov 24, 2019 at 11:49 AM Al Viro wrote: > > On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote: > > Push clamping timestamps down the call stack into notify_change(), so > > in-kernel callers like nfsd and overlayfs will get similar timestamp > > set behavior as utimes. > >

Re: [Y2038] [PATCH] utimes: Clamp the timestamps in notify_change()

2019-11-24 Thread Amir Goldstein
On Sun, Nov 24, 2019 at 9:49 PM Al Viro wrote: > > On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote: > > Push clamping timestamps down the call stack into notify_change(), so > > in-kernel callers like nfsd and overlayfs will get similar timestamp > > set behavior as utimes. > >

Re: [Y2038] [PATCH] utimes: Clamp the timestamps in notify_change()

2019-11-24 Thread Al Viro
On Sun, Nov 24, 2019 at 09:31:45PM +0200, Amir Goldstein wrote: > Push clamping timestamps down the call stack into notify_change(), so > in-kernel callers like nfsd and overlayfs will get similar timestamp > set behavior as utimes. Makes sense; said that, shouldn't we go through ->setattr()

[Y2038] [PATCH] utimes: Clamp the timestamps in notify_change()

2019-11-24 Thread Amir Goldstein
Push clamping timestamps down the call stack into notify_change(), so in-kernel callers like nfsd and overlayfs will get similar timestamp set behavior as utimes. Suggested-by: Miklos Szeredi Fixes: 42e729b9ddbb ("utimes: Clamp the timestamps before update") Cc: sta...@vger.kernel.org # v5.4 Cc: