Re: [Y2038] [PATCH] blktrace: avoid using timespec

2016-06-20 Thread Arnd Bergmann
On Monday, June 20, 2016 10:59:14 AM CEST Jeff Moyer wrote: > Arnd Bergmann writes: > > > On Friday, June 17, 2016 5:54:16 PM CEST Jeff Moyer wrote: > >> Jens Axboe writes: > >> > >> > On 06/17/2016 05:36 PM, Steven Rostedt wrote: > >> >> > >> >> Jens, > >> >> >

Re: [Y2038] [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

2016-06-20 Thread Arnd Bergmann
On Monday, June 20, 2016 3:54:06 PM CEST Bart Van Assche wrote: > On 06/17/2016 05:47 PM, Arnd Bergmann wrote: > > - jiffies_to_timespec(jiffies, ); > > - jiffies_to_timespec(lport->boot_time, ); > > - fc_stats->seconds_since_last_reset = (v0.tv_sec - v1.tv_sec); > > +

Re: [Y2038] [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

2016-06-20 Thread Bart Van Assche
On 06/20/2016 04:48 PM, Arnd Bergmann wrote: On Monday, June 20, 2016 3:54:06 PM CEST Bart Van Assche wrote: On 06/17/2016 05:47 PM, Arnd Bergmann wrote: - jiffies_to_timespec(jiffies, ); - jiffies_to_timespec(lport->boot_time, ); - fc_stats->seconds_since_last_reset = (v0.tv_sec -

Re: [Y2038] [PATCH] blktrace: avoid using timespec

2016-06-20 Thread Jeff Moyer
Arnd Bergmann writes: > On Friday, June 17, 2016 5:54:16 PM CEST Jeff Moyer wrote: >> Jens Axboe writes: >> >> > On 06/17/2016 05:36 PM, Steven Rostedt wrote: >> >> >> >> Jens, >> >> >> >> You want to take this, or do you want me to? >> > >> > I'll add it to my

Re: [Y2038] [PATCH] blktrace: avoid using timespec

2016-06-20 Thread Arnd Bergmann
On Monday, June 20, 2016 3:37:10 PM CEST Jeff Moyer wrote: > > > Ok. Thanks a lot for the information. I think we can update the > > comment as in the incremental patch below. Jens, can you fold that > > into the original patch, or should I submit this as a new (or > > incremental) patch with an

[Y2038] [PATCH] blktrace: reword comment about time overflow

2016-06-20 Thread Arnd Bergmann
Jeff Moyer looked up the blktrace source to see if an overflow might happen. The situation is as follows: - The time stamp is not used by the program itself, only for printing human-readable output. - We normally don't print the timestamp at all, except when an undocumented format option is

Re: [Y2038] [PATCH] blktrace: reword comment about time overflow

2016-06-20 Thread Jeff Moyer
Arnd Bergmann writes: > Jeff Moyer looked up the blktrace source to see if an overflow might > happen. The situation is as follows: > > - The time stamp is not used by the program itself, only for > printing human-readable output. > - We normally don't print the timestamp at

Re: [Y2038] [PATCH v2 08/24] fs: btrfs: Use ktime_get_real_ts for root ctime

2016-06-20 Thread David Sterba
On Sun, Jun 19, 2016 at 05:27:07PM -0700, Deepa Dinamani wrote: > btrfs_root_item maintains the ctime for root updates. > This is not part of vfs_inode. > > Since current_time() uses struct inode* as an argument > as Linus suggested, this cannot be used to update root > times unless, we modify

Re: [Y2038] [PATCH] blktrace: avoid using timespec

2016-06-20 Thread Jeff Moyer
Arnd Bergmann writes: > On Monday, June 20, 2016 10:59:14 AM CEST Jeff Moyer wrote: >> struct timespec abs_start_time; [snip] > I assume that abs_start_time is a timespec, implying that It is. You didn't have to assume that, though, as I also included its definition

Re: [Y2038] [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

2016-06-20 Thread Martin K. Petersen
> "Arnd" == Arnd Bergmann writes: Arnd> The fc_get_host_stats() function contains a complex conversion Arnd> from jiffies to timespec to seconds. As we try to get rid of uses Arnd> of struct timespec, we can clean this up and replace it with a Arnd> simpler computation. Arnd>