Re: [Y2038] [Outreachy kernel] Re: [PATCH] staging: ft1000: replace timeval with ktime_t

2015-10-16 Thread Arnd Bergmann
On Saturday 17 October 2015 00:57:45 Arnd Bergmann wrote: > A more likely cleanup would be the removal of the debug interface, > replacing it with something completely different. A little more research shows that we can probably remove the driver from the kernel really soon, as the only

Re: [Y2038] [Outreachy kernel] Re: [PATCH] staging: ft1000: replace timeval with ktime_t

2015-10-16 Thread Deepa Dinamani
Should I then fix this patch as per your suggestion or let it be? -Deepa > On Oct 16, 2015, at 4:30 PM, Arnd Bergmann wrote: > >> On Saturday 17 October 2015 00:57:45 Arnd Bergmann wrote: >> >> A more likely cleanup would be the removal of the debug interface, >> replacing it

Re: [Y2038] [Outreachy kernel] Re: [PATCH] staging: ft1000: replace timeval with ktime_t

2015-10-16 Thread Arnd Bergmann
On Friday 16 October 2015 15:53:04 Deepa Dinamani wrote: > Forgot to do reply-all earlier. > > Resending. > > I considered using the ktime_get_seconds() earlier. > However, I'm not convinced that the driver actually needs time in seconds. > It would be hard to guess given that I'm not actually

Re: [Y2038] [PATCH] staging: ft1000: replace timeval with ktime_t

2015-10-16 Thread Arnd Bergmann
On Wednesday 14 October 2015 17:43:00 Deepa Dinamani wrote: > Replace use of struct timeval with ktime_t to calculate connection > duration. This avoids y2038 issues. Use ktime_get monotonic clock > instead of gettimeofday realtime clock to guard against negative > durations. Fix pr_debug to use

Re: [Y2038] [Outreachy kernel] Re: [PATCH] staging: ft1000: replace timeval with ktime_t

2015-10-16 Thread Greg KH
On Fri, Oct 16, 2015 at 05:32:25PM -0700, Deepa Dinamani wrote: > Should I then fix this patch as per your suggestion or let it be? Let's just delete the driver from the tree. thanks, greg k-h ___ Y2038 mailing list Y2038@lists.linaro.org