Re: [Y2038] [PATCH v2 09/24] fs: udf: Replace CURRENT_TIME with current_time()

2016-06-22 Thread Deepa Dinamani
On Wed, Jun 22, 2016 at 6:54 AM, Arnd Bergmann wrote: > On Sunday, June 19, 2016 5:27:08 PM CEST Deepa Dinamani wrote: >> mutex_lock(>s_alloc_mutex); >> lvidiu->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX; >> lvidiu->impIdent.identSuffix[1] =

Re: [Y2038] [PATCH v2 19/24] fnic: Use time64_t to represent trace timestamps

2016-06-22 Thread Deepa Dinamani
On Wed, Jun 22, 2016 at 7:09 AM, Arnd Bergmann wrote: > On Sunday, June 19, 2016 5:27:18 PM CEST Deepa Dinamani wrote: >> trace timestamps use struct timespec and CURRENT_TIME which >> are not y2038 safe. >> These timestamps are only part of the trace log on the machine >> and are

Re: [Y2038] Fourth draft of the Y2038 design document

2016-06-22 Thread Joseph Myers
On Wed, 22 Jun 2016, Arnd Bergmann wrote: > We can avoid most of the problems if building with _TIME_BITS=64 > has no effect unless both glibc and the kernel headers are new > enough to provide the definitions for 64-bit time_t. That way > we can at least ensure that calling an ioctl command or

Re: [Y2038] [PATCH v2] crypto: Jitter RNG - use ktime_get_ns as fallback

2016-06-22 Thread Arnd Bergmann
On Wednesday, June 22, 2016 7:26:06 PM CEST Stephan Mueller wrote: > As part of the Y2038 development, __getnstimeofday is not supposed to be > used any more. It is now replaced with ktime_get_ns. The Jitter RNG uses > the time stamp to measure the execution time of a given code path and > tries

Re: [Y2038] Fourth draft of the Y2038 design document

2016-06-22 Thread Arnd Bergmann
On Wednesday, June 22, 2016 2:30:10 PM CEST Joseph Myers wrote: > On Wed, 22 Jun 2016, Arnd Bergmann wrote: > > > Regarding the "Support for non-Y2038-safe kernels" section, I'm not > > sure if that can work at all: A kernel that does not have the appropriate > > system calls will also not have

[Y2038] [PATCH v2] crypto: Jitter RNG - use ktime_get_ns as fallback

2016-06-22 Thread Stephan Mueller
Hi John, Herbert, Changes v2: use ktime_get_ns instead of ktime_get_raw_ns The testing was re-performed and indicate no difference to the previous testing. Ciao Stephan ---8<--- As part of the Y2038 development, __getnstimeofday is not supposed to be used any more. It is now replaced with

Re: [Y2038] [PATCH v2 23/24] time: Delete CURRENT_TIME_SEC and CURRENT_TIME macro

2016-06-22 Thread Arnd Bergmann
On Sunday, June 19, 2016 5:27:22 PM CEST Deepa Dinamani wrote: > All uses of these macros have been replaced by other > time functions. > These macros are also not y2038 safe. > And, all its use cases can be fulfilled by y2038 > safe ktime_get_* variants. > > Signed-off-by: Deepa Dinamani

Re: [Y2038] Fourth draft of the Y2038 design document

2016-06-22 Thread Joseph Myers
On Wed, 22 Jun 2016, Arnd Bergmann wrote: > Regarding the "Support for non-Y2038-safe kernels" section, I'm not > sure if that can work at all: A kernel that does not have the appropriate > system calls will also not have the handlers for a lot of the ioctl > commands and possibly other

Re: [Y2038] [PATCH v2 19/24] fnic: Use time64_t to represent trace timestamps

2016-06-22 Thread Arnd Bergmann
On Sunday, June 19, 2016 5:27:18 PM CEST Deepa Dinamani wrote: > trace timestamps use struct timespec and CURRENT_TIME which > are not y2038 safe. > These timestamps are only part of the trace log on the machine > and are not shared with the fnic. > Replace then with y2038 safe struct timespec64

Re: [Y2038] [PATCH v2 09/24] fs: udf: Replace CURRENT_TIME with current_time()

2016-06-22 Thread Arnd Bergmann
On Sunday, June 19, 2016 5:27:08 PM CEST Deepa Dinamani wrote: > mutex_lock(>s_alloc_mutex); > lvidiu->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX; > lvidiu->impIdent.identSuffix[1] = UDF_OS_ID_LINUX; > + ktime_get_real_ts(); >

Re: [Y2038] [PATCH v2 07/24] fs: ubifs: Replace CURRENT_TIME_SEC with current_time

2016-06-22 Thread Arnd Bergmann
On Sunday, June 19, 2016 5:27:06 PM CEST Deepa Dinamani wrote: > @@ -84,6 +84,8 @@ static int create_default_filesystem(struct ubifs_info *c) > int min_leb_cnt = UBIFS_MIN_LEB_CNT; > long long tmp64, main_bytes; > __le64 tmp_le64; > + __le32 tmp_le32; > + struct

Re: [Y2038] [PATCH v2 06/24] fs: ext4: Use current_time() for inode timestamps

2016-06-22 Thread Arnd Bergmann
On Sunday, June 19, 2016 5:27:05 PM CEST Deepa Dinamani wrote: > @@ -3727,6 +3727,7 @@ static int ext4_cross_rename(struct inode *old_dir, > struct dentry *old_dentry, > }; > u8 new_file_type; > int retval; > + struct timespec ctime; > > if

Re: [Y2038] Fourth draft of the Y2038 design document

2016-06-22 Thread Arnd Bergmann
On Wednesday, June 22, 2016 12:58:38 AM CEST Albert ARIBAUD wrote: > Hi all, > > I have produced a fourth draft of what will eventually become the Y2038 > design document: > > https://sourceware.org/glibc/wiki/Y2038ProofnessDesign?rev=83 > > Relative to the previous draft: > > * the scope