Hi Janek, I think we are on the same line more or less. We only differ on
practical details, mainly the notion of merge request in gitlab.
On Sat, 5 Jan 2019 at 00:15, Janek Kozicki wrote:
>
> I just noticed that with my CGAL 4.13 attempt to fix I did a push to
> master. Which felt uneasy.
>
Thanks for raising this major issue. It would be great to populate unit
tests indeed.
I recently [1] introduced a regression test for the utils module and I
would like to advertise it here. It is testing only one function from utils
currently.
It needs volunteers to expand it (which can be done
I forgot to answer the test coverage question: no, move() is not covered by
any test, even indirectly.
The function is not used in other parts of the code currently.
B
On Sun, 6 Jan 2019 at 13:44, Bruno Chareyre
wrote:
> Hi Janek,
> I think that was the right fix, thanks.
> Note that yade is
Hi Janek,
I think that was the right fix, thanks.
Note that yade is not using the periodic triangulation implemented in CGAL
[1] so there is no question on that point afaik.
Bruno
[1] that's because yade included periodicity years before cgal. I actually
implemented a periodicity based on cgal's
4 matches
Mail list logo
