Re: [Yade-dev] High precision Real and minieigen

Yes, I think that we can stay with boost::python. But we need to put minieigen sources back into yade. best regards Janek Anton Gladky said: (by the date of Sun, 23 Feb 2020 22:08:47 +0100) > Hi Janek, > > thanks a lot for this quick tests and results! Really impressive! > > As far as I

Re: [Yade-dev] High precision Real and minieigen

Hi Janek, thanks for pybind feedback. It is intriguing. It was definitely after me mentionning compile times with boost for c++ / python, at a workshop, that someone reached me and advised about pybind. Rumor? Bruno Le dim. 23 févr. 2020 16:03, Janek Kozicki (yade) a écrit : > > Another

Re: [Yade-dev] High precision Real and minieigen

> Another note: I just realized that the compilation benchmarks might > have not been fair, because I think that I added few more > registrations (like Vector2c, or sth. like that) while doing pybind > migration. I will compare again without these extra registrations. OK, I have compared with the

Re: [Yade-dev] High precision Real and minieigen

Hi Anton > sorry for delays, "real" life is taking much more time when we get older :) please don't worry. I really appreciate all your hard work. I got a little carried away, I'm sorry. > > * I would rather avoid pybind11 switch in a rush, better give it a few > > months > Maybe I was not

Re: [Yade-dev] High precision Real and minieigen

Hi All :) I did an experimental switch to pybind, see this pipeline: https://gitlab.com/cosurgi/minieigen-real/pipelines/120246349 My observations about pybind11+minieigen: 1. pybind11 seems better organized and easier to use than boost::python 2. pybind11 has unstable API, what compiles on

Re: [Yade-dev] High precision Real and minieigen

Hello Janek, sorry for delays, "real" life is taking much more time when we get older :) > * I would rather avoid pybind11 switch in a rush, better give it a few months Maybe I was not clear, pybind11 is just a possible option. If we really decide to switch to it, we need to evaluate, whether

Re: [Yade-dev] High precision Real and minieigen

Guys, just to be clear: pybind11 migration was just a possible option for the future. I have no experience and no idea, whether it is better option or not. We can experiment with minieigen (switching it to pybind11) and see, whether it is suitable for our needs. Anton Am Sa., 22. Feb. 2020 um

Re: [Yade-dev] High precision Real and minieigen

It makes sense to me to not rush to pybind right now, although I don't mean to refrain any volunteer... B On Sat, 22 Feb 2020 at 11:05, Janek Kozicki (yade) wrote: > OK, I will experiment a bit and see what it takes to switch to pybind11. > > Janek > > > Janek Kozicki (yade) said: (by the

Re: [Yade-dev] High precision Real and minieigen

OK, I will experiment a bit and see what it takes to switch to pybind11. Janek Janek Kozicki (yade) said: (by the date of Fri, 21 Feb 2020 22:30:04 +0100) > Hi Anton, > > Yes, the number of defines in Serialization.hpp is crazy. > Changing/removing them to use pybind11 would take a lot of

Re: [Yade-dev] High precision Real and minieigen

Hi Anton, Yes, the number of defines in Serialization.hpp is crazy. Changing/removing them to use pybind11 would take a lot of work. I'm sure it is possible, but not quickly. We can open an issue about pybind11 switch. Discuss pros and cons, find a good strategy to deal with crazy defines and

Re: [Yade-dev] High precision Real and minieigen

Hi Janek, we have misunderstanding here. python3-minieigen is the __binary__ package and it is a bad idea to ship the source code with the package. Adding minieigen-src binary package is possible, but it looks like very undesired way. As I see, only Yade is using minieigen in the Debian. So,

Re: [Yade-dev] High precision Real and minieigen

Uh Anton, I'm sorry to be so boring: I have checked with sid in /etc/apt/sources.list: deb-src http://ftp.pl.debian.org/debian/ sid main non-free contrib and built the python3-minieigen_0.50.3+dfsg1-12_amd64.deb package. There is no /usr/include/minieigen/*pp files inside :( For high

Re: [Yade-dev] High precision Real and minieigen

Hi, this is great. Thanks a lot Anton. I removed yade-daily from yade-dev project on Gitlab, btw. Bruno p.s. As a side note, Vaçlav dropped minieigen support because of pybind move mainly. That package seems to reduce compilation times significantly

Re: [Yade-dev] High precision Real and minieigen

Anton did you remember about `./debian/python3-minieigen.install` file with content: src/*pp usr/include/minieigen/ ? It is not a part of upstream repository. I guess It's part of packaging process. At least that's how I understand it. Without sources in /usr/include/minieigen/ yade high

Re: [Yade-dev] High precision Real and minieigen

Thank you Anton, this is very considerate of you. best regards Janek Anton Gladky said: (by the date of Thu, 20 Feb 2020 20:17:25 +0100) > Hi Janek, > > I have backported both of your patches [1], [2] into the > existing in Debian minieigen-package and uploaded into > the Debian. > > The

Re: [Yade-dev] High precision Real and minieigen

Hi Janek, I habe backported both of your patches [1], [2] into the existing in Debian minieigen-package and uploaded into the Debian. The newer minieigen can now be polished, new version released and uploaded with no rush. [1] https://github.com/eudoxos/minieigen/pull/24 [2]

Re: [Yade-dev] High precision Real and minieigen

I have asked Vaclav to transfer maintenance of miniEigen to us: https://github.com/eudoxos/minieigen/pull/26 cheers Janek Anton Gladky said: (by the date of Tue, 18 Feb 2020 20:22:31 +0100) > Hi Janek, > > if Vaclav is not against it, I agree to move the miniegen back to > Yade

Re: [Yade-dev] High precision Real and minieigen

Hi, Vaclav has accepted my pull request to minieigen. The macro name is now `_HIGH_PRECISION_SUPPORT`, instead of `MINIEIGEN_OVERRIDE`. I will update the code. Anton, what are the perspectives of updating debian/ubuntu package? Please remember about `python3-minieigen.install` file with

Re: [Yade-dev] High precision Real. (minieigen patches)

In the attachment are the minimal minieigen patches: These are the super-minimal necessary patches: 1. 50_fix_minieigen_agnostic_to_Real.patch 2. 52_fix_convertible_Scalar_types.patch 3. python3-minieigen.install This one is not strictly necessary. It's just a bugfix. The Vector4r was broken,

Re: [Yade-dev] High precision Real.

Hi Anton, > Can we avoid it somehow? minieigen sources were in Yade tree many years > ago and we managed to drop them, introducing minieigen packages. > It would not be the best variant to put them in the source again. Another solution is that you will include these patches [1] in the debian and

Re: [Yade-dev] High precision Real.

Hi Janek, > BTW, Anton did you notice that building debian package fails on > master due to missing python-gts? > https://gitlab.com/yade-dev/trunk/issues/139 please review this MR [1]. It fixes build-dependency problem and also --help regression introduced with "--stdperformance" option. > And

Re: [Yade-dev] High precision Real.

Anton Gladky said: (by the date of Thu, 23 Jan 2020 06:44:02) > I do really appreciate this kind of work! > But how can we rely on custom builds of the third party software? > Sorry, but this restriction will get Yade into the dependency hell. Yes, I completely agree with this premise. I

[Yade-dev] High precision Real.

Hi, the code for high precision is complete and passes all the tests. I am writing documentation for this now, I will mention there: - about VTK ↔ double compatibility - about GLViewer ↔ double compatibility - how to build and run high precision code I have separated most of this work in to