Re: [Yade-dev] removing GeometricalModel

2009-11-18 Thread Václav Šmilauer
Since there was surprisingly no reaction, here is a list of files that won't compile with the current revision, since they rely on GeometricalModel (or rely on files which rely on GeometricalModel etc). Some of them are GeometricalModel's themselves, which will be removed, but you should fix the

Re: [Yade-dev] removing GeometricalModel

2009-11-18 Thread Bruno Chareyre
Many *Triaxial* classes are also disabled; the createSphere function is copied about 7 times in the source and I fixed only a few of them, which is a trivial fix. Concerning the fix in Triaxial files, when I have this : #ifdef YADE_SHAPE shared_ptrSphere gSphere(new Sphere);

Re: [Yade-dev] removing GeometricalModel

2009-11-18 Thread Václav Šmilauer
Concerning the fix in Triaxial files, when I have this : #ifdef YADE_SHAPE shared_ptrSphere gSphere(new Sphere); gSphere-radius= radius; gSphere-diffuseColor= spheresColor; gSphere-wire= false;

Re: [Yade-dev] removing GeometricalModel

2009-11-18 Thread Sergei D.
Václav Šmilauer пишет: As suggested earlier on the list, I will be deprecating GeometricalModel. Files that need it for functionality will be marked YADE_REQUIRE_FEATURE(shape), hence unfunctional in regular builds. Later, they will be removed. But, what if body have a geometry model but

Re: [Yade-dev] removing GeometricalModel

2009-11-18 Thread Bruno Chareyre
But, what if body have a geometry model but not a interacting geometry? (i.e. body don't interact with other bodies). So, that body is virtual body. I need this type of bodies in order to generate new spheres on their surface/volume in course of sumulation. I know what you mean... 1. You

Re: [Yade-dev] removing GeometricalModel

2009-11-18 Thread Václav Šmilauer
But, what if body have a geometry model but not a interacting geometry? (i.e. body don't interact with other bodies). So, that body is virtual body. I need this type of bodies in order to generate new spheres on their surface/volume in course of sumulation. Alternately to Bruno's suggestion,

Re: [Yade-dev] removing GeometricalModel

2009-11-18 Thread Václav Šmilauer
Thanks! I will do likewise. And if we don't have GeometryModel any more, may be do rename InteractingFacet to Facet? So, we will have, for example, Facet for the interacting facets and VirtualFacet for noninteracting facets. Pssst for renaming... Of course in due time, Interacting* will

Re: [Yade-dev] removing GeometricalModel

2009-11-18 Thread Sergei D.
I'd be a little careful with adding duplicate virtual classes, though. A flag in the InteractingGeometry might do as well. Yes, this design seems more appropriate than adding parallel class hierarchy... Occam's razor principle... Oh, BTW, if your body doesn't have bounding box, it will not

Re: [Yade-dev] removing GeometricalModel

2009-11-18 Thread Václav Šmilauer
(in python, yade.utils.{sphere,facet,wall} assigns AABB, and there is no way to assign no BoundingVolume in python at all... we will figure that out somehow, though) I stand corrected. You _can_ assign None to Body().bound in python, which will reset the pointer to shared_ptrBoundingVolume()

Re: [Yade-dev] removing GeometricalModel

2009-11-17 Thread Václav Šmilauer
Hi everybody, as announced, r1789 (symbolic number: prise de la Bastille) removes GeometricalModel. I fixed some code by hand, but many classes are not being compiled now. I added new feature 'shape' that compiles everything as it used to be. Classes that are not compiled are marked by

[Yade-dev] removing GeometricalModel

2009-11-16 Thread Václav Šmilauer
As suggested earlier on the list, I will be deprecating GeometricalModel. Files that need it for functionality will be marked YADE_REQUIRE_FEATURE(shape), hence unfunctional in regular builds. Later, they will be removed. Please adjust your code that relies on GeometricalModel to get the data it