Re: [Yade-dev] Fwd: Re: [Question #691593]: avoid this message : "The constructor with a shareWidget is deprecated, use the regular contructor instead."

2020-07-27 Thread Luc Oger

Dear Janek,

If I have catched the pipeline view, the patch passed the make_suse15  
and the check_suse15 which explains why my patch was working for me!!


other I am surprised by the 
'|/builds/yade-dev/trunk/gui/qt5/GLViewer.hpp:91:67:error: 
'QOpenGLWidget' has not been declared "error message as |
||QOpenGLWidgetis declared in the include file of the libQGLviewer2.7.2 
include file of the package : see line 64 in QGLViewer/qglviewer.h



Best Regards

Luc

PS I will try to understand how to run the pipeline in order to found a 
more 'general' patch.


||
Le 27/07/2020 à 14:59, Janek Kozicki (yade) a écrit :

Hi Luc,

your patch does not pass the pipeline: 
https://gitlab.com/yade-dev/trunk/-/merge_requests/512/pipelines

feel free to correct it and open another merge request. It is now
possible to run pipelines for forked projects [1][2] so it is much
easier now for you to submit a merge request.

best regards
Janek

[1] https://gitlab.com/gitlab-org/gitlab/-/issues/217451
[2] https://gitlab.com/yade-dev/trunk/-/merge_requests/511#note_385917497

Luc Oger said: (by the date of Sat, 4 Jul 2020 12:50:18 +0200)


Dear all,

as requested, here the three changes made to avoid the warning about
sharewidget coming from libqglViewer from 2.7.1 and Qt higher than 5.3

Sinceelry yours

Luc OGER

Ps hint on https://www.qt.io/blog/2014/09/10/qt-weekly-19-qopenglwidget
given from libqglviewer group

 Message transféré 
Sujet : Re: [Question #691593]: avoid this message : "The constructor
with a shareWidget is deprecated, use the regular contructor instead."
Date :  Fri, 03 Jul 2020 12:11:00 -
De :Jérôme Duriez 
Répondre à :question691...@answers.launchpad.net
Pour :  luc.o...@univ-rennes1.fr



Your question #691593 on Yade changed:
https://answers.launchpad.net/yade/+question/691593

Jérôme Duriez posted a new comment:
Thanks for sharing Luc, maybe it would help for possible future
integration of this to (one choice to pick, increasing complexity)

- send the output of a (git) diff to yade-dev@lists.launchpad.net

- join YADE development on GitLab, see https://yade-
dem.org/doc/gitrepo.html to start with (you probably also need to send
an email asking to join the yade-dev gitlab team with your gitlab
account)

--
You received this question notification because you asked the question.


--
Luc OGER
Directeur de Recherche CNRS

univ-rennes1 


*Institut de Physique de Rennes *
(UMR U.Rennes1-CNRS 6251)
Département Milieux Divisés

Page perso **


Bâtiment 11A, Campus de Beaulieu
CS 74205, 263 Ave. du Général Leclerc
35042 Rennes CEDEX



+33 (0)2 23 23 56 58


 
www.univ-rennes1.fr 






--
Luc OGER
Directeur de Recherche CNRS

univ-rennes1 


*Institut de Physique de Rennes *
(UMR U.Rennes1-CNRS 6251)
Département Milieux Divisés

Page perso **


Bâtiment 11A, Campus de Beaulieu
CS 74205, 263 Ave. du Général Leclerc
35042 Rennes CEDEX



+33 (0)2 23 23 56 58


 
www.univ-rennes1.fr 




smime.p7s
Description: Signature cryptographique S/MIME
___
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Yade-dev] Fwd: Re: [Question #691593]: avoid this message : "The constructor with a shareWidget is deprecated, use the regular contructor instead."

2020-07-27 Thread Janek Kozicki (yade)
Hi Luc,

your patch does not pass the pipeline: 
https://gitlab.com/yade-dev/trunk/-/merge_requests/512/pipelines

feel free to correct it and open another merge request. It is now
possible to run pipelines for forked projects [1][2] so it is much
easier now for you to submit a merge request.

best regards
Janek

[1] https://gitlab.com/gitlab-org/gitlab/-/issues/217451
[2] https://gitlab.com/yade-dev/trunk/-/merge_requests/511#note_385917497

Luc Oger said: (by the date of Sat, 4 Jul 2020 12:50:18 +0200)

> Dear all,
> 
> as requested, here the three changes made to avoid the warning about 
> sharewidget coming from libqglViewer from 2.7.1 and Qt higher than 5.3
> 
> Sinceelry yours
> 
> Luc OGER
> 
> Ps hint on https://www.qt.io/blog/2014/09/10/qt-weekly-19-qopenglwidget 
> given from libqglviewer group
> 
>  Message transféré 
> Sujet :   Re: [Question #691593]: avoid this message : "The constructor 
> with a shareWidget is deprecated, use the regular contructor instead."
> Date :Fri, 03 Jul 2020 12:11:00 -
> De :  Jérôme Duriez 
> Répondre à :  question691...@answers.launchpad.net
> Pour :luc.o...@univ-rennes1.fr
> 
> 
> 
> Your question #691593 on Yade changed:
> https://answers.launchpad.net/yade/+question/691593
> 
> Jérôme Duriez posted a new comment:
> Thanks for sharing Luc, maybe it would help for possible future
> integration of this to (one choice to pick, increasing complexity)
> 
> - send the output of a (git) diff to yade-dev@lists.launchpad.net
> 
> - join YADE development on GitLab, see https://yade-
> dem.org/doc/gitrepo.html to start with (you probably also need to send
> an email asking to join the yade-dev gitlab team with your gitlab
> account)
> 
> -- 
> You received this question notification because you asked the question.
> 
> 
> -- 
> Luc OGER
> Directeur de Recherche CNRS
>   
> univ-rennes1 
>   
> 
> *Institut de Physique de Rennes *
> (UMR U.Rennes1-CNRS 6251)
> Département Milieux Divisés
> 
> Page perso **
>   
> 
> Bâtiment 11A, Campus de Beaulieu
> CS 74205, 263 Ave. du Général Leclerc
> 35042 Rennes CEDEX
> 
>   
> 
> +33 (0)2 23 23 56 58
> 
>   
>  
> www.univ-rennes1.fr 
>   
> 


-- 
--
Janek Kozicki, PhD. DSc. Arch. Assoc. Prof.
Gdańsk University of Technology
Faculty of Applied Physics and Mathematics
Department of Theoretical Physics and Quantum Information
--
http://yade-dem.org/
http://pg.edu.pl/jkozicki (click English flag on top right)

___
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp


[Yade-dev] Fwd: Re: [Question #691593]: avoid this message : "The constructor with a shareWidget is deprecated, use the regular contructor instead."

2020-07-04 Thread Luc Oger

Dear all,

as requested, here the three changes made to avoid the warning about 
sharewidget coming from libqglViewer from 2.7.1 and Qt higher than 5.3


Sinceelry yours

Luc OGER

Ps hint on https://www.qt.io/blog/2014/09/10/qt-weekly-19-qopenglwidget 
given from libqglviewer group


 Message transféré 
Sujet : 	Re: [Question #691593]: avoid this message : "The constructor 
with a shareWidget is deprecated, use the regular contructor instead."

Date :  Fri, 03 Jul 2020 12:11:00 -
De :Jérôme Duriez 
Répondre à :question691...@answers.launchpad.net
Pour :  luc.o...@univ-rennes1.fr



Your question #691593 on Yade changed:
https://answers.launchpad.net/yade/+question/691593

Jérôme Duriez posted a new comment:
Thanks for sharing Luc, maybe it would help for possible future
integration of this to (one choice to pick, increasing complexity)

- send the output of a (git) diff to yade-dev@lists.launchpad.net

- join YADE development on GitLab, see https://yade-
dem.org/doc/gitrepo.html to start with (you probably also need to send
an email asking to join the yade-dev gitlab team with your gitlab
account)

--
You received this question notification because you asked the question.


--
Luc OGER
Directeur de Recherche CNRS

univ-rennes1 


*Institut de Physique de Rennes *
(UMR U.Rennes1-CNRS 6251)
Département Milieux Divisés

Page perso **


Bâtiment 11A, Campus de Beaulieu
CS 74205, 263 Ave. du Général Leclerc
35042 Rennes CEDEX



+33 (0)2 23 23 56 58


 
www.univ-rennes1.fr 


diff --git a/./gui/qt5/OpenGLManager.cpp 
b/../trunk_modifie/gui/qt5/OpenGLManager.cpp
index d88002a71..928c6c747 100644
--- a/./gui/qt5/OpenGLManager.cpp
+++ b/../trunk_modifie/gui/qt5/OpenGLManager.cpp
@@ -53,7 +53,7 @@ void OpenGLManager::createViewSlot()
 {
const std::lock_guard lock(viewsMutex);
if (views.size() == 0) {
-   
views.push_back(shared_ptr(boost::make_shared(0, renderer, 
/*shareWidget*/ (QGLWidget*)0)));
+   
views.push_back(shared_ptr(boost::make_shared(0, renderer, 
/*QopenGLWidget*/ (QOpenGLWidget*)0)));
} else {
throw runtime_error("Secondary views not supported");
//views.push_back(shared_ptr(new 
GLViewer(views.size(),renderer,views[0].get(;



diff --git a/./gui/qt5/GLViewer.cpp b/../trunk_modifie/gui/qt5/GLViewer.cpp
index 8b12514c6..5f598df4a 100644
--- a/./gui/qt5/GLViewer.cpp
+++ b/../trunk_modifie/gui/qt5/GLViewer.cpp
@@ -61,8 +61,8 @@ void GLViewer::staticCloseEvent(QCloseEvent* e, const int 
viewId)

 void GLViewer::closeEvent(QCloseEvent* e) { GLViewer::staticCloseEvent(e, 
viewId); }

-GLViewer::GLViewer(int _viewId, const shared_ptr& _renderer, 
QGLWidget* shareWidget)
-: QGLViewer(/*parent*/ (QWidget*)NULL, shareWidget)
+GLViewer::GLViewer(int _viewId, const shared_ptr& _renderer, 
QOpenGLWidget* parent)
+: QGLViewer(/*parent*/ (QWidget*) parent)
 , renderer(_renderer)
 , viewId(_viewId)
 {



diff --git a/./gui/qt5/GLViewer.hpp b/../trunk_modifie/gui/qt5/GLViewer.hpp
index d576bf724..391b73d8b 100644
--- a/./gui/qt5/GLViewer.hpp
+++ b/../trunk_modifie/gui/qt5/GLViewer.hpp
@@ -88,7 +88,7 @@ public:
int  timeDispMask;
enum { TIME_REAL = 1, TIME_VIRT = 2, TIME_ITER = 4 };

-   GLViewer(int viewId, const shared_ptr& renderer, 
QGLWidget* shareWidget = 0);
+   GLViewer(int viewId, const shared_ptr& renderer, 
QOpenGLWidget* Widget = 0);
virtual ~GLViewer();
 #if 0
virtual void paintGL();


smime.p7s
Description: Signature cryptographique S/MIME
___
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp