Re: [Yade-dev] should we drop qt4 support?

2020-03-10 Thread Janek Kozicki (yade)
Bruno Chareyre said: (by the date of Tue, 10 Mar 2020 20:42:08 +0100) > Wow, thanks a ton for clarifying. Recently I was wondering why dragging > with mouse did not work like before... I'll check. OK, great! Please push the fix to https://gitlab.com/yade-dev/trunk/-/merge_requests/438 :-))

Re: [Yade-dev] should we drop qt4 support? + clang-format ?

2020-03-10 Thread Janek Kozicki (yade)
Bruno Chareyre said: (by the date of Tue, 10 Mar 2020 13:13:47 +0100) > Do you mean to reformat the whole repository? yes, exactly. Sorry for so many merge requests (again). This time I was thinking that maybe someone was working in ./core and not in ./lib directory. Maybe I should have done

Re: [Yade-dev] should we drop qt4 support?

2020-03-10 Thread Bruno Chareyre
Wow, thanks a ton for clarifying. Recently I was wondering why dragging with mouse did not work like before... I'll check. Thanks Bruno Le mar. 10 mars. 2020 20:28, Janek Kozicki (yade) a écrit : > Bruno Chareyre said: (by the date of Tue, 10 Mar 2020 13:10:24 +0100) > > That's what puzzled

Re: [Yade-dev] should we drop qt4 support?

2020-03-10 Thread Janek Kozicki (yade)
Bruno Chareyre said: (by the date of Tue, 10 Mar 2020 13:10:24 +0100) > That's what puzzled me in the first place. So deeply that I didn't dare > replying to the question. :) Ah sorry, here's exactly what I meant: qt5/GLViewer.cpp, function postSelection() was written by Anton in 2015-06-26

Re: [Yade-dev] should we drop qt4 support? + clang-format ?

2020-03-10 Thread Vasileios Angelidakis (PGR)
To: Yade developers Subject: Re: [Yade-dev] should we drop qt4 support? + clang-format ? On Mon, 9 Mar 2020 at 23:28, Janek Kozicki (yade) mailto:jkozicki-y...@pg.edu.pl>> wrote: Since I have finished all the large modifications in master I thought about clang-formatting it. But maybe somebod

Re: [Yade-dev] should we drop qt4 support? + clang-format ?

2020-03-10 Thread Bruno Chareyre
On Mon, 9 Mar 2020 at 23:28, Janek Kozicki (yade) wrote: > > Since I have finished all the large modifications in master I thought > about clang-formatting it. > But maybe somebody else has some ongoing large changes and prefers to wait > with this? > Hi, Do you mean to reformat the whole

Re: [Yade-dev] should we drop qt4 support?

2020-03-10 Thread Bruno Chareyre
Hi there, On Mon, 9 Mar 2020 at 21:53, Anton Gladky wrote: > > > If we decided to remove qt4, then we need to decide which version of > > GLViewer::postSelection(…) > > If we drop qt4 directory completely, then we will have only qt5-version > of this method, right? > That's what puzzled me in

Re: [Yade-dev] should we drop qt4 support? + clang-format ?

2020-03-09 Thread Janek Kozicki (yade)
Anton Gladky said: (by the date of Mon, 9 Mar 2020 21:54:04 +0100) > If we drop qt4 directory completely, then we will have only qt5-version > of this method, right? Oh, right. And it was used for a long time, so it must be good :) I have just updated that merge request and removed qt4

Re: [Yade-dev] should we drop qt4 support?

2020-03-09 Thread Anton Gladky
Hello Janek, I think it is a time already to drop qt4 support completely. > If we decided to remove qt4, then we need to decide which version of > GLViewer::postSelection(…) If we drop qt4 directory completely, then we will have only qt5-version of this method, right? Regards Anton Am So.,

Re: [Yade-dev] should we drop qt4 support?

2020-03-08 Thread Janek Kozicki (yade)
If we decided to remove qt4, then we need to decide which version of GLViewer::postSelection(…) to use, because `meld gui/qt4 gui/qt5` shows that this function is the only one that differs between the two directories. Janek Kozicki (yade) said: (by the date of Sun, 8 Mar 2020 22:54:07

[Yade-dev] should we drop qt4 support?

2020-03-08 Thread Janek Kozicki (yade)
These last two merge requests have duplicate changes in both directories. The changes are identical, because I did git diff --staged > /tmp/z.patch # edit file, replace qt5 with qt5 patch -p1 < /tmp/z.patch but having two copies of same stuff isn't healthy. Does anyone still use qt4? best