Re: [Yade-dev] Dynamic bodies and getSpheresVolume()

2016-05-26 Thread Jerome Duriez 
See 
https://github.com/yade/trunk/commit/c1a5e87a84423686780299b2fc09acfb2606a67b, 
thanks !

Jerome



From: Yade-dev [yade-dev-bounces+jerome.duriez=ucalgary...@lists.launchpad.net] 
on behalf of Bruno Chareyre [bruno.chare...@grenoble-inp.fr]
Sent: May-26-16 7:05 AM
To: yade-dev@lists.launchpad.net
Subject: Re: [Yade-dev] Dynamic bodies and getSpheresVolume()

It makes sense indeed.
The dynamic check was probably a loose evaluation of shape, now redundant.
Bruno

On 05/20/2016 11:30 PM, Jerome Duriez wrote:
Hi,

getSpheresVolume() currently skips all dynamic bodies before even considering 
whether they are spheres or not [*]. I think it would you make sense to just 
consider the shape, and to remove this "dynamic" condition.

It would for instance allow to use consistently porosity() function for a fixed 
packing of sphere. (Now, porosity() then always returns 1 in such case)

What do you think ?


Jerome


[*] 
https://github.com/yade/trunk/blob/6d4a0d1689c6bad2dbdd6e27d1653418f7fc6498/pkg/dem/Shop_01.cpp#L308


PS: the same applies for other functions, such as getSpheresMass(), but this 
has not been an issue for me...



___
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net<mailto:yade-dev@lists.launchpad.net>
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Yade-dev] Dynamic bodies and getSpheresVolume()

2016-05-26 Thread Bruno Chareyre 

It makes sense indeed.
The dynamic check was probably a loose evaluation of shape, now redundant.
Bruno

On 05/20/2016 11:30 PM, Jerome Duriez wrote:

Hi,

getSpheresVolume() currently skips all dynamic bodies before even 
considering whether they are spheres or not [*]. I think it would you 
make sense to just consider the shape, and to remove this "dynamic" 
condition.


It would for instance allow to use consistently porosity() function 
for a fixed packing of sphere. (Now, porosity() then always returns 1 
in such case)


What do you think ?


Jerome


[*] 
https://github.com/yade/trunk/blob/6d4a0d1689c6bad2dbdd6e27d1653418f7fc6498/pkg/dem/Shop_01.cpp#L308



PS: the same applies for other functions, such as getSpheresMass(), 
but this has not been an issue for me...



___
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp