Re: [Yade-dev] should we drop qt4 support? + clang-format ?
Bruno Chareyre said: (by the date of Tue, 10 Mar 2020 13:13:47 +0100) > Do you mean to reformat the whole repository? yes, exactly. Sorry for so many merge requests (again). This time I was thinking that maybe someone was working in ./core and not in ./lib directory. Maybe I should have done just one huge MR?. I usually exaggerate stuff to stay on the safe side ;) But these MRs are separate dirs, they cannot be in conflict with each other. And I am thinking that maybe we can do this reformatting now, because I finished the high precision stuff. While doing the HP coding I had crazy amount of interleaving branches. Reformatting at that time wasn't possible. And I had to make so many different merge requests, and still they were quite large (even though I did split them into as many smaller parts for easier checking as I could). But now HP is finished, so we could do that (from my perspective). Provided that it is not colliding with your local code. :) It's not a problem to close these MRs, reopen later when needed and `git push --force` the up-to-date reformatted code. Meaning: we can do this later if it hurts anybody now. Vasileios Angelidakis (PGR) said: (by the date of Tue, 10 Mar 2020 13:45:59 +) > I don’t have any objections if you clang-format the whole repository. Can do > the same with my local WIP repository to avoid conflicts. Great, thanks! Let's see what others can say about this? :) best regards Janek -- -- Janek Kozicki, PhD. DSc. Arch. Assoc. Prof. Gdańsk University of Technology Faculty of Applied Physics and Mathematics Department of Theoretical Physics and Quantum Information -- http://yade-dem.org/ http://pg.edu.pl/jkozicki (click English flag on top right) ___ Mailing list: https://launchpad.net/~yade-dev Post to : yade-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
Re: [Yade-dev] should we drop qt4 support? + clang-format ?
Hi all, I don’t have any objections if you clang-format the whole repository. Can do the same with my local WIP repository to avoid conflicts. All the best, Vasileios From: Yade-dev on behalf of Bruno Chareyre Sent: Tuesday, March 10, 2020 12:13:47 PM To: Yade developers Subject: Re: [Yade-dev] should we drop qt4 support? + clang-format ? On Mon, 9 Mar 2020 at 23:28, Janek Kozicki (yade) mailto:jkozicki-y...@pg.edu.pl>> wrote: Since I have finished all the large modifications in master I thought about clang-formatting it. But maybe somebody else has some ongoing large changes and prefers to wait with this? Hi, Do you mean to reformat the whole repository? Hopefully someone will raise hands in such case. Vasileios maybe? B ___ Mailing list: https://launchpad.net/~yade-dev Post to : yade-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
Re: [Yade-dev] should we drop qt4 support? + clang-format ?
On Mon, 9 Mar 2020 at 23:28, Janek Kozicki (yade) wrote: > > Since I have finished all the large modifications in master I thought > about clang-formatting it. > But maybe somebody else has some ongoing large changes and prefers to wait > with this? > Hi, Do you mean to reformat the whole repository? Hopefully someone will raise hands in such case. Vasileios maybe? B ___ Mailing list: https://launchpad.net/~yade-dev Post to : yade-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
Re: [Yade-dev] should we drop qt4 support? + clang-format ?
Anton Gladky said: (by the date of Mon, 9 Mar 2020 21:54:04 +0100) > If we drop qt4 directory completely, then we will have only qt5-version > of this method, right? Oh, right. And it was used for a long time, so it must be good :) I have just updated that merge request and removed qt4 directory. Fortunately we have GUI tests in the pipeline, so it should detect any abnormalities :) (there shouldn't be any, I guess). Since I have finished all the large modifications in master I thought about clang-formatting it. But maybe somebody else has some ongoing large changes and prefers to wait with this? If changes are small, then you could run: scripts/clang-formatter.sh $YOUR_FILE and copy it onto the reformatted file. Then the only changes in the diff will be the modified lines. best regards Janek > > Regards > > Anton > > Am So., 8. März 2020 um 23:07 Uhr schrieb Janek Kozicki (yade) > : > > > > If we decided to remove qt4, then we need to decide which version of > > GLViewer::postSelection(…) to use, because `meld gui/qt4 gui/qt5` > > shows that this function is the only one that differs between the two > > directories. > > > > > > > > Janek Kozicki (yade) said: (by the date of Sun, 8 Mar 2020 22:54:07 > > +0100) > > > > > These last two merge requests have duplicate changes in both directories. > > > The changes are identical, because I did > > > > > > git diff --staged > /tmp/z.patch > > > # edit file, replace qt5 with qt5 > > > patch -p1 < /tmp/z.patch > > > > > > but having two copies of same stuff isn't healthy. Does anyone still use > > > qt4? > > > > > > best regards > > > Janek -- -- Janek Kozicki, PhD. DSc. Arch. Assoc. Prof. Gdańsk University of Technology Faculty of Applied Physics and Mathematics Department of Theoretical Physics and Quantum Information -- http://yade-dem.org/ http://pg.edu.pl/jkozicki (click English flag on top right) ___ Mailing list: https://launchpad.net/~yade-dev Post to : yade-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
