Reviewed: https://review.openstack.org/271301 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=913a64cc1175b3bd7efc7abe34895c32bf39a696 Submitter: Jenkins Branch: master
commit 913a64cc1175b3bd7efc7abe34895c32bf39a696 Author: Sreekumar S <sree...@gmail.com> Date: Fri Jan 22 19:09:49 2016 +0530 SG protocol validation to allow numbers or names SG rule protocol provided is validated against the DB rules' protocols for both number and name. The filter provided to DB is modified so that it is queried for records with both the protocol name and number, instead of exactly the type provided with the input. The returned DB rule record's protocol field is validated against the supplied SG protocol field for both name or number. This way, user is still allowed to enter protocol name or number to create a rule, and API compatibility is maintained. Change-Id: If4ad684e961433b8d9d3ec8fe2810585d3f6a093 Closes-Bug: #1215181 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1215181 Title: Security group rules validation allows duplicate rules Status in neutron: Fix Released Bug description: If I try to create a security group rule by specifying the protocol by number like so: neutron security-group-rule-create test --protocol 6 --port-range-min MIN --port-range-max MAX And then specifying the protocol by name: neutron security-group-rule-create test --protocol TCP --port-range- min MIN --port-range-max MAX I would expect Neutron to say that I am adding a duplicated rule, but it doesn't, it creates it twice. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1215181/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp