Reviewed: https://review.openstack.org/265016
Committed:
https://git.openstack.org/cgit/openstack/neutron/commit/?id=9390dde943915da9fe0e21b8d4822a3f31a347cf
Submitter: Jenkins
Branch: master
commit 9390dde943915da9fe0e21b8d4822a3f31a347cf
Author: Kevin Benton <blak...@gmail.com>
Date: Thu Jan 7 15:40:27 2016 -0800
make floating IP specification test robust to races
The get_unused_ip function returns an address that isn't in use on
the network at the time it's called. However, by the time the caller
uses it, it may have been allocated to another concurrent test if
the network is shared or external.
The test_create_floatingip_with_specified_ip_address test creates
a floating IP with an unused IP on the external network, which has
lots of activity on it from other tests so it would occasionally
have its address taken by another test.
This patch just catches the in use error and tries again with a
new IP.
Change-Id: I5a2f78a6da1e400dea07949f35964abb767edbb2
Closes-Bug: #1532033
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1532033
Title:
test_create_floatingip_with_specified_ip_address is racey
Status in neutron:
Fix Released
Bug description:
test_create_floatingip_with_specified_ip_address gets an unused IP
address and then tries to use it for an operation. The issue is that
it gets it from an external network that other tests may be allocating
ports from. So it can grab an IP and then another test can allocate a
port that gets that IP before it tries it floating IP creation. In
this case the floating IP creation will fail:
Details: {u'message': u'Unable to complete operation for network
477f7fb6-aea4-470c-82ca-c05936264e2e. The IP address 172.24.5.8 is in
use.', u'detail': u'', u'type': u'IpAddressInUse'}
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1532033/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
