Reviewed: https://review.openstack.org/329474
Committed:
https://git.openstack.org/cgit/openstack/neutron/commit/?id=5e0878f476d7116bc4e0c29c7929718f379b36c2
Submitter: Jenkins
Branch: master
commit 5e0878f476d7116bc4e0c29c7929718f379b36c2
Author: Ihar Hrachyshka <ihrac...@redhat.com>
Date: Tue Jun 14 16:16:06 2016 +0200
Added API extensions to detect sorting/pagination features
Those features are available only when allow_sorting and
allow_pagination options are enabled (the current default is False).
They don't depend on plugin support, because when plugins don't
implement them natively, emulated mode is applied by API router itself.
So to make it plugin agnostic, we introduce a way to register custom
per-extension checks to override support detection for cases like that
one.
Now that we have a way to detect support for those features via API,
there is little reason to keep tempest configuration options to enable
those features. Instead, just inspect [network-feature-enabled]
api_extensions option in tempest.conf.
Now that DEFAULT_ALLOW_SORTING/DEFAULT_ALLOW_PAGINATION constants are
used in a single place only (in allow_sorting/allow_pagination
definitions), removed them and replaced with a literal.
Added first in-tree API tests for /extensions entry point.
DocImpact Update API documentation to cover new extensions.
APIImpact Document the new extensions.
Related-Bug: #1566514
Change-Id: I0aaaa037a8ad52060a68dd75c0a1accc6add238e
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1566514
Title:
Enable sorting and pagination by default
Status in neutron:
Fix Released
Bug description:
Currently those features are controlled by configuration options:
allow_sorting, allow_pagination, and they are disabled by default.
There are multiple issues with that:
- those useful API features are not available for any default installation of
neutron;
- it's not great when API behaviour is not consistent, depending on local
configuration;
- we don't have a way of detecting whether those features are enabled.
Base controller already supports both native and generic
implementations for those features: if a plugin claims native support,
then plugin calls are populated with corresponding sorting/pagination
parameters; otherwise the base controller 'emulates' those features
for the plugin. It seems that this fallback approach already covers
all cases, and we should be safe to enable those features for all
setups.
We need to make sure that testing coverage for the features is
adequate (API tests), that we test it in gate; then we should consider
enabling the features by default, deprecating those options and
eventually removing them.
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1566514/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
