Public bug reported:

root@controller01:~# glance image-update ubuntu-14.04-server-amd64 --property =
+-------------------------------+--------------------------------------+
| Property                      | Value                                |
+-------------------------------+--------------------------------------+
| Property ''                   | None                                 |
| Property 'vmware_adaptertype' | lsiLogic                             |
| Property 'vmware_disktype'    | streamOptimized                      |
| checksum                      | 7b26c526f6f7c8ab874ad55b2698dee0     |
| container_format              | bare                                 |
| created_at                    | 2016-07-21T07:37:42.000000           |
| deleted                       | False                                |
| deleted_at                    | None                                 |
| disk_format                   | vmdk                                 |
| id                            | 2fb0b8a1-1634-499d-95ee-2451ec23893e |
| is_public                     | True                                 |
| min_disk                      | 5                                    |
| min_ram                       | 512                                  |
| name                          | ubuntu-14.04-server-amd64            |
| owner                         | 5b53ee384ebc4212b4086241e1075dea     |
| protected                     | False                                |
| size                          | 971606528                            |
| status                        | active                               |
| updated_at                    | 2016-07-22T02:25:46.000000           |
| virtual_size                  | None                                 |
+-------------------------------+--------------------------------------+

The null key set success as the result.
But null key is meaningless to the user which also belong to the invalid input 
in other components, like cinder and nova flavor as below:

root@controller01:~# nova flavor-key m1.tiny set =
ERROR (CommandError): Invalid key: "". Keys may only contain letters, numbers, 
spaces, underscores, periods, colons and hyphens.

So for the consistent openstack UE and error handling, glance cli site
better to add the null key check.

** Affects: glance
     Importance: Undecided
     Assignee: QiangTang (qtang)
         Status: New

** Changed in: glance
     Assignee: (unassigned) => QiangTang (qtang)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1605444

Title:
  Should check null key when set key-value pair in property

Status in Glance:
  New

Bug description:
  root@controller01:~# glance image-update ubuntu-14.04-server-amd64 --property 
=
  +-------------------------------+--------------------------------------+
  | Property                      | Value                                |
  +-------------------------------+--------------------------------------+
  | Property ''                   | None                                 |
  | Property 'vmware_adaptertype' | lsiLogic                             |
  | Property 'vmware_disktype'    | streamOptimized                      |
  | checksum                      | 7b26c526f6f7c8ab874ad55b2698dee0     |
  | container_format              | bare                                 |
  | created_at                    | 2016-07-21T07:37:42.000000           |
  | deleted                       | False                                |
  | deleted_at                    | None                                 |
  | disk_format                   | vmdk                                 |
  | id                            | 2fb0b8a1-1634-499d-95ee-2451ec23893e |
  | is_public                     | True                                 |
  | min_disk                      | 5                                    |
  | min_ram                       | 512                                  |
  | name                          | ubuntu-14.04-server-amd64            |
  | owner                         | 5b53ee384ebc4212b4086241e1075dea     |
  | protected                     | False                                |
  | size                          | 971606528                            |
  | status                        | active                               |
  | updated_at                    | 2016-07-22T02:25:46.000000           |
  | virtual_size                  | None                                 |
  +-------------------------------+--------------------------------------+

  The null key set success as the result.
  But null key is meaningless to the user which also belong to the invalid 
input in other components, like cinder and nova flavor as below:

  root@controller01:~# nova flavor-key m1.tiny set =
  ERROR (CommandError): Invalid key: "". Keys may only contain letters, 
numbers, spaces, underscores, periods, colons and hyphens.

  So for the consistent openstack UE and error handling, glance cli site
  better to add the null key check.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1605444/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to     : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to