Public bug reported: I was again bit by this... tox works fine (running flake8) but built of zesty failed.
In cloud-init, the Makefile that is run during build runs (currently) pep8 and pyflakes (either pyflakes2 or pyflakes3). I think what we ultimately want is to run flake8 and let it run pyflakes and pep8. However, given dependencies and versions in different distro releases, this is a bit of a pain. One path to this is just to not run any code checking in the distro build, assuming that it is already run in trunk. I think that seems like a sane argument actually. One thing to note, is that pep8 is now called pycodestyle. Out of this, I'd like to have: a.) a tox target that tracks upstream pypi versions (but doesn't fail c-i), and somethign that runs this fairly often to at least see how bad we are getting. b.) a tox target that has pinned versions of checking tools, and runs checks both for python2 and python3. ** Affects: cloud-init Importance: Undecided Status: New ** Affects: curtin Importance: Undecided Status: New ** Also affects: curtin Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to cloud-init. https://bugs.launchpad.net/bugs/1652329 Title: sort out pyflakes flake8 pycodestyle pep8 Status in cloud-init: New Status in curtin: New Bug description: I was again bit by this... tox works fine (running flake8) but built of zesty failed. In cloud-init, the Makefile that is run during build runs (currently) pep8 and pyflakes (either pyflakes2 or pyflakes3). I think what we ultimately want is to run flake8 and let it run pyflakes and pep8. However, given dependencies and versions in different distro releases, this is a bit of a pain. One path to this is just to not run any code checking in the distro build, assuming that it is already run in trunk. I think that seems like a sane argument actually. One thing to note, is that pep8 is now called pycodestyle. Out of this, I'd like to have: a.) a tox target that tracks upstream pypi versions (but doesn't fail c-i), and somethign that runs this fairly often to at least see how bad we are getting. b.) a tox target that has pinned versions of checking tools, and runs checks both for python2 and python3. To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-init/+bug/1652329/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp