Reviewed: https://review.openstack.org/538676
Committed:
https://git.openstack.org/cgit/openstack/horizon/commit/?id=49fd528b7b814e8e8dab1fb238a79924fbf059b7
Submitter: Zuul
Branch: master
commit 49fd528b7b814e8e8dab1fb238a79924fbf059b7
Author: Akihiro Motoki <amot...@gmail.com>
Date: Mon Jan 29 05:45:00 2018 +0900
i18n: Allow translator to control the word order (trunk)
"<IP address> on subnet <subnet>" format in "Parent Port" and
"Subports" tabs in "Create Trunk" and "Edit Trunk" form did not
allow translators to control the word order because only "on subnet"
was marked as translation string and they are concatenated.
This commit improves the translation string by using the "translate
parameters" feature of Angular gettext.
Also "on subnet" in the "Network Ports" tab of "Create Instance"
workflow is now marked as translation string.
Change-Id: I189897eee8037466ace2b68b8f9be3dc242c4252
Closes-Bug: #1745873
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1745873
Title:
i18n: <IP address> on subnet <subnet> is hard to translate
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
In "Parent Port" and "Sub Ports" tabs of "Create Trunk" / "Edit Trunk"
form, the "IP" column of the port table contains information of the
format of "<IP address> on subnet <subnet>", but it is difficult to
translate considering the word order because only "on subnet" is
marked as translation string.
Also, "<IP address> on subnet <subnet>" in network ports" tab in the
"Create Instance" workflow is not marked as translation string.
Angular gettext supports "Translate parameters" feature [1]. By using
this, we can support the word order in translation.
[1] https://angular-gettext.rocketeer.be/dev-guide/translate-params/
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1745873/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
