This is no longer valid if you exclude all the things that are not running a
task.
I think the cloud steady state will be no instances running a task, so I don't
think we need to worry about the extra DB load of getting instances that are
running a task. It should be tiny.
** Changed in: nova
Status: In Progress => Won't Fix
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1572730
Title:
The _sync_power_states task should filter out instances.task_state !=
None up front
Status in OpenStack Compute (nova):
Won't Fix
Bug description:
The _sync_power_states periodic task queries all instances on the
compute host:
https://github.com/openstack/nova/blob/4ad414f3b1216393301ef268a64e61ca1a3d5be9/nova/compute/manager.py#L6164
Then later it skips any that are in the middle of an operation:
https://github.com/openstack/nova/blob/4ad414f3b1216393301ef268a64e61ca1a3d5be9/nova/compute/manager.py#L6269
We should avoid the roundtrip to the DB and RPC traffic to load up all
of the instances on the compute host that are in the middle of a task
and will just be skipped in code anyway and filter out the instance
list by task_state in the initial DB query.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1572730/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
