Public bug reported: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L877
has _get_power_state in its function in https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1042 then we call it again https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L878 actually there is no state change in _retry_reboot function so we can reuse the state as variable and avoid mock in test ** Affects: nova Importance: Low Assignee: jichenjc (jichenjc) Status: In Progress ** Tags: compute ** Changed in: nova Assignee: (unassigned) => jichenjc (jichenjc) ** Tags added: compute ** Changed in: nova Importance: Undecided => Low -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1589960 Title: avoid one unnecessary _get_power_state call Status in OpenStack Compute (nova): In Progress Bug description: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L877 has _get_power_state in its function in https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1042 then we call it again https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L878 actually there is no state change in _retry_reboot function so we can reuse the state as variable and avoid mock in test To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1589960/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
