Reviewed: https://review.openstack.org/370639
Committed:
https://git.openstack.org/cgit/openstack/neutron/commit/?id=7d2721de1a06ed233c8a2906d14df02ed70c95d9
Submitter: Jenkins
Branch: master
commit 7d2721de1a06ed233c8a2906d14df02ed70c95d9
Author: Thomas Morin <thomas.mo...@orange.com>
Date: Thu Sep 15 11:25:47 2016 +0200
ovs agent, native ARP response: set Eth src/dst
This change adds action to install_arp_responder of native implementation
so that the source and destination MAC addresses of the Ethernet header
are properly set, and now consistent with the ovs-ofctl implementation.
Change-Id: I9a095add42ba5799bd81887f1cbe5507ab9ba48c
Closes-Bug: 1623849
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1623849
Title:
openvswitch native agent, ARP responder response has wrong Eth headers
Status in neutron:
Fix Released
Bug description:
The ovs-ofctl ARP responder implementation (install_arp_responder)
sets the correct src/dst MAC addresses in the Ethernet header:
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/ovs_ofctl/br_tun.py#L197
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py#L110
--> 'move:NXM_OF_ETH_SRC[]->NXM_OF_ETH_DST[],mod_dl_src:%(mac)s,'
*However* the native Openflow/ryu install_arp_responder implementation
does not set these src/dst fields of the Ethernet header:
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_tun.py#L223
The result is that the forged ARP response is incorrect arp_responder=True
and of_interface=native:
09:59:47.162196 fa:16:3e:ea:2e:9a > ff:ff:ff:ff:ff:ff, ethertype ARP
(0x0806), length 42: Request who-has 192.168.10.1 tell 192.168.10.5, length 28
09:59:47.162426 fa:16:3e:ea:2e:9a > ff:ff:ff:ff:ff:ff, ethertype ARP
(0x0806), length 42: Reply 192.168.10.1 is-at fa:16:5e:47:33:64, length 28
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1623849/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
