[Yahoo-eng-team] [Bug 1788527] Re: Redundant instance group lookup during scheduling of move operations
** Changed in: nova/rocky Status: In Progress => Confirmed ** Changed in: nova/rocky Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1788527 Title: Redundant instance group lookup during scheduling of move operations Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) rocky series: Won't Fix Status in OpenStack Compute (nova) stein series: Fix Committed Bug description: This change: https://github.com/openstack/nova/commit/459ca56de2366aea53efc9ad3295fdf4ddcd452c Added code to the setup_instance_group flow to get the instance group fresh so we had the latest hosts for members of the group. Then change: https://github.com/openstack/nova/commit/94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1 #diff-cbbdc4d7c140314a7e0b2d97ebcd1f9c Was added to not persist group hosts/members in the RequestSpec since they could be stale after the initial server create. This means when we move a server (evacuate, resize, unshelve, live migrate), we get the request spec with the group plus the current hosts/members of the group. So if the request spec has the group hosts set by the time it gets to setup_instance_group, the call in _get_group_details to get the group fresh is redundant. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1788527/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1788527] Re: Redundant instance group lookup during scheduling of move operations
** Also affects: nova/rocky Importance: Undecided Status: New ** Changed in: nova/rocky Status: New => In Progress ** Changed in: nova/rocky Assignee: (unassigned) => Balazs Gibizer (balazs-gibizer) ** Changed in: nova/rocky Importance: Undecided => Low -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1788527 Title: Redundant instance group lookup during scheduling of move operations Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) rocky series: In Progress Status in OpenStack Compute (nova) stein series: Fix Committed Bug description: This change: https://github.com/openstack/nova/commit/459ca56de2366aea53efc9ad3295fdf4ddcd452c Added code to the setup_instance_group flow to get the instance group fresh so we had the latest hosts for members of the group. Then change: https://github.com/openstack/nova/commit/94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1 #diff-cbbdc4d7c140314a7e0b2d97ebcd1f9c Was added to not persist group hosts/members in the RequestSpec since they could be stale after the initial server create. This means when we move a server (evacuate, resize, unshelve, live migrate), we get the request spec with the group plus the current hosts/members of the group. So if the request spec has the group hosts set by the time it gets to setup_instance_group, the call in _get_group_details to get the group fresh is redundant. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1788527/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1788527] Re: Redundant instance group lookup during scheduling of move operations
** Also affects: nova/stein Importance: Undecided Status: New ** Changed in: nova/stein Status: New => In Progress ** Changed in: nova/stein Importance: Undecided => Low ** Changed in: nova/stein Assignee: (unassigned) => Balazs Gibizer (balazs-gibizer) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1788527 Title: Redundant instance group lookup during scheduling of move operations Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) stein series: In Progress Bug description: This change: https://github.com/openstack/nova/commit/459ca56de2366aea53efc9ad3295fdf4ddcd452c Added code to the setup_instance_group flow to get the instance group fresh so we had the latest hosts for members of the group. Then change: https://github.com/openstack/nova/commit/94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1 #diff-cbbdc4d7c140314a7e0b2d97ebcd1f9c Was added to not persist group hosts/members in the RequestSpec since they could be stale after the initial server create. This means when we move a server (evacuate, resize, unshelve, live migrate), we get the request spec with the group plus the current hosts/members of the group. So if the request spec has the group hosts set by the time it gets to setup_instance_group, the call in _get_group_details to get the group fresh is redundant. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1788527/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1788527] Re: Redundant instance group lookup during scheduling of move operations
Reviewed: https://review.opendev.org/665954 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f108d7967636ec1afceff0be386da15d70e2ca37 Submitter: Zuul Branch:master commit f108d7967636ec1afceff0be386da15d70e2ca37 Author: Balazs Gibizer Date: Tue Jun 18 13:17:27 2019 +0200 Remove redundant group host setup It seems that all the code path that ends up calling [1] goes through [2] before so setting up group host at [1] is redundant. [1] https://github.com/openstack/nova/blob/c7e9e667426a6d88d396a59cb40d30763a3265f9/nova/scheduler/utils.py#L944-L950 [2] https://github.com/openstack/nova/blob/c7e9e667426a6d88d396a59cb40d30763a3265f9/nova/scheduler/utils.py#L996-L1000 Change-Id: I745aecb008f0867fcda2d3d2c7691621dd8f6168 Closes-Bug: #1788527 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1788527 Title: Redundant instance group lookup during scheduling of move operations Status in OpenStack Compute (nova): Fix Released Bug description: This change: https://github.com/openstack/nova/commit/459ca56de2366aea53efc9ad3295fdf4ddcd452c Added code to the setup_instance_group flow to get the instance group fresh so we had the latest hosts for members of the group. Then change: https://github.com/openstack/nova/commit/94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1 #diff-cbbdc4d7c140314a7e0b2d97ebcd1f9c Was added to not persist group hosts/members in the RequestSpec since they could be stale after the initial server create. This means when we move a server (evacuate, resize, unshelve, live migrate), we get the request spec with the group plus the current hosts/members of the group. So if the request spec has the group hosts set by the time it gets to setup_instance_group, the call in _get_group_details to get the group fresh is redundant. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1788527/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
