Reviewed: https://review.openstack.org/627045
Committed:
https://git.openstack.org/cgit/openstack/horizon/commit/?id=ccb21ca7a9906523a972e32df904744885183234
Submitter: Zuul
Branch: master
commit ccb21ca7a9906523a972e32df904744885183234
Author: Akihiro Motoki <amot...@gmail.com>
Date: Sun Dec 23 00:36:44 2018 +0900
python3: Fix handling of other protocol in SG rule
In python3 we cannot compare None with an integer,
while this works in python2.
Change-Id: I1321ea68f08241db377a58ed6a22306c63aba204
Closes-Bug: #1789402
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1789402
Title:
Security group rule - Other protocol
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
Queens, horizon 13.0.1
If try to create rule with other ip protocol then exception rise.
Cause of problem in openstack_dashboard/api/neutron.py
https://github.com/openstack/horizon/blob/841bce062327d70fb834b99bc2f238323e400a51/openstack_dashboard/api/neutron.py#L418-L441
If we define ip_protocol it mean that we didn't define to_port and from_port.
It means that comparison default values of to_port/from_port(None) with 0
will rise exception.
It can be fixed with something like this:
if not cidr:
cidr = None
+ if from_port != None:
if from_port < 0:
from_port = None
+ if to_port != None:
if to_port < 0:
to_port = None
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1789402/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
