Reviewed: https://review.opendev.org/684397
Committed:
https://git.openstack.org/cgit/openstack/keystone/commit/?id=6525203c1af9ecdf7c23af3f25e45f0db9f6fed2
Submitter: Zuul
Branch: master
commit 6525203c1af9ecdf7c23af3f25e45f0db9f6fed2
Author: Gage Hugo <gageh...@gmail.com>
Date: Tue Sep 24 11:34:37 2019 -0500
Change time faking for totp test
This change moves the time mocking from using freezegun to
using oslo.utils TimeFixture for the unit test
test_with_passcode_in_previous_windows_extended, which was
occasionally failing with 401 errors due to
the totp creation time not properly be faked with
4 extended windows.
Closes-Bug: #1843464
Change-Id: I3aefd99907fbc2d03538c9814f7279b282715679
** Changed in: keystone
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1843464
Title:
TOTP previous windows passcode test fails intermittently
Status in OpenStack Identity (keystone):
Fix Released
Bug description:
The
keystone.tests.unit.test_v3_auth.TestAuthTOTP.test_with_passcode_in_previous_windows_extended
test fails in CI occasionally, with traceback:
Traceback (most recent call last):
File
"/home/zuul/src/opendev.org/openstack/keystone/keystone/tests/unit/test_v3_auth.py",
line 5443, in test_with_passcode_in_previous_windows_extended
self.v3_create_token(auth_data, expected_status=http_client.CREATED)
File
"/home/zuul/src/opendev.org/openstack/keystone/keystone/tests/unit/test_v3.py",
line 448, in v3_create_token
expected_status=expected_status)
File
"/home/zuul/src/opendev.org/openstack/keystone/keystone/tests/unit/rest.py",
line 211, in admin_request
return self._request(app=self.public_app, **kwargs)
File
"/home/zuul/src/opendev.org/openstack/keystone/keystone/tests/unit/rest.py",
line 200, in _request
response = self.restful_request(**kwargs)
File
"/home/zuul/src/opendev.org/openstack/keystone/keystone/tests/unit/rest.py",
line 185, in restful_request
**kwargs)
File
"/home/zuul/src/opendev.org/openstack/keystone/keystone/tests/unit/rest.py",
line 89, in request
**kwargs)
File
"/home/zuul/src/opendev.org/openstack/keystone/.tox/py36/lib/python3.6/site-packages/webtest/app.py",
line 589, in request
expect_errors=expect_errors,
File
"/home/zuul/src/opendev.org/openstack/keystone/.tox/py36/lib/python3.6/site-packages/webtest/app.py",
line 654, in do_request
self._check_status(status, res)
File
"/home/zuul/src/opendev.org/openstack/keystone/.tox/py36/lib/python3.6/site-packages/webtest/app.py",
line 689, in _check_status
"Bad response: %s (not %s)\n%s", res_status, status, res)
webtest.app.AppError: Bad response: 401 UNAUTHORIZED (not HTTPStatus.CREATED)
b'{"error":{"code":401,"message":"The request you have made requires
authentication.","title":"Unauthorized"}}\n'
Example failure:
https://bb58e5c931fd1f60f908-f87a01575e4cebb7b630bab88ef312d9.ssl.cf1.rackcdn.com/681161/1/check
/openstack-tox-py36/922e3ff/testr_results.html.gz
Seems like perhaps the freezegun functionality isn't working as
expected.
To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1843464/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
