[Yahoo-eng-team] [Bug 1394299] Re: Shared image shows as private
Reviewed: https://review.openstack.org/369110 Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=265659e8c34865331568b069fdb27ea272df4eaa Submitter: Jenkins Branch:master commit 265659e8c34865331568b069fdb27ea272df4eaa Author: Timothy SymanczykDate: Sat Sep 3 07:57:50 2016 -0700 Implement and Enable Community Images This change replaces the existing boolean 'is_public' column for the 'images' table with enum 'visibility' column featuring the four explicit visibility values - public, private, shared, and community. This change also implements and enables all backend code to utilize the new values. Co-Authored-By: Timothy Symanczyk Co-Authored-By: Dharini Chandrasekar Implements: blueprint community-level-v2-image-sharing Closes-Bug: #1394299 Closes-Bug: #1452443 Depends-On: I6e3268f3712cbc0aadb51d204c694023b92d55a5 Change-Id: I94bc7708b291ce37319539e27b3e88c9a17e1a9f ** Changed in: glance Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1394299 Title: Shared image shows as private Status in Glance: Fix Released Bug description: image 281d576a-9e4b-4d11-94bb-8b1e89f62a71 is owned by this user and correctly shows as 'private', however image '795518ca- 13a6-4493-b3a3-91519ad7c067' is not owned by this user, it is a shared image. $ glance --os-image-api-version 2 image-list --visibility shared +--+-+ | ID| Name| +--+-+ | 795518ca-13a6-4493-b3a3-91519ad7c067 | accepted--image | <<< correct, the shared image is shown +--+-+ $ glance --os-image-api-version 2 image-list --visibility private +--+-+ | ID | Name| +--+-+ | 281d576a-9e4b-4d11-94bb-8b1e89f62a71 | private-image | | 795518ca-13a6-4493-b3a3-91519ad7c067 | accepted--image | <<< wrong, I think, this is shared, not private +--+-+ $ glance --os-image-api-version 2 image-show 281d576a-9e4b-4d11-94bb-8b1e89f62a71 +--+--+ | Property | Value| +--+--+ | checksum | 398759a311bf25c6f1d67e753bb24dae | | container_format | bare | | created_at | 2014-11-18T11:16:33Z | | disk_format | raw | | id | 281d576a-9e4b-4d11-94bb-8b1e89f62a71 | | min_disk | 0| | min_ram | 0| | name | private-image| | owner| f68be3a5c2b14721a9e0ed2fcb750481 | | protected| False| | size | 106 | | status | active | | tags | [] | | updated_at | 2014-11-18T15:51:35Z | | visibility | private | <<< correct +--+--+ (py27)ubuntu in ~/git/python-glanceclient on master* $ glance --os-image-api-version 2 image-show 795518ca-13a6-4493-b3a3-91519ad7c067 +--+--+ | Property | Value| +--+--+ | checksum | 398759a311bf25c6f1d67e753bb24dae | | container_format | bare | | created_at | 2014-11-18T11:14:58Z | | disk_format | raw | | id | 795518ca-13a6-4493-b3a3-91519ad7c067 | | min_disk | 0| | min_ram | 0| | name | accepted--image | | owner| 2dcea26aa97a41fa9547a133f6c7f5b4 | <<< different owner | protected| False| | size | 106 | | status | active | | tags | []
[Yahoo-eng-team] [Bug 1394299] Re: Shared image shows as private
** Changed in: glance Status: Invalid => In Progress ** Changed in: glance Importance: Medium => Critical ** Changed in: glance Assignee: (unassigned) => Dharini Chandrasekar (dharini-chandrasekar) ** Changed in: glance Milestone: None => ocata-3 -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1394299 Title: Shared image shows as private Status in Glance: In Progress Bug description: image 281d576a-9e4b-4d11-94bb-8b1e89f62a71 is owned by this user and correctly shows as 'private', however image '795518ca- 13a6-4493-b3a3-91519ad7c067' is not owned by this user, it is a shared image. $ glance --os-image-api-version 2 image-list --visibility shared +--+-+ | ID| Name| +--+-+ | 795518ca-13a6-4493-b3a3-91519ad7c067 | accepted--image | <<< correct, the shared image is shown +--+-+ $ glance --os-image-api-version 2 image-list --visibility private +--+-+ | ID | Name| +--+-+ | 281d576a-9e4b-4d11-94bb-8b1e89f62a71 | private-image | | 795518ca-13a6-4493-b3a3-91519ad7c067 | accepted--image | <<< wrong, I think, this is shared, not private +--+-+ $ glance --os-image-api-version 2 image-show 281d576a-9e4b-4d11-94bb-8b1e89f62a71 +--+--+ | Property | Value| +--+--+ | checksum | 398759a311bf25c6f1d67e753bb24dae | | container_format | bare | | created_at | 2014-11-18T11:16:33Z | | disk_format | raw | | id | 281d576a-9e4b-4d11-94bb-8b1e89f62a71 | | min_disk | 0| | min_ram | 0| | name | private-image| | owner| f68be3a5c2b14721a9e0ed2fcb750481 | | protected| False| | size | 106 | | status | active | | tags | [] | | updated_at | 2014-11-18T15:51:35Z | | visibility | private | <<< correct +--+--+ (py27)ubuntu in ~/git/python-glanceclient on master* $ glance --os-image-api-version 2 image-show 795518ca-13a6-4493-b3a3-91519ad7c067 +--+--+ | Property | Value| +--+--+ | checksum | 398759a311bf25c6f1d67e753bb24dae | | container_format | bare | | created_at | 2014-11-18T11:14:58Z | | disk_format | raw | | id | 795518ca-13a6-4493-b3a3-91519ad7c067 | | min_disk | 0| | min_ram | 0| | name | accepted--image | | owner| 2dcea26aa97a41fa9547a133f6c7f5b4 | <<< different owner | protected| False| | size | 106 | | status | active | | tags | [] | | updated_at | 2014-11-19T16:32:33Z | | visibility | private | <<< wrong, I think +--+--+ To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1394299/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
[Yahoo-eng-team] [Bug 1394299] Re: Shared image shows as private
Until Ocata, there were only two image visibility values: 'private' and 'public'. Thus a shared image had visibility 'private' because it was not a public image. The confusing aspect is that the image-list filter in the Image API v2 that's used to list shared images is: GET v2/images?visibility=shared ... but none of the images in that list actually had 'visibility' == 'shared'. This is being changed in Ocata. As part of the community images implementation, the values for 'visibility' are being expanded to {'public', 'private', 'shared', 'community'}. So with the Ocata release, the visibility of a shared image will be 'shared'. ** Changed in: glance Status: In Progress => Invalid ** Changed in: glance Assignee: Kanchan Gupta (kanchan-gupta1) => (unassigned) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1394299 Title: Shared image shows as private Status in Glance: Invalid Bug description: image 281d576a-9e4b-4d11-94bb-8b1e89f62a71 is owned by this user and correctly shows as 'private', however image '795518ca- 13a6-4493-b3a3-91519ad7c067' is not owned by this user, it is a shared image. $ glance --os-image-api-version 2 image-list --visibility shared +--+-+ | ID| Name| +--+-+ | 795518ca-13a6-4493-b3a3-91519ad7c067 | accepted--image | <<< correct, the shared image is shown +--+-+ $ glance --os-image-api-version 2 image-list --visibility private +--+-+ | ID | Name| +--+-+ | 281d576a-9e4b-4d11-94bb-8b1e89f62a71 | private-image | | 795518ca-13a6-4493-b3a3-91519ad7c067 | accepted--image | <<< wrong, I think, this is shared, not private +--+-+ $ glance --os-image-api-version 2 image-show 281d576a-9e4b-4d11-94bb-8b1e89f62a71 +--+--+ | Property | Value| +--+--+ | checksum | 398759a311bf25c6f1d67e753bb24dae | | container_format | bare | | created_at | 2014-11-18T11:16:33Z | | disk_format | raw | | id | 281d576a-9e4b-4d11-94bb-8b1e89f62a71 | | min_disk | 0| | min_ram | 0| | name | private-image| | owner| f68be3a5c2b14721a9e0ed2fcb750481 | | protected| False| | size | 106 | | status | active | | tags | [] | | updated_at | 2014-11-18T15:51:35Z | | visibility | private | <<< correct +--+--+ (py27)ubuntu in ~/git/python-glanceclient on master* $ glance --os-image-api-version 2 image-show 795518ca-13a6-4493-b3a3-91519ad7c067 +--+--+ | Property | Value| +--+--+ | checksum | 398759a311bf25c6f1d67e753bb24dae | | container_format | bare | | created_at | 2014-11-18T11:14:58Z | | disk_format | raw | | id | 795518ca-13a6-4493-b3a3-91519ad7c067 | | min_disk | 0| | min_ram | 0| | name | accepted--image | | owner| 2dcea26aa97a41fa9547a133f6c7f5b4 | <<< different owner | protected| False| | size | 106 | | status | active | | tags | [] | | updated_at | 2014-11-19T16:32:33Z | | visibility | private | <<< wrong, I think +--+--+ To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1394299/+subscriptions -- Mailing list: