Public bug reported:

For a new device, when set security group for it, function
prepare_port_filter will be called. Then
self._enable_netfilter_for_bridges() will be executed once, which is not
needed every time.

    def prepare_port_filter(self, port):
        LOG.debug("Preparing device (%s) filter", port['device'])
        self._remove_chains()
        self._set_ports(port)
        self._enable_netfilter_for_bridges()
        # each security group has it own chains
        self._setup_chains()
        return self.iptables.apply()

We could have a look at _enabled_netfilter_for_bridges first and decide
whether to run self._enable_netfilter_for_bridges().

** Affects: neutron
     Importance: Undecided
     Assignee: yujie (16189455-d)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => yujie (16189455-d)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1624648

Title:
  Do not need run _enable_netfilter_for_bridges() for each new device

Status in neutron:
  New

Bug description:
  For a new device, when set security group for it, function
  prepare_port_filter will be called. Then
  self._enable_netfilter_for_bridges() will be executed once, which is
  not needed every time.

      def prepare_port_filter(self, port):
          LOG.debug("Preparing device (%s) filter", port['device'])
          self._remove_chains()
          self._set_ports(port)
          self._enable_netfilter_for_bridges()
          # each security group has it own chains
          self._setup_chains()
          return self.iptables.apply()

  We could have a look at _enabled_netfilter_for_bridges first and
  decide whether to run self._enable_netfilter_for_bridges().

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1624648/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to     : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to