Reviewed: https://review.openstack.org/525842 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2200b1c3697a478af9f25a20ce09564bc2c9a968 Submitter: Zuul Branch: master
commit 2200b1c3697a478af9f25a20ce09564bc2c9a968 Author: zhsun <zh...@fiberhome.com> Date: Wed Dec 6 08:53:55 2017 +0800 Add/rm centralized fips for DVR+HA from standby node For DVR+HA: When adding/removing a centralized fip, just add/remove it to/from keepalived instance and do not check if it is a master router. When adding a centralized fip, it is still needed to invoke method of supperclass to configure nat rules on master node. When removing a centralized fip, it is still needed to invoke method of supperclass to clean contrack on master node. Change-Id: I202db59acb7fb0b7924748cf7def2879a748e56a Closes-Bug: #1736068 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1736068 Title: DVR lost centralized floating ip when the ha state switched. Status in neutron: Fix Released Bug description: Reproduction steps: The l3 agent mode is as follows: Network:dvr_snat Compute:dvr_no_external 1、Create a DVR(HA). Then add interface and gateway to the DVR. 2、Create a vm and associate a floating ip to the vm. 3、Check the keepalived.conf and snat ns on the master and backup network nodes for the DVR. 4、The floating ip can be found in the keepalived.conf on the master network node but not in the keepalived.conf on the backup network node for the DVR .On the master network node for the DVR , the floating ip is found normal in the snat ns. 5.Swith the ha state of the DVR, Check the keepalived.conf and snat ns on the current master network node for the DVR. 6.The floating ip still can not be found in the keepalived.conf on the current master network node. And on the current master network node for the DVR , the floating ip is not found in the snat ns. Mybe the check for the router ha state[1] should be moved just before [2]. [1]https://github.com/openstack/neutron/blob/master/neutron/agent/l3/dvr_edge_ha_router.py#L61 [2]https://github.com/openstack/neutron/blob/master/neutron/agent/l3/dvr_edge_ha_router.py#L65 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1736068/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp