Reviewed: https://review.openstack.org/543571
Committed:
https://git.openstack.org/cgit/openstack/nova/commit/?id=db686fe1856456e5e1486f0935aa4426c805520f
Submitter: Zuul
Branch: master
commit db686fe1856456e5e1486f0935aa4426c805520f
Author: esberglu <esber...@us.ibm.com>
Date: Mon Feb 12 12:18:57 2018 -0600
Use correct arguments in task inits
The CreateAndConnectCfgDrive and DeleteVOpt tasks were passing the
instance into the task.Task init as the first argument. The first arg
for the Task init is actually the task name [1]. This means that those
task names were string representations of the instance which will cause
failures if there are any non-ascii characters. This corrects the Task
init calls by removing instance as the first argument. The name kwarg
is now being used throughout the PowerVM tasks to avoid similar issues
in the future.
[1] https://github.com/openstack/taskflow/blob/3.1.0/taskflow/task.py#L62
Change-Id: I991a5ea33daa9a21f774fe24882ed40f990b8e0e
Closes-Bug: #1748950
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1748950
Title:
PowerVM driver passing bad kwargs into Task init method
Status in OpenStack Compute (nova):
Fix Released
Bug description:
The PowerVM virt driver is passing the instance as the first argument
to the Task init in a few places [1] [2]. The init method [3] expects
the first arg to be the task name. This results in the task name being
the string representation of the instance. The instance should no
longer be passed into the Task init and the task names should be
passed to the init using the name kwarg.
This doesn't break the typical flows, however if the instance has any
non-ascii characters in the string representation, the task will fail
to compile.
This affects queens and master branches using the PowerVM virt driver.
[1]
https://github.com/openstack/nova/blob/17.0.0.0rc1/nova/virt/powervm/tasks/storage.py#L160
[2]
https://github.com/openstack/nova/blob/17.0.0.0rc1/nova/virt/powervm/tasks/storage.py#L200
[3] https://github.com/openstack/taskflow/blob/3.1.0/taskflow/task.py#L62
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1748950/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
