Reviewed: https://review.openstack.org/558430
Committed:
https://git.openstack.org/cgit/openstack/horizon/commit/?id=d0beeb7e142197152925b9c257a2e4f402ac9fb2
Submitter: Zuul
Branch: master
commit d0beeb7e142197152925b9c257a2e4f402ac9fb2
Author: Shu Muto <shu.mu...@gmail.com>
Date: Tue Apr 3 17:40:27 2018 +0900
Pass whole selected entity to deleteEntity callback
For now, delete-modal service passes only ID to deleteEntity callback.
Some plugins need other parameters to delete entity.
So this patch passes whole selected entity to callback as second argument.
Change-Id: I395470110a5f03ebb08a043ca433b16b999dad3f
Needed-By: Ic5aba9b2e953cde7950ae7656cd5a3fee3f4a55c
Closes-Bug: #1761074
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1761074
Title:
delete-modal passes only ID to callback
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
Angular-based dialog for confirming deletion passes only ID to
callback in deletion action service of each panel.
If the API does not accept ID on deletion or other operations, e.g.
quota management on magnum API that needs composite key with
project_id and resource, the panel needs to retrieve list and to
filter by ID on callback. So passing a whole object makes sense.
To enable to pass whole entity of selected item, we can pass it as
second parameter for callback.
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1761074/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
