fanshilun created YARN-11334: -------------------------------- Summary: improve SubClusterState#fromString parameter and LogMessage Key: YARN-11334 URL: https://issues.apache.org/jira/browse/YARN-11334 Project: Hadoop YARN Issue Type: Improvement Components: federation Affects Versions: 3.4.0 Reporter: fanshilun Assignee: fanshilun
The SubClusterState object has a fromString method, which can be improved in the following 2 places {code:java} /** * Convert a string into {@code SubClusterState}. * * @param x the string to convert in SubClusterState * @return the respective {@code SubClusterState} */ public static SubClusterState fromString(String x) { try { return SubClusterState.valueOf(x); } catch (Exception e) { LOG.error("Invalid SubCluster State value in the StateStore does not" + " match with the YARN Federation standard."); return null; } } {code} * The parameter is named x, which cannot well express the meaning of the input parameter. * The error log does not print the error value. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-dev-h...@hadoop.apache.org