Re: [Discuss] Merge YARN-3368 to trunk

2016-10-24 Thread Rohith Sharma K S
Thanks Wangda and all other contributors to new YarnWeb UI work. I am able to built and deploy the Yarn WebUI from branch YARN-3368. The look and feel of UI is pretty much impressive. The new web UI hosted along with same http port of existing web UI. I could able to navigate all the tabs such as

Re: [Discuss] Merge YARN-3368 to trunk

2016-10-24 Thread Sreenath Somarajapuram
Tried the UI. +1 LGTM Thanks, - Sreenath On 10/24/16, 11:19 AM, "Sunil Govind" wrote: >Thanks Wangda for starting the thread. > >Tested latest patch against trunk. UI looks good. +1 for the merge. > >+ Sunil > >On Wed, Oct 19, 2016 at 5:16 AM Wangda Tan

Re: [Discuss] Merge YARN-3368 to trunk

2016-10-23 Thread Sunil Govind
Thanks Wangda for starting the thread. Tested latest patch against trunk. UI looks good. +1 for the merge. + Sunil On Wed, Oct 19, 2016 at 5:16 AM Wangda Tan wrote: > YARN Devs, > > *Updates since Sep 22, 2016:* > > We sent a merge YARN-3368 discussion email on Sep 22,

Re: [Discuss] Merge YARN-3368 to trunk

2016-10-21 Thread Li Lu
Thanks Wangda and all contributors to the new UI work. This is great! As Wangda mentioned in the mail, the ongoing work of timeline service v2 works with the new UI framework. Besides other significant benefits, merging YARN-3368 back to trunk can greatly simplify the development process of

Re: [Discuss] Merge YARN-3368 to trunk

2016-09-22 Thread Wangda Tan
On Thu, Sep 22, 2016 at 2:01 PM, Allen Wittenauer wrote: > > > On Sep 22, 2016, at 1:24 PM, Wangda Tan wrote: > > Actually I'm not trying to debate about if it is necessary to make the > UI project following Hadoop's rules. The answer is always

Re: [Discuss] Merge YARN-3368 to trunk

2016-09-22 Thread Allen Wittenauer
> On Sep 22, 2016, at 1:24 PM, Wangda Tan wrote: > Actually I'm not trying to debate about if it is necessary to make the UI > project following Hadoop's rules. The answer is always yes to me: we should > follow Hadoop's guide for any of sub project. We're trying to make

Re: [Discuss] Merge YARN-3368 to trunk

2016-09-22 Thread Wangda Tan
Hi Allen, Thanks again for replying, see replies inline. On Thu, Sep 22, 2016 at 11:52 AM, Allen Wittenauer wrote: > > > On Sep 22, 2016, at 11:13 AM, Wangda Tan wrote: > > >* why are there editor settings and other superfluous things there?

Re: [Discuss] Merge YARN-3368 to trunk

2016-09-22 Thread Allen Wittenauer
> On Sep 22, 2016, at 11:13 AM, Wangda Tan wrote: > >* why are there editor settings and other superfluous things there? do > >these settings comply with the PMC's style guide? why would they be here > >and not in the base of the source tree? > Actually many front-end

Re: [Discuss] Merge YARN-3368 to trunk

2016-09-22 Thread Wangda Tan
Hi Allen, Thanks for your valuable comments, (BTW your new email address is automatically categorized to spam by Gmail. Gmail noticed the email address cannot be verified.) Please see my responses inline: On Tue, Sep 20, 2016 at 2:56 PM, Allen Wittenauer wrote: >

Re: [Discuss] Merge YARN-3368 to trunk

2016-09-20 Thread Allen Wittenauer
On 2016-09-09 15:54 (-0700), Wangda Tan wrote: > We propose to merge YARN-3368 (YARN next generation web UI) development > branch into trunk for better development, would like to hear your thoughts > before sending out vote mail. > A quick pass through the diff: * why are

Re: [Discuss] Merge YARN-3368 to trunk

2016-09-20 Thread Sunil Govind
Thank You Wangda for driving the proposal. I had taken the branch code and applied against trunk. Also verified basic operations in all pages. Looks fine to me for now. I am fine in merging the new UI base to trunk. Thanks, Sunil On Sat, Sep 10, 2016 at 4:25 AM Wangda Tan