[jira] [Commented] (YARN-8648) Container cgroups are leaked when using docker

2018-08-29 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596345#comment-16596345 ] Jim Brennan commented on YARN-8648: --- Looks like this is ready for review.   > Container cgroups are

[jira] [Updated] (YARN-8648) Container cgroups are leaked when using docker

2018-08-28 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8648: -- Attachment: YARN-8648.001.patch > Container cgroups are leaked when using docker >

[jira] [Commented] (YARN-8675) Setting hostname of docker container breaks with "host" networking mode for Apps which do not run as a YARN service

2018-08-24 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592244#comment-16592244 ] Jim Brennan commented on YARN-8675: --- [~suma.shivaprasad] thanks for updating.  Patch 3 looks good to me.

[jira] [Commented] (YARN-8675) Setting hostname of docker container breaks with "host" networking mode for Apps which do not run as a YARN service

2018-08-24 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592142#comment-16592142 ] Jim Brennan commented on YARN-8675: --- [~suma.shivaprasad] Thanks for working on this.  I am still not

[jira] [Commented] (YARN-8648) Container cgroups are leaked when using docker

2018-08-20 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586060#comment-16586060 ] Jim Brennan commented on YARN-8648: --- Thanks [~eyang]!  My main concern about the minimal fix is the

[jira] [Commented] (YARN-8648) Container cgroups are leaked when using docker

2018-08-17 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584479#comment-16584479 ] Jim Brennan commented on YARN-8648: --- I have been experimenting with the following incomplete approach:

[jira] [Commented] (YARN-6495) check docker container's exit code when writing to cgroup task files

2018-08-17 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584038#comment-16584038 ] Jim Brennan commented on YARN-6495: --- YARN-8656 removed the code that this Jira was fixing. I think we

[jira] [Updated] (YARN-8640) Restore previous state in container-executor after failure

2018-08-17 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8640: -- Attachment: YARN-8640-branch-2.8.002.patch YARN-8640-branch-2.7.002.patch > Restore

[jira] [Commented] (YARN-8640) Restore previous state in container-executor after failure

2018-08-17 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584024#comment-16584024 ] Jim Brennan commented on YARN-8640: --- [~jlowe], thanks for the review!  I have removed the changes to

[jira] [Commented] (YARN-8640) Restore previous state in container-executor after failure

2018-08-16 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583053#comment-16583053 ] Jim Brennan commented on YARN-8640: --- [~jlowe]  I'm not sure what happened here with genericqa?   >

[jira] [Commented] (YARN-8656) container-executor should not write cgroup tasks files for docker containers

2018-08-15 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581110#comment-16581110 ] Jim Brennan commented on YARN-8656: --- I am unable to repro the unit test failure in 

[jira] [Updated] (YARN-8656) container-executor should not write cgroup tasks files for docker containers

2018-08-14 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8656: -- Attachment: YARN-8656.002.patch > container-executor should not write cgroup tasks files for docker

[jira] [Updated] (YARN-8640) Restore previous state in container-executor after failure

2018-08-14 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8640: -- Attachment: YARN-8640-branch-2.8.001.patch YARN-8640-branch-2.7.001.patch > Restore

[jira] [Reopened] (YARN-8640) Restore previous state in container-executor after failure

2018-08-14 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan reopened YARN-8640: --- Reopening so I can provide patches for branch-2.7 and branch-2.8. > Restore previous state in

[jira] [Commented] (YARN-8648) Container cgroups are leaked when using docker

2018-08-14 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580234#comment-16580234 ] Jim Brennan commented on YARN-8648: --- {quote}I am wondering if this approach would break the docker

[jira] [Commented] (YARN-8648) Container cgroups are leaked when using docker

2018-08-14 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580067#comment-16580067 ] Jim Brennan commented on YARN-8648: --- [~jlowe] thanks for the comment. {quote}We should consider breaking

[jira] [Commented] (YARN-8656) container-executor should not write cgroup tasks files for docker containers

2018-08-14 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579978#comment-16579978 ] Jim Brennan commented on YARN-8656: --- I have tested this by running test-container-executor, cetest, and

[jira] [Updated] (YARN-8656) container-executor should not write cgroup tasks files for docker containers

2018-08-14 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8656: -- Attachment: YARN-8656.001.patch > container-executor should not write cgroup tasks files for docker

[jira] [Commented] (YARN-6495) check docker container's exit code when writing to cgroup task files

2018-08-13 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578844#comment-16578844 ] Jim Brennan commented on YARN-6495: --- {quote}My proposal would be to remove this code as part of 

[jira] [Assigned] (YARN-8656) container-executor should not write cgroup tasks files for docker containers

2018-08-13 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan reassigned YARN-8656: - Assignee: Jim Brennan > container-executor should not write cgroup tasks files for docker

[jira] [Created] (YARN-8656) container-executor should not write cgroup tasks files for docker containers

2018-08-13 Thread Jim Brennan (JIRA)
Jim Brennan created YARN-8656: - Summary: container-executor should not write cgroup tasks files for docker containers Key: YARN-8656 URL: https://issues.apache.org/jira/browse/YARN-8656 Project: Hadoop

[jira] [Commented] (YARN-8640) Restore previous state in container-executor if write_exit_code_file_as_nm fails

2018-08-13 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578547#comment-16578547 ] Jim Brennan commented on YARN-8640: --- Tested by running test-container-executor and cetest - both pass

[jira] [Commented] (YARN-6495) check docker container's exit code when writing to cgroup task files

2018-08-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576925#comment-16576925 ] Jim Brennan commented on YARN-6495: --- As part of YARN-8648, I am proposing that we can just remove the

[jira] [Commented] (YARN-8648) Container cgroups are leaked when using docker

2018-08-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576916#comment-16576916 ] Jim Brennan commented on YARN-8648: --- One proposal to fix the leaking cgroups is to have docker put its

[jira] [Comment Edited] (YARN-8648) Container cgroups are leaked when using docker

2018-08-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576855#comment-16576855 ] Jim Brennan edited comment on YARN-8648 at 8/10/18 9:37 PM: Another problem we

[jira] [Commented] (YARN-8648) Container cgroups are leaked when using docker

2018-08-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576855#comment-16576855 ] Jim Brennan commented on YARN-8648: --- Another problem we have seen is that container-executor still has

[jira] [Updated] (YARN-8648) Container cgroups are leaked when using docker

2018-08-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8648: -- Labels: Docker (was: ) > Container cgroups are leaked when using docker >

[jira] [Created] (YARN-8648) Container cgroups are leaked when using docker

2018-08-10 Thread Jim Brennan (JIRA)
Jim Brennan created YARN-8648: - Summary: Container cgroups are leaked when using docker Key: YARN-8648 URL: https://issues.apache.org/jira/browse/YARN-8648 Project: Hadoop YARN Issue Type: Bug

[jira] [Updated] (YARN-8640) Restore previous state in container-executor if write_exit_code_file_as_nm fails

2018-08-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8640: -- Attachment: YARN-8640.001.patch > Restore previous state in container-executor if

[jira] [Created] (YARN-8640) Restore previous state in container-executor if write_exit_code_file_as_nm fails

2018-08-09 Thread Jim Brennan (JIRA)
Jim Brennan created YARN-8640: - Summary: Restore previous state in container-executor if write_exit_code_file_as_nm fails Key: YARN-8640 URL: https://issues.apache.org/jira/browse/YARN-8640 Project:

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542171#comment-16542171 ] Jim Brennan commented on YARN-8518: --- [~rkanter], can you please review this fix?   >

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541894#comment-16541894 ] Jim Brennan commented on YARN-8518: --- The unit test failure is not related to this change and it looks

[jira] [Commented] (YARN-8515) container-executor can crash with SIGPIPE after nodemanager restart

2018-07-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541868#comment-16541868 ] Jim Brennan commented on YARN-8515: --- The unit test failure is YARN-8518.  Might want to wait for that

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541878#comment-16541878 ] Jim Brennan commented on YARN-8518: --- I can confirm that it is running this test for pre-commit builds -

[jira] [Updated] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8518: -- Attachment: YARN-8518.001.patch > test-container-executor test_is_empty() is broken >

[jira] [Updated] (YARN-8515) container-executor can crash with SIGPIPE after nodemanager restart

2018-07-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8515: -- Attachment: YARN-8515.001.patch > container-executor can crash with SIGPIPE after nodemanager restart >

[jira] [Assigned] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-11 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan reassigned YARN-8518: - Assignee: Jim Brennan > test-container-executor test_is_empty() is broken >

[jira] [Commented] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-11 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540597#comment-16540597 ] Jim Brennan commented on YARN-8518: --- [~rkanter], [~szegedim], let me know if you would like me to put up

[jira] [Created] (YARN-8518) test-container-executor test_is_empty() is broken

2018-07-11 Thread Jim Brennan (JIRA)
Jim Brennan created YARN-8518: - Summary: test-container-executor test_is_empty() is broken Key: YARN-8518 URL: https://issues.apache.org/jira/browse/YARN-8518 Project: Hadoop YARN Issue Type:

[jira] [Commented] (YARN-8515) container-executor can crash with SIGPIPE after nodemanager restart

2018-07-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539290#comment-16539290 ] Jim Brennan commented on YARN-8515: --- I have been able to repro this reliably on a test cluster. Repro

[jira] [Commented] (YARN-8515) container-executor can crash with SIGPIPE after nodemanager restart

2018-07-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539286#comment-16539286 ] Jim Brennan commented on YARN-8515: --- Here is an example case that we saw: Docker ps info for this

[jira] [Created] (YARN-8515) container-executor can crash with SIGPIPE after nodemanager restart

2018-07-10 Thread Jim Brennan (JIRA)
Jim Brennan created YARN-8515: - Summary: container-executor can crash with SIGPIPE after nodemanager restart Key: YARN-8515 URL: https://issues.apache.org/jira/browse/YARN-8515 Project: Hadoop YARN

[jira] [Commented] (YARN-8444) NodeResourceMonitor crashes on bad swapFree value

2018-06-21 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519549#comment-16519549 ] Jim Brennan commented on YARN-8444: --- [~eepayne], can you please review?   > NodeResourceMonitor

[jira] [Commented] (YARN-8444) NodeResourceMonitor crashes on bad swapFree value

2018-06-20 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518616#comment-16518616 ] Jim Brennan commented on YARN-8444: --- I am not able to reproduce the unit test failures locally, and it

[jira] [Updated] (YARN-8444) NodeResourceMonitor crashes on bad swapFree value

2018-06-20 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8444: -- Attachment: YARN-8444.001.patch > NodeResourceMonitor crashes on bad swapFree value >

[jira] [Updated] (YARN-8444) NodeResourceMonitor crashes on bad swapFree value

2018-06-20 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8444: -- Description: Saw this on a node that was running out of memory. Can't have NodeResourceMonitor

[jira] [Commented] (YARN-8444) NodeResourceMonitor crashes on bad swapFree value

2018-06-20 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518171#comment-16518171 ] Jim Brennan commented on YARN-8444: --- The bad value came from /proc/meminfo - it looks like it returned a

[jira] [Created] (YARN-8444) NodeResourceMonitor crashes on bad swapFree value

2018-06-20 Thread Jim Brennan (JIRA)
Jim Brennan created YARN-8444: - Summary: NodeResourceMonitor crashes on bad swapFree value Key: YARN-8444 URL: https://issues.apache.org/jira/browse/YARN-8444 Project: Hadoop YARN Issue Type:

[jira] [Commented] (YARN-8417) Should skip passing HDFS_HOME, HADOOP_CONF_DIR, JAVA_HOME, etc. to Docker container.

2018-06-19 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517531#comment-16517531 ] Jim Brennan commented on YARN-8417: --- Just to clarify - this is only for the ENTRY_POINT case, right? 

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-11 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508198#comment-16508198 ] Jim Brennan commented on YARN-8259: --- I think we should go with Option 1 with documentation to whitelist

[jira] [Commented] (YARN-6919) Add default volume mount list

2018-05-17 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479115#comment-16479115 ] Jim Brennan commented on YARN-6919: --- [~ebadger], thanks for the patch!  Code looks good to me.     >

[jira] [Commented] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-05-16 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477936#comment-16477936 ] Jim Brennan commented on YARN-8071: --- [~jlowe], thanks for the review:   {quote}The changes to

[jira] [Commented] (YARN-8244) TestContainerSchedulerQueuing.testStartMultipleContainers failed

2018-05-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470551#comment-16470551 ] Jim Brennan commented on YARN-8244: --- [~jlowe], I put up another patch that does pretty much what you

[jira] [Updated] (YARN-8244) TestContainerSchedulerQueuing.testStartMultipleContainers failed

2018-05-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8244: -- Attachment: YARN-8244.002.patch > TestContainerSchedulerQueuing.testStartMultipleContainers failed >

[jira] [Commented] (YARN-8244) TestContainerSchedulerQueuing.testStartMultipleContainers failed

2018-05-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469504#comment-16469504 ] Jim Brennan commented on YARN-8244: --- Looking into why the other tests are not failing for me. The

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

2018-05-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469331#comment-16469331 ] Jim Brennan commented on YARN-8206: --- New patch looks good to me. > Sending a kill does not immediately

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

2018-05-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469201#comment-16469201 ] Jim Brennan commented on YARN-8206: --- [~ebadger], patch 7 does not look right...   > Sending a kill does

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

2018-05-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469116#comment-16469116 ] Jim Brennan commented on YARN-8206: --- [~ebadger], thanks for the patch! In handleContainerKill(), you

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-05-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468949#comment-16468949 ] Jim Brennan commented on YARN-7654: --- {quote}docker logs does not seem to separate out stdout from stderr.

[jira] [Commented] (YARN-8244) TestContainerSchedulerQueuing.testStartMultipleContainers failed

2018-05-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468926#comment-16468926 ] Jim Brennan commented on YARN-8244: --- The problem is in the test.  It is using the same

[jira] [Updated] (YARN-8244) TestContainerSchedulerQueuing.testStartMultipleContainers failed

2018-05-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8244: -- Attachment: YARN-8244.001.patch > TestContainerSchedulerQueuing.testStartMultipleContainers failed >

[jira] [Assigned] (YARN-8244) TestContainerSchedulerQueuing.testStartMultipleContainers failed

2018-05-08 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan reassigned YARN-8244: - Assignee: Jim Brennan > TestContainerSchedulerQueuing.testStartMultipleContainers failed >

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

2018-05-08 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467574#comment-16467574 ] Jim Brennan commented on YARN-8206: --- +1 for proposal 2. > Sending a kill does not immediately kill

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-05-01 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460139#comment-16460139 ] Jim Brennan commented on YARN-8207: --- [~eyang], I spent a little time looking at this one today. Didn't

[jira] [Commented] (YARN-8209) NPE in DeletionService

2018-05-01 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459733#comment-16459733 ] Jim Brennan commented on YARN-8209: --- [~ebadger], a few comments: As [~eyang] said,

[jira] [Commented] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-04-30 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458819#comment-16458819 ] Jim Brennan commented on YARN-8071: --- [~jlowe], this is ready to review again. > Add ability to specify

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

2018-04-30 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458694#comment-16458694 ] Jim Brennan commented on YARN-8206: --- [~eyang], [~jlowe], I'm not sure I see the advantage of using the

[jira] [Commented] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-04-30 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458661#comment-16458661 ] Jim Brennan commented on YARN-8071: --- {quote} The original code passed the current environment map,

[jira] [Updated] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-04-30 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8071: -- Attachment: YARN-8071.003.patch > Add ability to specify nodemanager environment variables individually

[jira] [Commented] (YARN-8097) Add support for Docker env-file switch

2018-04-20 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446414#comment-16446414 ] Jim Brennan commented on YARN-8097: --- [~eyang], [~jlowe], [~ebadger], [~shaneku...@gmail.com], my

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-04-20 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446405#comment-16446405 ] Jim Brennan commented on YARN-7654: --- I'm not going to repeat all of the arguments, but I agree with

[jira] [Commented] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-04-16 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439791#comment-16439791 ] Jim Brennan commented on YARN-8071: --- [~jlowe] thanks for the review. {quote}The original code passed the

[jira] [Commented] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-04-13 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437537#comment-16437537 ] Jim Brennan commented on YARN-8071: --- [~jlowe], I believe this patch is ready for review.   > Add

[jira] [Updated] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-04-13 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8071: -- Attachment: YARN-8071.002.patch > Add ability to specify nodemanager environment variables individually

[jira] [Updated] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-04-13 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8071: -- Description: YARN-6830 describes a problem where environment variables that contain commas cannot be

[jira] [Updated] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8071: -- Attachment: YARN-8071.001.patch > Add ability to specify nodemanager environment variables individually

[jira] [Updated] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8071: -- Summary: Add ability to specify nodemanager environment variables individually (was: Provide Spark-like

[jira] [Commented] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436387#comment-16436387 ] Jim Brennan commented on YARN-8071: --- Changed the description to be more accurate about what this Jira

[jira] [Commented] (YARN-8071) Provide Spark-like API for setting Environment Variables to enable vars with commas

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436207#comment-16436207 ] Jim Brennan commented on YARN-8071: --- MAPREDUCE-7069 resolved this problem for the following properties:

[jira] [Commented] (YARN-6434) When setting environment variables, can't use comma for a list of value in key = value pairs.

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436088#comment-16436088 ] Jim Brennan commented on YARN-6434: --- [~Jaeboo], please close this if you agree that it is resolved by

[jira] [Commented] (YARN-6434) When setting environment variables, can't use comma for a list of value in key = value pairs.

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436084#comment-16436084 ] Jim Brennan commented on YARN-6434: --- This issue was resolved in a different way in MAPREDUCE-7069.  You

[jira] [Commented] (YARN-8027) Setting hostname of docker container breaks for --net=host in docker 1.13

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436076#comment-16436076 ] Jim Brennan commented on YARN-8027: --- [~jlowe], this one is ready for review.   > Setting hostname of

[jira] [Commented] (YARN-8027) Setting hostname of docker container breaks for --net=host in docker 1.13

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435906#comment-16435906 ] Jim Brennan commented on YARN-8027: --- Submitted new branch-3.0 patch that fixes the broken

[jira] [Updated] (YARN-8027) Setting hostname of docker container breaks for --net=host in docker 1.13

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8027: -- Attachment: YARN-8027-branch-3.0.002.patch > Setting hostname of docker container breaks for --net=host

[jira] [Commented] (YARN-8027) Setting hostname of docker container breaks for --net=host in docker 1.13

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435891#comment-16435891 ] Jim Brennan commented on YARN-8027: --- Missed fixing that test that randomly picks which network to use. 

[jira] [Commented] (YARN-8027) Setting hostname of docker container breaks for --net=host in docker 1.13

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435712#comment-16435712 ] Jim Brennan commented on YARN-8027: --- Renamed branch-3 patch for branch-3.0. > Setting hostname of docker

[jira] [Updated] (YARN-8027) Setting hostname of docker container breaks for --net=host in docker 1.13

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8027: -- Attachment: (was: YARN-8027-branch-3.001.patch) > Setting hostname of docker container breaks for

[jira] [Updated] (YARN-8027) Setting hostname of docker container breaks for --net=host in docker 1.13

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8027: -- Attachment: YARN-8027-branch-3.0.001.patch > Setting hostname of docker container breaks for --net=host

[jira] [Updated] (YARN-8027) Setting hostname of docker container breaks for --net=host in docker 1.13

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated YARN-8027: -- Attachment: YARN-8027-branch-3.001.patch > Setting hostname of docker container breaks for --net=host in

[jira] [Reopened] (YARN-8027) Setting hostname of docker container breaks for --net=host in docker 1.13

2018-04-12 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan reopened YARN-8027: --- Reopening so I can put up a patch for branch 3. > Setting hostname of docker container breaks for

[jira] [Commented] (YARN-8064) Docker ".cmd" files should not be put in hadoop.tmp.dir

2018-04-06 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428841#comment-16428841 ] Jim Brennan commented on YARN-8064: --- [~ebadger], one question - why are we retaining the old version of

[jira] [Commented] (YARN-7667) Docker Stop grace period should be configurable

2018-04-06 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428497#comment-16428497 ] Jim Brennan commented on YARN-7667: --- Patch looks good to me. > Docker Stop grace period should be

[jira] [Commented] (YARN-6830) Support quoted strings for environment variables

2018-04-04 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425644#comment-16425644 ] Jim Brennan commented on YARN-6830: --- Solution proposed by [~aw] for mapreduce variables is being

[jira] [Commented] (YARN-8029) YARN_CONTAINER_RUNTIME_DOCKER_MOUNTS should not use commas as separators

2018-03-29 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419392#comment-16419392 ] Jim Brennan commented on YARN-8029: --- Based on discussions in [YARN-6830], the preference is to provide a

[jira] [Commented] (YARN-8071) Provide Spark-like API for setting Environment Variables to enable vars with commas

2018-03-28 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417505#comment-16417505 ] Jim Brennan commented on YARN-8071: --- @jlowe, I've filed [MAPREDUCE-7069] for addressing the mapreduce

[jira] [Commented] (YARN-8071) Provide Spark-like API for setting Environment Variables to enable vars with commas

2018-03-27 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415782#comment-16415782 ] Jim Brennan commented on YARN-8071: --- [~jlowe], yes I think this will affect mapreduce, yarn, and common

[jira] [Commented] (YARN-6830) Support quoted strings for environment variables

2018-03-23 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412171#comment-16412171 ] Jim Brennan commented on YARN-6830: --- I filed [YARN-8071] to track the work on the [~aw] solution. >

[jira] [Commented] (YARN-8071) Provide Spark-like API for setting Environment Variables to enable vars with commas

2018-03-23 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412063#comment-16412063 ] Jim Brennan commented on YARN-8071: --- Alternate solutions to this problem (with patches) are provided in

[jira] [Created] (YARN-8071) Provide Spark-like API for setting Environment Variables to enable vars with commas

2018-03-23 Thread Jim Brennan (JIRA)
Jim Brennan created YARN-8071: - Summary: Provide Spark-like API for setting Environment Variables to enable vars with commas Key: YARN-8071 URL: https://issues.apache.org/jira/browse/YARN-8071 Project:

[jira] [Commented] (YARN-6830) Support quoted strings for environment variables

2018-03-23 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412003#comment-16412003 ] Jim Brennan commented on YARN-6830: --- [~jlowe], sounds good.  I will file a new Jira for the new approach

<    2   3   4   5   6   7   8   9   >