[
https://issues.apache.org/jira/browse/YARN-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719699#comment-17719699
]
Susheel Gupta edited comment on YARN-11464 at 5/5/23 7:14 AM:
--------------------------------------------------------------
I think this is not just a test issue. There was a missing dot before
"{color:#57d9a3}auto-queue-creation-v2.enabled{color}", which is one issue.
However, when I added a dot ({color:#57d9a3}.{color}) before
"{color:#57d9a3}auto-queue-creation-v2.enabled{color}" for the method call
assertNoValueForQueues in
{*}TestFSQueueConverter#testAutoCreateV2FlagsInWeightMode{*}, the test failed
again. This was because the queue root.admin.alice has
"auto-queue-creation-v2.enabled" set to true ({*}even though we don't have the
AQCv2 feature enabled to true for leaf queues{*}).
I tried to debug this and found that the XML file used for
TestFSQueueConverter#testAutoCreateV2FlagsInWeightMode is
"{{{}apache/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/resources/fair-scheduler-conversion.xml{}}}".
In this file, there are two queues, {{root.admin.alice}} and
{{{}root.admin.bob{}}}. When they defined the properties for root.admin.alice,
they added the <reservation> queue element, which is correct since it is a leaf
queue. However, due to the reservation queue element in root.admin.alice, its
queueType becomes QueueType.PARENT_QUEUE (I guess), and
"{color:#57d9a3}auto-queue-creation-v2.enabled{color}" is set to true for
alice, which is wrong. I checked by adding the reservation queue element for
other queues as well, namely {{{}root.admin.bob, root.users.john, and
root.users.joe{}}}. All of these queues have AQCv2 enabled to true when the
<reservation> queue element is added.
was (Author: JIRAUSER295692):
I think this is not just a test issue. There was a missing dot before
"{color:#57d9a3}auto-queue-creation-v2.enabled{color}", which is one issue.
However, when I added a dot ({color:#57d9a3}.{color}) before
"{color:#57d9a3}auto-queue-creation-v2.enabled{color}" for the method call
assertNoValueForQueues in
{*}TestFSQueueConverter#testAutoCreateV2FlagsInWeightMode{*}, the test failed
again. This was because the queue root.admin.alice has
"auto-queue-creation-v2.enabled" set to true ({*}even though we don't have the
AQCv2 feature enabled to true for leaf queues{*}).
I tried to debug this and found that the XML file used for
TestFSQueueConverter#testAutoCreateV2FlagsInWeightMode is
"{{{}apache/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/resources/fair-scheduler-conversion.xml{}}}".
In this file, there are two queues, {{root.admin.alice}} and
{{{}root.admin.bob{}}}. When they defined the properties for root.admin.alice,
they added the <reservation> queue element, which is correct since it is a leaf
queue. However, due to the reservation queue element in root.admin.alice, its
queueType becomes QueueType.PARENT_QUEUE, and
"{color:#57d9a3}auto-queue-creation-v2.enabled{color}" is set to true for
alice, which is wrong. I checked by adding the reservation queue element for
other queues as well, namely {{{}root.admin.bob, root.users.john, and
root.users.joe{}}}. All of these queues have AQCv2 enabled to true when the
<reservation> queue element is added.
> <reservation> queue element is added to any other leaf queue, it's queueType
> becomes QueueType.PARENT_QUEUE
> ------------------------------------------------------------------------------------------------------------
>
> Key: YARN-11464
> URL: https://issues.apache.org/jira/browse/YARN-11464
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Affects Versions: 3.3.4
> Reporter: Susheel Gupta
> Priority: Major
>
> This testcase clearly reproduces the issue. There is a missing dot before
> "auto-queue-creation-v2.enabled" for method call assertNoValueForQueues.
> {code:java}
> @Test
> public void testAutoCreateV2FlagsInWeightMode() {
> converter = builder.withPercentages(false).build();
> converter.convertQueueHierarchy(rootQueue);
> assertTrue("root autocreate v2 flag",
> csConfig.getBoolean(
> PREFIX + "root.auto-queue-creation-v2.enabled", false));
> assertTrue("root.admins autocreate v2 flag",
> csConfig.getBoolean(
> PREFIX + "root.admins.auto-queue-creation-v2.enabled", false));
> assertTrue("root.users autocreate v2 flag",
> csConfig.getBoolean(
> PREFIX + "root.users.auto-queue-creation-v2.enabled", false));
> assertTrue("root.misc autocreate v2 flag",
> csConfig.getBoolean(
> PREFIX + "root.misc.auto-queue-creation-v2.enabled", false));
> Set<String> leafs = Sets.difference(ALL_QUEUES,
> Sets.newHashSet("root",
> "root.default",
> "root.admins",
> "root.users",
> "root.misc"));
> assertNoValueForQueues(leafs, "auto-queue-creation-v2.enabled",
> csConfig);
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
