[
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450391#comment-15450391
]
Yufei Gu edited comment on YARN-5264 at 8/30/16 10:54 PM:
----------------------------------------------------------
Hi [~templedf], thanks a lot for the review. I agree with you that storing data
twice is bad. I wouldn't say it's impossible to consolidate them, but too
complicated to do it in this JIRA:
1. There are multiple places to initialize a queue. We need to consolidate them
or refactor somehow.
2. There are multiple types of queue, for example, "root" and "root.default",
"configured queue" and "ad hoc queue". The behaviors of these initialization
should be different.
3. There are a number of test cases built on current approaches are needed to
be investigated and refactored.
In this JIRA, I've limited the access of these maps in
{{AllocationConfiguration}} only for itself and its test case, so these
duplicate data can only used for initialization. That should be OK for the
current JIRA and we can completely remove duplicate data in a followup JIRA.
was (Author: yufeigu):
Hi [~templedf], thanks a lot for the review. I agree with you that storing data
twice is bad. I wouldn't say it's impossible to consolidate them, but too
complicated to do it in this JIRA:
1. There are multiple places to initialize a queue. We need to consolidate them
or refactor somehow.
2. There are multiple types of queue, for example, "root" and "root.default",
"configured queue" and "ad hoc queue". The behaviors of these initialization
should be different.
3. There are a number of test cases built on current approaches are needed to
be investigated and refactored.
In this JIRA, I've limited the access of these maps in
{{AllocationConfiguration}} only for itself and its test case, so these
duplicate data can only used for initialization. That should be OK for the
current JIRA and we can completely remove duplicate data in a followup JIRA?
> Use FSQueue to store queue-specific information
> -----------------------------------------------
>
> Key: YARN-5264
> URL: https://issues.apache.org/jira/browse/YARN-5264
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Attachments: YARN-5264.001.patch, YARN-5264.002.patch,
> YARN-5264.003.patch, YARN-5264.004.patch
>
>
> Use FSQueue to store queue-specific information instead of querying
> AllocationConfiguration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
